From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3BFF4AC06F1 for ; Wed, 3 Jan 2024 00:56:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=g115TCuqGtP2RivQEpDCOsY+O22+a4G6U90CsIcy/Lk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1704243392; v=1; b=qlksSI6sB0CGYg3zQANNVbpvp1/wP0kOmTlkEeoLrv2sJYlhLvkMSWW/iwi4Ip9YC3plTZ+R VS7rHsAYZMfx+qaJSjKkNWnbOkPMbO1qHaIMADpCO5xyBG3hFdqYqmGvQKNIZFEYnkCMcIax2EY 2CgSkwoTPwzvBNy/S62Kl7MY= X-Received: by 127.0.0.2 with SMTP id PuxMYY7687511xGLentdiNHS; Tue, 02 Jan 2024 16:56:32 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.3378.1704243391696697032 for ; Tue, 02 Jan 2024 16:56:32 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 47E35A32E0B8 for ; Wed, 3 Jan 2024 08:56:29 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 21E53A32E0BD for ; Wed, 3 Jan 2024 08:56:29 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id E91ADA32DFD2 for ; Wed, 3 Jan 2024 08:56:25 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 03 Jan 2024 08:56:23 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Dandan Bi'" References: <20240102151307.2516-1-ming.tan@intel.com> <20240102151307.2516-4-ming.tan@intel.com> In-Reply-To: <20240102151307.2516-4-ming.tan@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYyIDMvM10gTWRlTW9kdWxlUGtnL0RyaXZlclNhbXBsZUR4ZTogRUZJX0JST1dTRVJfQUNUSU9OX1JFUVVFU1RfUVVFU1RJT05fQVBQTFk=?= Date: Wed, 3 Jan 2024 08:56:25 +0800 Message-ID: <02de01da3ddf$adb36ef0$091a4cd0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQHc87iGPPRl3edqKy1G4f/c+YnRlwGiWGxosLTFGuA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RzjkDGd3srTI9h6bGcUxpwEGx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qlksSI6s; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao for this patch set.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Tan, Ming > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA1=D4=C22=C8=D5 23:13 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Liming Gao ; Dandan Bi > > =D6=F7=CC=E2: [edk2-devel] [PATCH V2 3/3] MdeModulePkg/DriverSampleDxe: > EFI_BROWSER_ACTION_REQUEST_QUESTION_APPLY >=20 > REF: UEFI_Spec_2_10_Aug29.pdf page 1695. >=20 > In 35.5.4 EFI_HII_CONFIG_ACCESS_PROTOCOL.CallBack(): > If the callback function returns with the ActionRequest set to > _QUESTION_APPLY, then the Forms Browser will write the current modified > question value on the selected form to storage. >=20 > Update the DriverSampleDxe, add a new question "Question apply test". >=20 > Signed-off-by: Ming Tan > Cc: Liming Gao > Cc: Dandan Bi > --- > .../Universal/DriverSampleDxe/DriverSample.c | 13 > +++++++++++++ > .../Universal/DriverSampleDxe/NVDataStruc.h | 1 + > MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 10 ++++++++++ > .../Universal/DriverSampleDxe/VfrStrings.uni | 4 ++++ > 4 files changed, 28 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > index 62ba52e940..003cb499b5 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > @@ -858,6 +858,7 @@ ExtractConfig ( > @retval EFI_INVALID_PARAMETER Configuration is NULL. >=20 > @retval EFI_NOT_FOUND Routing data doesn't match any > storage in this >=20 > driver. >=20 > + @retval EFI_DEVICE_ERROR If value is 44, return error for > testing. >=20 >=20 >=20 > **/ >=20 > EFI_STATUS >=20 > @@ -1065,6 +1066,11 @@ RouteConfig ( > return Status; >=20 > } >=20 >=20 >=20 > + if (PrivateData->Configuration.QuestionApply =3D=3D 44) { >=20 > + // Return error for verify the error handling of caller. >=20 > + return EFI_DEVICE_ERROR; >=20 > + } >=20 > + >=20 > // >=20 > // Store Buffer Storage back to EFI variable >=20 > // >=20 > @@ -1599,6 +1605,13 @@ DriverCallback ( > *ActionRequest =3D > EFI_BROWSER_ACTION_REQUEST_FORM_DISCARD_EXIT; >=20 > break; >=20 >=20 >=20 > + case 0x1253: >=20 > + // >=20 > + // User change the value of "Question apply test". >=20 > + // >=20 > + *ActionRequest =3D > EFI_BROWSER_ACTION_REQUEST_QUESTION_APPLY; >=20 > + break; >=20 > + >=20 > case 0x1231: >=20 > // >=20 > // 1. Check to see whether system support keyword. >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > index 489d7bcbf3..3f5388946d 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > +++ b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > @@ -95,6 +95,7 @@ typedef struct { > MY_EFI_UNION_DATA MyUnionData; >=20 > UINT8 QuestionXUefiKeywordRestStyle; >=20 > UINT8 QuestionNonXUefiKeywordRestStyle; >=20 > + UINT8 QuestionApply; >=20 > } DRIVER_SAMPLE_CONFIGURATION; >=20 >=20 >=20 > // >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > index 5323e2b411..0c376fe9b7 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > +++ b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > @@ -513,6 +513,16 @@ formset > default =3D 18, >=20 > endnumeric; >=20 >=20 >=20 > + numeric varid =3D MyIfrNVData.QuestionApply, >=20 > + questionid =3D 0x1253, >=20 > + prompt =3D > STRING_TOKEN(STR_QUESTION_APPLY_TEST_PROMPT), >=20 > + help =3D > STRING_TOKEN(STR_QUESTION_APPLY_TEST_HELP), >=20 > + flags =3D INTERACTIVE, >=20 > + minimum =3D 0, >=20 > + maximum =3D 255, >=20 > + default =3D 19, >=20 > + endnumeric; >=20 > + >=20 > text >=20 > help =3D STRING_TOKEN(STR_POPUP_TEST_HELP), >=20 > text =3D STRING_TOKEN(STR_POPUP_TEST_PROMPT), >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > index 8a3e286bec..ed906045fd 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > +++ b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > @@ -269,6 +269,10 @@ > #language > fr-FR "Submitted callback test" >=20 > #string STR_SUBMITTED_CALLBACK_TEST_HELP #language > en-US "Change the value and press F10 to submit will pop up a dialogue to > show SUBMITTED Callback has been triggered" >=20 > #language > fr-FR "Change the value and press F10 to submit will pop up a dialogue to > show SUBMITTED Callback has been triggered" >=20 > +#string STR_QUESTION_APPLY_TEST_PROMPT #language > en-US "Question apply test" >=20 > + #language > fr-FR "Question apply test" >=20 > +#string STR_QUESTION_APPLY_TEST_HELP #language > en-US "Change the value and it will be applied automaticlly. If set to 44= , then > return failed." >=20 > + #language > fr-FR "Change the value and it will be applied automaticlly. If set to 44= , then > return failed." >=20 > #string STR_POPUP_TEST_PROMPT #language > en-US "Select it to invoke Hii Popup Protocol" >=20 > #language > fr-FR "Select it to invoke Hii Popup Protocol" >=20 > #string STR_POPUP_TEST_HELP #language > en-US "Select this question will pop up a message box, then user can decide > whether exit current form or not" >=20 > -- > 2.39.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#113036): > https://edk2.groups.io/g/devel/message/113036 > Mute This Topic: https://groups.io/mt/103482807/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113047): https://edk2.groups.io/g/devel/message/113047 Mute This Topic: https://groups.io/mt/103494110/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-