From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.7226.1634632956263074219 for ; Tue, 19 Oct 2021 01:42:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4D29D6E; Tue, 19 Oct 2021 01:42:34 -0700 (PDT) Received: from [192.168.1.16] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1DA713F73D; Tue, 19 Oct 2021 01:42:33 -0700 (PDT) Message-ID: <02e228d9-ef07-065f-b133-f0530c8a4bf6@arm.com> Date: Tue, 19 Oct 2021 09:42:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [edk2-devel] [PATCH v2 7/7] Platform/ARM/N1Sdp: Enable ACPI tables and configuration manager To: devel@edk2.groups.io, khasim.mohammed@arm.com Cc: nd@arm.com, Sami Mujawar References: <20211010182956.13526-1-khasim.mohammed@arm.com> <20211010182956.13526-8-khasim.mohammed@arm.com> From: "PierreGondois" In-Reply-To: <20211010182956.13526-8-khasim.mohammed@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Khasim, On 10/10/21 19:29, Khasim Mohammed via groups.io wrote: > This patch enables ACPI tables and configuration manager for N1SDP > > Signed-off-by: Sami Mujawar > Signed-off-by: Khasim Syed Mohammed > --- > Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h | 35 ++++++++++++++++++++ > Platform/ARM/N1Sdp/N1SdpPlatform.dec | 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 10 ++++++ > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 9 +++++ > 4 files changed, 55 insertions(+) > create mode 100644 Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h > > diff --git a/Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h b/Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h > new file mode 100644 > index 0000000000..d81bdb3576 > --- /dev/null > +++ b/Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h > @@ -0,0 +1,35 @@ > +/** @file > + > + Copyright (c) 2021, ARM Limited. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef N1SDP_ACPI_HEADER_ > +#define N1SDP_ACPI_HEADER_ > + > +// > +// ACPI table information used to initialize tables. > +// > +#define EFI_ACPI_ARM_OEM_ID 'A','R','M','L','T','D' // OEMID 6 bytes long > +#define EFI_ACPI_ARM_OEM_TABLE_ID SIGNATURE_64('A','R','M','N','1','S','D','P') // OEM table id 8 bytes long > +#define EFI_ACPI_ARM_OEM_REVISION 0x20181101 > +#define EFI_ACPI_ARM_CREATOR_ID SIGNATURE_32('A','R','M',' ') > +#define EFI_ACPI_ARM_CREATOR_REVISION 0x00000099 > + > +// A macro to initialise the common header part of EFI ACPI tables as defined by > +// EFI_ACPI_DESCRIPTION_HEADER structure. > +#define ARM_ACPI_HEADER(Signature, Type, Revision) { \ > + Signature, /* UINT32 Signature */ \ > + sizeof (Type), /* UINT32 Length */ \ > + Revision, /* UINT8 Revision */ \ > + 0, /* UINT8 Checksum */ \ > + { EFI_ACPI_ARM_OEM_ID }, /* UINT8 OemId[6] */ \ > + EFI_ACPI_ARM_OEM_TABLE_ID, /* UINT64 OemTableId */ \ > + EFI_ACPI_ARM_OEM_REVISION, /* UINT32 OemRevision */ \ > + EFI_ACPI_ARM_CREATOR_ID, /* UINT32 CreatorId */ \ > + EFI_ACPI_ARM_CREATOR_REVISION /* UINT32 CreatorRevision */ \ > + } > + > +#endif /* N1SDP_ACPI_HEADER_ */ > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dec b/Platform/ARM/N1Sdp/N1SdpPlatform.dec > index d56891b985..36123ddac0 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dec > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dec > @@ -22,6 +22,7 @@ > # > ################################################################################ > [Includes.common] > + Include # Root include for the pakage > > [LibraryClasses] > ArmPlatformLib|Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > index d5ada590e1..aba843bc29 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > @@ -27,6 +27,9 @@ > !include Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > !include MdePkg/MdeLibs.dsc.inc > > +!include DynamicTablesPkg/DynamicTables.dsc.inc > +!include Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManager.dsc.inc Same remark as in "[PATCH v2 6/7] Platform/ARM/N1Sdp: Configuration Manager for N1Sdp" about the need to have this file: Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManager.dsc.inc > + > [LibraryClasses.common] > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > @@ -156,6 +159,9 @@ > gArmPlatformTokenSpaceGuid.PcdCoreCount|2 > gArmPlatformTokenSpaceGuid.PcdClusterCount|2 > > + # ACPI Table Version > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 > + > # Runtime Variable storage > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > @@ -215,6 +221,10 @@ > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > > + # ACPI Support > + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + > # Platform driver > Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > index 6b097438ad..6ede2b7fc8 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > @@ -94,6 +94,15 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > > + # ACPI Support > + INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + > + # Configuration Manager > + INF Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > + > + # Dynamic Table fdf > + !include DynamicTablesPkg/DynamicTables.fdf.inc > + > # Human Interface Support > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > Otherwise the patch looks good to me, Regards, Pierre