From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.7725.1666258143936427122 for ; Thu, 20 Oct 2022 02:29:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=h5iMPnsp; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 30FCFCD1F718 for ; Thu, 20 Oct 2022 17:29:00 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1666258140; bh=23FZTdnneLx1ilUZy3tvFQDY1+QgM47BHkQm99bAhO8=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=h5iMPnsphnETYtsvT233YAKPc3VsK0ofJaMbme+94kt5UG17tVKWMlgdwhWFAmzbm xi7r6MCQxl7KHBNrLuMw1b+yzZiDlSEbywsyrNh9HWTZxrAQgQrTYtKxnfUju+KqoV /R67j9JbZd/g2tiEyD5p/kqyIvhl9k6Ks/WOd3sw= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 2CEE1CD1F77B for ; Thu, 20 Oct 2022 17:29:00 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 0491ACD1F6BA for ; Thu, 20 Oct 2022 17:29:00 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 928DBCD1F687 for ; Thu, 20 Oct 2022 17:28:56 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 20 Oct 2022 17:28:54 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Feng, Bob C'" , Cc: "'Chen, Christine'" References: <171E6FA868D99F8D.19083@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzL1NjcmlwdHMvUGF0Y2hDaGVjay5weTogQWxsb3cgdGFiIGluIE1ha2VmaWxl?= Date: Thu, 20 Oct 2022 17:28:56 +0800 Message-ID: <02e401d8e466$60eab020$22c01060$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLiFKlF+P2S/lf5cu+uiV65oDTJvAGwEav8q/ci1AA= Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Feng, Bob C > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA10=D4=C219=C8=D5 9:46 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Feng, Bob C > =B3=AD=CB=CD: Gao, Liming ; Chen, Christine > > =D6=F7=CC=E2: RE: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.p= y: Allow > tab in Makefile >=20 > Hi Liming, Christine, >=20 > Please help review this patch. >=20 > This patch can unblock the CI test for the change of Makefile/GNUmakefile= . > https://github.com/tianocore/edk2/pull/3436 >=20 >=20 > Thanks, > Bob > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Sunday, October 16, 2022 11:41 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Chen, Christine > Subject: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow > tab in Makefile >=20 > The syntax for Makefiles requires that indented lines s tart with a tab, but not > a space. >=20 > This change of PatchCheck.py make the patch for Makefile/GNUmakefile pass > the PatchCheck.py. >=20 > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Scripts/PatchCheck.py | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 63e6223f8ebc..475b3a8c27d9 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -383,6 +383,9 @@ class GitDiffCheck: > # > self.force_crlf =3D False > self.force_notabs =3D False > + if os.path.basename(self.filename) =3D=3D 'GNUmakefile' = or \ > + os.path.basename(self.filename) =3D=3D 'Makefile': > + self.force_notabs =3D False > elif len(line.rstrip()) !=3D 0: > self.format_error("didn't find diff command") > self.line_num +=3D 1 > -- > 2.37.0.windows.1 >=20 >=20 >=20 >=20 >=20