From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web12.2991.1659669614282968977 for ; Thu, 04 Aug 2022 20:20:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=ojuY04+Z; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id E6097CD1F708 for ; Fri, 5 Aug 2022 11:20:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1659669612; bh=z5l0g9hoa+dt2B8YT5OFXriCCtomm7qFV9vRid0QgYg=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=ojuY04+Z61Kzj5RrfCyyvX+FqLiwjLtUuL00PjD3j1VTEgjcMfMZeeZ2/iWEF1Y1U IRQF6nIoKmTVqnFZf2Usrsz44cN35n8Lurk34jcvzp1BPyxrAFGvoA3cK1L8RPWewM i6eAuC1l+pvxyzpi97FDm1n70D7D7Sz3aqdtynQM= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id DFA07CD1F730 for ; Fri, 5 Aug 2022 11:20:11 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 96FA1CD1F703 for ; Fri, 5 Aug 2022 11:20:11 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 3BCC2CD1F722 for ; Fri, 5 Aug 2022 11:20:09 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 05 Aug 2022 11:20:06 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: , , References: <20220727084503.24035-1-aladyshev22@gmail.com> In-Reply-To: <20220727084503.24035-1-aladyshev22@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2cvRHVtcER5blBjZDogUmVtb3ZlIHVuc3VwcG9ydGVkIGZvcm1hdCBzcGVjaWZpZXJz?= Date: Fri, 5 Aug 2022 11:20:09 +0800 Message-ID: <02e701d8a87a$446c3bd0$cd44b370$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG/puDdoGq6DeTVFVVvf5kqjMJM363Rpqwg Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Thanks for your update. This change is good to me. Reviewed-by: Liming = Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io = =B4=FA=B1=ED Konstantin > Aladyshev > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA7=D4=C227=C8=D5 16:45 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: jian.j.wang@intel.com; gaoliming@byosoft.com.cn; > dandan.bi@intel.com; shenglei.zhang@intel.com; Konstantin Aladyshev > > =D6=F7=CC=E2: [edk2-devel] [PATCH] MdeModulePkg/DumpDynPcd: Remove > unsupported format specifiers >=20 > Some print statements use format specifiers like %N/%H/%E/%B that are > only supported in the shell print functions. In the ordinary 'Print' > function they are just displayed as letters N/H/E/B. > Remove these unsupported format specifiers from the 'Print' statements > to fix the issue. >=20 > Signed-off-by: Konstantin Aladyshev > --- > .../Application/DumpDynPcd/DumpDynPcd.c | 28 > +++++++++---------- > 1 file changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c > b/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c > index b8571c4556..013198963e 100644 > --- a/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c > +++ b/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c > @@ -361,7 +361,7 @@ DumpPcdInfo ( > Uint8 =3D mPiPcd->Get8 (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x - Value > =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint8); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - = Value =3D > 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint8); >=20 > break; >=20 > case EFI_PCD_TYPE_16: >=20 > if (TokenSpace =3D=3D NULL) { >=20 > @@ -370,7 +370,7 @@ DumpPcdInfo ( > Uint16 =3D mPiPcd->Get16 (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x - Value > =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint16); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - = Value =3D > 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint16); >=20 > break; >=20 > case EFI_PCD_TYPE_32: >=20 > if (TokenSpace =3D=3D NULL) { >=20 > @@ -379,7 +379,7 @@ DumpPcdInfo ( > Uint32 =3D mPiPcd->Get32 (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x - Value > =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint32); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - = Value =3D > 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint32); >=20 > break; >=20 > case EFI_PCD_TYPE_64: >=20 > if (TokenSpace =3D=3D NULL) { >=20 > @@ -388,7 +388,7 @@ DumpPcdInfo ( > Uint64 =3D mPiPcd->Get64 (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x - Value > =3D 0x%lx\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint64); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - = Value =3D > 0x%lx\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint64); >=20 > break; >=20 > case EFI_PCD_TYPE_BOOL: >=20 > if (TokenSpace =3D=3D NULL) { >=20 > @@ -397,7 +397,7 @@ DumpPcdInfo ( > Boolean =3D mPiPcd->GetBool (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x - Value > =3D %a\n", TokenNumber, RetString, PcdInfo->PcdSize, Boolean ? "TRUE" = : > "FALSE"); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - = Value > =3D %a\n", TokenNumber, RetString, PcdInfo->PcdSize, Boolean ? "TRUE" = : > "FALSE"); >=20 > break; >=20 > case EFI_PCD_TYPE_PTR: >=20 > if (TokenSpace =3D=3D NULL) { >=20 > @@ -406,7 +406,7 @@ DumpPcdInfo ( > PcdData =3D mPiPcd->GetPtr (TokenSpace, TokenNumber); >=20 > } >=20 >=20 >=20 > - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D = 0x%x\n", > TokenNumber, RetString, PcdInfo->PcdSize); >=20 > + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D = 0x%x\n", > TokenNumber, RetString, PcdInfo->PcdSize); >=20 > DumpHex (2, 0, PcdInfo->PcdSize, PcdData); >=20 > break; >=20 > default: >=20 > @@ -509,7 +509,7 @@ ProcessPcd ( > // >=20 > // The specified PCD is not found, print error. >=20 > // >=20 > - Print (L"%EError. %NNo matching PCD found: %s.\n", InputPcdName); >=20 > + Print (L"Error. No matching PCD found: %s.\n", InputPcdName); >=20 > return EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > @@ -548,25 +548,25 @@ DumpDynPcdMain ( >=20 >=20 > Status =3D gBS->LocateProtocol (&gEfiPcdProtocolGuid, NULL, (VOID > **)&mPiPcd); >=20 > if (EFI_ERROR (Status)) { >=20 > - Print (L"DumpDynPcd: %EError. %NPI PCD protocol is not = present.\n"); >=20 > + Print (L"DumpDynPcd: Error. PI PCD protocol is not present.\n"); >=20 > return Status; >=20 > } >=20 >=20 >=20 > Status =3D gBS->LocateProtocol (&gEfiGetPcdInfoProtocolGuid, NULL, = (VOID > **)&mPiPcdInfo); >=20 > if (EFI_ERROR (Status)) { >=20 > - Print (L"DumpDynPcd: %EError. %NPI PCD info protocol is not > present.\n"); >=20 > + Print (L"DumpDynPcd: Error. PI PCD info protocol is not = present.\n"); >=20 > return Status; >=20 > } >=20 >=20 >=20 > Status =3D gBS->LocateProtocol (&gPcdProtocolGuid, NULL, (VOID > **)&mPcd); >=20 > if (EFI_ERROR (Status)) { >=20 > - Print (L"DumpDynPcd: %EError. %NPCD protocol is not present.\n"); >=20 > + Print (L"DumpDynPcd: Error. PCD protocol is not present.\n"); >=20 > return Status; >=20 > } >=20 >=20 >=20 > Status =3D gBS->LocateProtocol (&gGetPcdInfoProtocolGuid, NULL, = (VOID > **)&mPcdInfo); >=20 > if (EFI_ERROR (Status)) { >=20 > - Print (L"DumpDynPcd: %EError. %NPCD info protocol is not present.\n"); >=20 > + Print (L"DumpDynPcd: Error. PCD info protocol is not = present.\n"); >=20 > return Status; >=20 > } >=20 >=20 >=20 > @@ -575,13 +575,13 @@ DumpDynPcdMain ( > // >=20 > Status =3D GetArg (); >=20 > if (EFI_ERROR (Status)) { >=20 > - Print (L"DumpDynPcd: %EError. %NThe input parameters are not > recognized.\n"); >=20 > + Print (L"DumpDynPcd: Error. The input parameters are not > recognized.\n"); >=20 > Status =3D EFI_INVALID_PARAMETER; >=20 > return Status; >=20 > } >=20 >=20 >=20 > if (Argc > 2) { >=20 > - Print (L"DumpDynPcd: %EError. %NToo many arguments = specified.\n"); >=20 > + Print (L"DumpDynPcd: Error. Too many arguments specified.\n"); >=20 > Status =3D EFI_INVALID_PARAMETER; >=20 > return Status; >=20 > } >=20 > @@ -600,7 +600,7 @@ DumpDynPcdMain ( > goto Done; >=20 > } else { >=20 > if (StrStr (Argv[1], L"-") !=3D NULL) { >=20 > - Print (L"DumpDynPcd: %EError. %NThe argument '%B%s%N' is > invalid.\n", Argv[1]); >=20 > + Print (L"DumpDynPcd: Error. The argument '%s' is invalid.\n", > Argv[1]); >=20 > goto Done; >=20 > } >=20 > } >=20 > -- > 2.25.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#91887): = https://edk2.groups.io/g/devel/message/91887 > Mute This Topic: https://groups.io/mt/92645389/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20