public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <junfengx.guan@intel.com>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Yi Li'" <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL
Date: Thu, 11 Jan 2024 10:18:52 +0800	[thread overview]
Message-ID: <02eb01da4434$8606c630$92145290$@byosoft.com.cn> (raw)
In-Reply-To: <46bbad77f08f2acefbc10475695e5133704d35c2.1703641932.git.junfengx.guan@intel.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan
> 发送时间: 2023年12月27日 9:57
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li
> <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the
> EFI_NVDIMM_LABEL
> 
> Refer to Uefi spec 2.10 section 13.19.5, update the label definitions
> for NVDIMM SPA location cookie.
> 
> Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h
> b/MdePkg/Include/Protocol/NvdimmLabel.h
> index e46999a3ab4a..2352c9bd1652 100644
> --- a/MdePkg/Include/Protocol/NvdimmLabel.h
> +++ b/MdePkg/Include/Protocol/NvdimmLabel.h
> @@ -122,6 +122,12 @@ typedef struct {
>  ///
>  #define EFI_NVDIMM_LABEL_FLAGS_UPDATING  0x00000008
> 
> +///
> +/// When set, the SPALocationCookie in the namespace label is valid and
> should match the
> +/// current value in the NFIT SPA Range Structure.
> +///
> +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND  0x00000010
> +
>  typedef struct {
>    ///
>    /// Unique Label Identifier UUID per RFC 4122.
> @@ -196,10 +202,18 @@ typedef struct {
>    ///
>    EFI_GUID    AddressAbstractionGuid;
> 
> +  ///
> +  /// When creating the label, this value is set to the value from the
NFIT
> SPA Range Structure if the
> +  /// SPALocationCookie flag (bit 2) is set. If
> EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the
> SPALocationCookie
> +  /// value stored in the namespace label should match the current value
in
> the NFIT SPA Range Structure.
> +  /// Otherwise, the data may not be read correctly.
> +  ///
> +  UINT64      SPALocationCookie;
> +
>    ///
>    /// Shall be 0.
>    ///
> -  UINT8       Reserved1[88];
> +  UINT8       Reserved1[80];
> 
>    ///
>    /// 64-bit Fletcher64 checksum of all fields in this Label.
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113572): https://edk2.groups.io/g/devel/message/113572
Mute This Topic: https://groups.io/mt/103655517/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-01-11  2:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1703641932.git.junfengx.guan@intel.com>
2023-12-27  1:56 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Junfeng Guan
2024-01-11  2:18   ` gaoliming via groups.io [this message]
2024-01-11  7:54     ` Junfeng Guan
2024-01-16  0:58       ` Junfeng Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02eb01da4434$8606c630$92145290$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox