public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <junfengx.guan@intel.com>
Cc: "'Kinney, Michael D'" <michael.d.kinney@intel.com>,
	"'Liu, Zhiguang'" <zhiguang.liu@intel.com>,
	"'Li, Yi1'" <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description
Date: Thu, 11 Jan 2024 10:20:35 +0800	[thread overview]
Message-ID: <02ee01da4434$c35ab1e0$4a1015a0$@byosoft.com.cn> (raw)
In-Reply-To: <DM6PR11MB36448B7230F43CF013160E74FF682@DM6PR11MB3644.namprd11.prod.outlook.com>

Junfeng:
  I add push label for this PR.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan
> 发送时间: 2024年1月11日 9:14
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus
> function description
> 
> Hi Liming,
>    Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5248
>    Could you help push it?
> 
> B.R.
> Junfeng
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Wednesday, January 10, 2024 2:19 PM
> To: devel@edk2.groups.io; Guan, JunfengX <junfengx.guan@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus
> function description
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng
> Guan
> > 发送时间: 2023年12月28日 15:54
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi
> > Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function
> > description
> >
> > Refer to Uefi spec 2.10 section 11.10.2, update the return value for
> > EFI_DRIVER_HEALTH_PROTOCOL.GetHealthStatus.
> >
> > Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> >  MdePkg/Include/Protocol/DriverHealth.h | 32
> > +++++++-------------------
> >  1 file changed, 8 insertions(+), 24 deletions(-)
> >
> > diff --git a/MdePkg/Include/Protocol/DriverHealth.h
> > b/MdePkg/Include/Protocol/DriverHealth.h
> > index 9de025434ef3..9e1bd903f4be 100644
> > --- a/MdePkg/Include/Protocol/DriverHealth.h
> > +++ b/MdePkg/Include/Protocol/DriverHealth.h
> > @@ -137,35 +137,19 @@ EFI_STATUS
> >                                will only be returned with a
> > HealthStatus value of
> >
> > EfiDriverHealthStatusConfigurationRequired.
> >
> > -  @retval EFI_SUCCESS           ControllerHandle is NULL, and all the
> > controllers
> > -                                managed by this driver specified by
> > This have a health
> > -                                status of
> > EfiDriverHealthStatusHealthy with no warning
> > -                                messages to be returned.  The
> > ChildHandle, HealthStatus,
> > -                                MessageList, and FormList
> > parameters are ignored.
> > -
> > -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one
> or
> > more of the
> > -                                controllers managed by this driver
> > specified by This
> > -                                do not have a health status of
> > EfiDriverHealthStatusHealthy.
> > -                                The ChildHandle, HealthStatus,
> > MessageList, and
> > -                                FormList parameters are ignored.
> > -
> > -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one
> or
> > more of the
> > -                                controllers managed by this driver
> > specified by This
> > -                                have one or more warning and/or
> > error messages.
> > -                                The ChildHandle, HealthStatus,
> > MessageList, and
> > -                                FormList parameters are ignored.
> > -
> > -  @retval EFI_SUCCESS           ControllerHandle is not NULL and
> the
> > health status
> > -                                of the controller specified by
> > ControllerHandle and
> > -                                ChildHandle was returned in
> > HealthStatus.  A list
> > -                                of warning and error messages
> may
> > be optionally
> > -                                returned in MessageList, and a list
> of
> > HII Forms
> > -                                may be optionally returned in
> > FormList.
> > +  @retval EFI_SUCCESS           The health status of the controller
> > specified by
> > +                                ControllerHandle and ChildHandle
> > was returned in HealthStatus.
> > +                                A list of warning and error
> messages
> > may be optionally
> > +                                returned in MessageList, and an
> HII
> > Form may be optionally
> > +                                specified by FormHiiHandle.
> >
> >    @retval EFI_UNSUPPORTED       ControllerHandle is not NULL, and
> > the controller
> >                                  specified by ControllerHandle and
> > ChildHandle is not
> >                                  currently being managed by the
> driver
> > specified by This.
> >
> > +  @retval EFI_UNSUPPORTED       ControllerHandle is NULL and
> there
> > are no devices being
> > +                                managed by the driver.
> > +
> >    @retval EFI_INVALID_PARAMETER HealthStatus is NULL.
> >
> >    @retval EFI_OUT_OF_RESOURCES  MessageList is not NULL, and
> there
> > are not enough
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113573): https://edk2.groups.io/g/devel/message/113573
Mute This Topic: https://groups.io/mt/103655535/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-01-11  2:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1703749992.git.junfengx.guan@intel.com>
2023-12-28  7:53 ` [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description Junfeng Guan
2024-01-10  6:18   ` 回复: " gaoliming via groups.io
2024-01-11  1:14     ` Junfeng Guan
2024-01-11  2:20       ` gaoliming via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02ee01da4434$c35ab1e0$4a1015a0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox