From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8FA1E7803D8 for ; Wed, 20 Dec 2023 09:39:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WSD73/tR8qjdLmTWc4w3xinPRS5aOWEKIhe5rfxlfj4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703065147; v=1; b=Um2yQIXqbGp/M3ENald4Rtq5zeDDTmx3L4IfLfXT87M+o3JJoGQGmGdskvVtPFj6LMPKZzY6 A1JDv67G8PRl6KjM4m4hSdPJK7e5nSK+6PQtw3gYR5AtkCh/dyI1YYOu/k1enCydMw+7XvEL3EF tqKqtNMJe6J0IOPFi2t6EA+w= X-Received: by 127.0.0.2 with SMTP id gojCYY7687511xHyfApxgYWz; Wed, 20 Dec 2023 01:39:07 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.43]) by mx.groups.io with SMTP id smtpd.web11.18250.1703065146586709817 for ; Wed, 20 Dec 2023 01:39:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlYzW3swDPRYbQw73vVoDfqzIyUFsw1xvcEEbTOgmBjxV68zlXIy+qc/dBhzbU4dMCQhfyYTxRef7FcPr6OYqMLnXbOyxou8CC1JRHCxPko0Pm8eCwcnUt47jiUIbvB7IiOshAY7Wpxs3CKeUsssoUpFt/ifiYnHp83Wv2uIUWBzZtsMz6wyTK7D6eu0ojBHmEX5M66OBhz9/AK0i1M7w6NU4JGAp0CaetNw3GDoLlyPKxyyqZVqRSwRxe4MlOQNfyhPPlRESLO7DbFmzvJo0w26TuhM2a5lJ9qXnyfQh6uLNz2AsUDufSWq4QFCvoxhzNRLbYTvunMtlVG4lKZYeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeouz/5So9nz9p2rARz3MGX245BRuAQFliJwTfrAf8I=; b=khmyBdRdehwDhHwywV0XcgNNThdw5E9zj/f2mNE1VtkYrjSqfANvrGjGyCbL200H+cqKwOJQFvHaLIBzWKyQETY9DIZAkKvPQ1x1yI6GyJHRlH3i6UixI1V2JY95uA8JkUq9Z1EtgYYzHkVF7+q+XVyyb+eAYG7t7p4hT/vubposYXiAZQzzWV7S7uus7lAevuUlzG2N6ERmcWqpCn3Fp6C3CPO9KnZhF4uT2JfbagXcSUq/hem69B5uBmJMxDlNmv8e+yxsO8bwYToJdLFC+6WXT5yhqPzAkREjwz9InpAwj91mg41sxTeBGGKf8zLAWdjC/QKMB883IGDI9gB9mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR05CA0060.namprd05.prod.outlook.com (2603:10b6:5:335::29) by SA1PR12MB7174.namprd12.prod.outlook.com (2603:10b6:806:2b1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Wed, 20 Dec 2023 09:39:03 +0000 X-Received: from DS1PEPF0001709A.namprd05.prod.outlook.com (2603:10b6:5:335:cafe::a3) by DM6PR05CA0060.outlook.office365.com (2603:10b6:5:335::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.16 via Frontend Transport; Wed, 20 Dec 2023 09:39:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0001709A.mail.protection.outlook.com (10.167.18.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 09:39:03 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:39:03 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 20 Dec 2023 03:39:01 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v5 4/4] DynamicTablesPkg: AML Code generation to invoke a method Date: Wed, 20 Dec 2023 15:08:51 +0530 Message-ID: <0304349ab5b384980681427b98dc3313faf279eb.1703064925.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709A:EE_|SA1PR12MB7174:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b8b0fac-d354-4ce0-6b3c-08dc013f80f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: fVY6I1y6KCbxNTiFF8tMK1XfEfer/5qpVJyN32LriC4s0vHLm84QHtyTmKrnMpB91HOZt6/qfASeKhFyIPIiGOlqQSUcwdSJY6XuMkr1ZluOVuIQLnqjBVkTkjCLMQ+ga5rsICbYuTU19lpyMikVBwEeMsd+1c2/xpK78z3T92An7JW3FyFlH25ZpTt1Go2y7OHOcDPL9x5y+Lmz6Zlerw11nvXDeNH4xUaPzFljc1153CrlAe4XtnEDgVbetV94ZuC/temOfyr5lqAsjKv6EyiBS0uNSGBm40YKvM0kab9E9SGa9gerB8K/aeQ07IwANjWDMQ6FAbCgszs3aDN6r1bLgOw8atGX904PjzWf2z9xWzlOXUGJ+0eJ9dbnCVaoPffo+h3KoBKhvUrn90g/LQg8ZWb48JDGRf+7UoveO7St0YfvANXq6Cp8QvRfiP2ly31DP0YRy3HD6h8q87wl3LHYTQsgH0L96rDilsIiuj3amufeYLfXtPKy0rCbtAnAKDXRewQR6FVT4P6F9No//l5YHZXeFqeNh1LELZLOVTJaIOR0l04U/cvSo7YEJA2XuVeaQgTMUj8DBHacF7eznpJoIcONFiNQ4r+x3XQ18syoM7HtgCOJuDRl++JysdJ3hkshuvyJL8zqgG5jiLcucaDD4+1RayBmmWXcnQZvbC6HROiukvQP47WlP9/Z6HVcMmpSBWNM4uefoHrM3JebHd+6BgorOTce0Kry/iQQnU30nBf2D/a4kV5hOEG0ClpQaJEWaoPo06CgnVILi/VgUw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 09:39:03.7121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b8b0fac-d354-4ce0-6b3c-08dc013f80f5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7174 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4zFrwfluSw5dMCNWNpk0Gqpbx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Um2yQIXq; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type integer, string, ArgObj or LocalObj. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 112 +++++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 235 +++++++++++++++++- 2 files changed, 346 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index eb8740692f..043ec3d842 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -101,6 +101,56 @@ typedef enum { AmlAddressRangeMax =3D 4 } AML_MEMORY_ATTRIBUTES_MTP; =20 +/** Method parameter types + + Possible values are: + 0 - AmlMethodParamTypeInteger + 1 - AmlMethodParamTypeString + 2 - AmlMethodParamTypeArg + 3 - AmlMethodParamTypeLocal + + @par Reference(s) + - ACPI 6.5, s20.2.5 "Term Objects Encoding" + +**/ +typedef enum { + AmlMethodParamTypeInteger =3D 0, + AmlMethodParamTypeString =3D 1, + AmlMethodParamTypeArg =3D 2, + AmlMethodParamTypeLocal =3D 3 +} AML_METHOD_PARAM_TYPE; + +/** AML Method parameter data + holds the AML method parameter data. +**/ +typedef union { + UINT8 Arg; + UINT8 Local; + UINT64 Integer; + VOID *Buffer; +} AML_METHOD_PARAM_DATA; + +/** structure to hold AML method parameter types + Type - Type of parameter + Data - holds data of parameter + if Type is AmlMethodParamTypeInteger + then Data is of type Integer to hold integer value. + if Type is AmlMethodParamTypeString + then Data contains null terminated string. + If Type is AmlMethodParamTypeArg + then Data contains the Argument number, + 0 to 6 are supported value. + If Type is AmlMethodParamTypeLocal + then Data contains the Local variable number, + 0 to 7 are supported value. + DataSize - for future use +**/ +typedef struct { + AML_METHOD_PARAM_TYPE Type; + AML_METHOD_PARAM_DATA Data; + UINTN DataSize; +} AML_METHOD_PARAM; + /** Parse the definition block. =20 The function parses the whole AML blob. It starts with the ACPI DSDT/SSD= T @@ -1693,4 +1743,66 @@ AmlAddNameStringToNamedPackage ( IN AML_OBJECT_NODE_HANDLE NamedNode ); =20 +/** AML code generation to invoke/call another method. + + This method is a subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent to the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent to the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent to the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString The method name to be called or invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters Contains the parameter data. + @param [in] ParentNode The parent node to which the method invoca= tion + nodes are attached. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a6db34fb97..ddec9b67ed 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,6 +2,7 @@ AML Code Generation. =20 Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -921,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status =3D AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { @@ -3849,3 +3850,235 @@ exit_handler: =20 return Status; } + +/** AML code generation to invoke/call another method. + + This method is a subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent to the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent to the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent to the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString The method name to be called or invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters Contains the parameter data. + @param [in] ParentNode The parent node to which the method invoca= tion + nodes are attached. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ) +{ + EFI_STATUS Status; + UINT8 Index; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + AML_DATA_NODE *DataNode; + AML_OBJECT_NODE *ObjectNode; + AML_NODE_HANDLE *NodeStream; + + if ((MethodNameString =3D=3D NULL) || (ParentNode =3D=3D NULL)) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if ((NumArgs > 7) || + ((Parameters =3D=3D NULL) && (NumArgs > 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + /// Allocate space to store methodname, object, data node pointers + NodeStream =3D AllocateZeroPool (sizeof (AML_NODE_HANDLE) * (NumArgs + 1= )); + if (NodeStream =3D=3D NULL) { + ASSERT (0); + return EFI_OUT_OF_RESOURCES; + } + + /// Create a called or invoked method name string. + Status =3D ConvertAslNameToAmlName (MethodNameString, &AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + FreePool (AmlNameString); + goto exit_handler; + } + + DataNode =3D NULL; + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + FreePool (AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[0] =3D (AML_NODE_HANDLE)DataNode; + + if (Parameters !=3D NULL) { + /// Validate and convert the Parameters to the stream of nodes. + for (Index =3D 0; Index < NumArgs; Index++) { + switch (Parameters[Index].Type) { + case AmlMethodParamTypeInteger: + ObjectNode =3D NULL; + Status =3D AmlCodeGenInteger (Parameters[Index].Data.Integer= , &ObjectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeString: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Buffer =3D=3D NULL) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCodeGenString (Parameters[Index].Data.Buffer, &Obj= ectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeArg: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Arg > (UINT8)(AML_ARG6 - AML_ARG0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_ARG0 + Parameters[Ind= ex].Data.Arg, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeLocal: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Local > (UINT8)(AML_LOCAL7 - AML_LOCA= L0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_LOCAL0 + Parameters[I= ndex].Data.Local, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + default: + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + break; + } + } + } + + /// Index <=3D NumArgs, because an additional method name was added. + for (Index =3D 0; Index <=3D NumArgs; Index++) { + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + (AML_NODE_HANDLE)NodeStream[Index] + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler_detach; + } + } + + FreePool (NodeStream); + return Status; + +exit_handler_detach: + /// The index contains the last successful node attached. + for ( ; Index > 0; Index--) { + /// Index contains the node number that is failed for AmlVarListAddTai= l(). + /// Hence, start detaching from the last successful + AmlDetachNode (NodeStream[Index-1]); + } + +exit_handler: + /// Index <=3D NumArgs, because an additional method name was added. + for (Index =3D 0; Index <=3D NumArgs; Index++) { + if (NodeStream[Index] !=3D 0) { + AmlDeleteTree (NodeStream[Index]); + } + } + + FreePool (NodeStream); + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112757): https://edk2.groups.io/g/devel/message/112757 Mute This Topic: https://groups.io/mt/103278521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-