From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web12.3920.1659679137657121758 for ; Thu, 04 Aug 2022 22:58:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=RPxt3/lq; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 1C07ACD1F771 for ; Fri, 5 Aug 2022 13:58:53 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1659679133; bh=p0vaYQ6tt4mh6+AqSLj56Z2Y/7t5EG1Un/oMaeO7Dhc=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=RPxt3/lqEtI9HVczUcW7Mq2sHoVjl03278ZTvKS2y3ehPrjAI9YaEbKWIOhkkhrXE k0G6ttLYZrdaSuUzeHy9qCieZKn51yb0dpOxDM6QUdoqXzbvCl5LojYMTtGlztNB5A fDC7Ilx1LfW8wZnQRi5uTksS8elbk7phZiY0a1DQ= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 183B5CD1F701 for ; Fri, 5 Aug 2022 13:58:53 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id CF42BCD1F72C for ; Fri, 5 Aug 2022 13:58:52 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 6EB33CD1F7DD for ; Fri, 5 Aug 2022 13:58:49 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 05 Aug 2022 13:58:46 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Sean Rhodes'" , Cc: "'Zhichao Gao'" , "'Ray Ni'" , "'Jian J Wang'" References: <4db16236c17eeb47b48ffb43f61d2d4e8f2e2671.1658823319.git.sean@starlabs.systems> In-Reply-To: <4db16236c17eeb47b48ffb43f61d2d4e8f2e2671.1658823319.git.sean@starlabs.systems> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMi8zXSBNZGVNb2R1bGVQa2cvTG9nbzogQWRkIGEgUENEIHRvIGNvbnRyb2wgdGhlIHBvc2l0aW9uIG9mIHRoZSBMb2dv?= Date: Fri, 5 Aug 2022 13:58:50 +0800 Message-ID: <030601d8a890$6f3f3540$4dbd9fc0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJMbIFcm0feeLs39T7bHusF0sj6tQJS2+tlrKWwsAA= Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Sean: I add my comments below.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Sean Rhodes > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA7=D4=C226=C8=D5 16:15 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Sean Rhodes ; Zhichao Gao > ; Ray Ni ; Jian J Wang > ; Liming Gao > =D6=F7=CC=E2: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the = position of > the Logo >=20 > When set to true, the Logo is positioned according to the BGRT > specification, 38.2% from the top of the screen. When set to false, > no behaviour is changed and the logo is positioned centrally. >=20 > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Signed-off-by: Sean Rhodes > --- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 5 ++++- > MdeModulePkg/Logo/Logo.c | 5 +++++ > MdeModulePkg/Logo/LogoDxe.inf | 4 ++++ > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > 5 files changed, 25 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > index 7d50f2dfa3..14ba8a5906 100644 > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > @@ -48,5 +48,8 @@ > gEfiUserManagerProtocolGuid ## CONSUMES >=20 > gEdkiiPlatformLogoProtocolGuid ## CONSUMES >=20 >=20 >=20 > +[Pcd] >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowBGRTSpecification ## > CONSUMES >=20 > + >=20 > [FeaturePcd] >=20 > - gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport ## CONSUMES >=20 > + gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport ## > CONSUMES >=20 The change in BootLogoLib is not required. Please check.=20 > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > index 8ab874d2da..73546b32f4 100644 > --- a/MdeModulePkg/Logo/Logo.c > +++ b/MdeModulePkg/Logo/Logo.c > @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 > #include >=20 > +#include >=20 >=20 >=20 > typedef struct { >=20 > EFI_IMAGE_ID ImageId; >=20 > @@ -69,6 +70,10 @@ GetImage ( > return EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > + if (FixedPcdGetBool (PcdFollowBGRTSpecification)) { >=20 > + mLogos[Current].Attribute =3D > EdkiiPlatformLogoDisplayAttributeBGRTSpecification; >=20 > + } >=20 > + Here, please use PcdGetBool().=20 Thanks Liming >=20 > (*Instance)++; >=20 > *Attribute =3D mLogos[Current].Attribute; >=20 > *OffsetX =3D mLogos[Current].OffsetX; >=20 > diff --git a/MdeModulePkg/Logo/LogoDxe.inf > b/MdeModulePkg/Logo/LogoDxe.inf > index 41215d25d8..c5c8ad0bcf 100644 > --- a/MdeModulePkg/Logo/LogoDxe.inf > +++ b/MdeModulePkg/Logo/LogoDxe.inf > @@ -41,6 +41,7 @@ > UefiBootServicesTableLib >=20 > UefiDriverEntryPoint >=20 > DebugLib >=20 > + PcdLib >=20 >=20 >=20 > [Protocols] >=20 > gEfiHiiDatabaseProtocolGuid ## CONSUMES >=20 > @@ -48,6 +49,9 @@ > gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES >=20 > gEdkiiPlatformLogoProtocolGuid ## PRODUCES >=20 >=20 >=20 > +[Pcd] >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowBGRTSpecification ## > CONSUMES >=20 > + >=20 > [Depex] >=20 > gEfiHiiDatabaseProtocolGuid AND >=20 > gEfiHiiImageExProtocolGuid >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 2bcb9f9453..e09918387c 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2095,6 +2095,12 @@ > # @Prompt The shared bit mask when Intel Tdx is enabled. >=20 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x10 > 000025 >=20 >=20 >=20 > + ## This PCD sets the position of the Boot Logo. >=20 > + # TRUE - The Logo is positioned according to the BGRT = specification. >=20 > + # FALSE - The logo is positioned in the center of the screen. >=20 > + # @ Prompt This position of the boot logo >=20 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdFollowBGRTSpecification|FALSE|BOO > LEAN|0x10000026 >=20 > + >=20 > [PcdsPatchableInModule] >=20 > ## Specify memory size with page number for PEI code when >=20 > # Loading Module at Fixed Address feature is enabled. >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index b070f15ff2..c6ff7bc1bd 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1334,3 +1334,9 @@ > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HELP > #language en-US "Indicates if the PCIe Resizable BAR Capability > Supported.

\n" >=20 >=20 > "TRUE - PCIe Resizable BAR Capability is supported.
\n" >=20 >=20 > "FALSE - PCIe Resizable BAR Capability is not supported.
" >=20 > + >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowBGRTSpecification_PROM > PT #language en-US "The position of the Boot Logo" >=20 > + >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowBGRTSpecification_HELP > #language en-US "Sets the position of the Logo. When set to true, the = Logo is > positioned according to the" >=20 > + > " BGRT specification, 38.2% from the top of the screen." >=20 > + >=20 > -- > 2.34.1