From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <sean@starlabs.systems>
Cc: "'Zhichao Gao'" <zhichao.gao@intel.com>,
"'Ray Ni'" <ray.ni@intel.com>,
"'Jian J Wang'" <jian.j.wang@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification
Date: Fri, 5 Aug 2022 13:59:58 +0800 [thread overview]
Message-ID: <030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn> (raw)
In-Reply-To: <cd15a90e1fffcc3460b1cdf593a78d94f2442b27.1658823319.git.sean@starlabs.systems>
Sean:
Can you give BGRT spec link? I want to check the spec description.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sean Rhodes
> 发送时间: 2022年7月26日 16:15
> 收件人: devel@edk2.groups.io
> 抄送: Sean Rhodes <sean@starlabs.systems>; Zhichao Gao
> <zhichao.gao@intel.com>; Ray Ni <ray.ni@intel.com>; Jian J Wang
> <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
> follow BGRT specification
>
> Add an option to position the logo 38.2% from the top of the screen,
> which follows the BGRT specification.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
> EdkiiPlatformLogoDisplayAttributeCenterBottom,
>
> EdkiiPlatformLogoDisplayAttributeLeftBottom,
>
> EdkiiPlatformLogoDisplayAttributeCenterLeft,
>
> - EdkiiPlatformLogoDisplayAttributeCenter
>
> + EdkiiPlatformLogoDisplayAttributeCenter,
>
> + EdkiiPlatformLogoDisplayAttributeBGRTSpecification
>
> } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
>
>
>
> /**
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e..ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -169,7 +169,6 @@ BootLogoEnableLogo (
> DestX = SizeOfX - Image.Width;
>
> DestY = 0;
>
> break;
>
> -
>
> case EdkiiPlatformLogoDisplayAttributeCenterLeft:
>
> DestX = 0;
>
> DestY = (SizeOfY - Image.Height) / 2;
>
> @@ -182,7 +181,6 @@ BootLogoEnableLogo (
> DestX = SizeOfX - Image.Width;
>
> DestY = (SizeOfY - Image.Height) / 2;
>
> break;
>
> -
>
> case EdkiiPlatformLogoDisplayAttributeLeftBottom:
>
> DestX = 0;
>
> DestY = SizeOfY - Image.Height;
>
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
> DestX = SizeOfX - Image.Width;
>
> DestY = SizeOfY - Image.Height;
>
> break;
>
> -
>
> + case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
>
> + DestX = (SizeOfX - Image.Width) / 2;
>
> + DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
>
> + break;
>
> default:
>
> ASSERT (FALSE);
>
> continue;
>
> --
> 2.34.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842
> Mute This Topic: https://groups.io/mt/92623125/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2022-08-05 6:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 8:15 [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification Sean Rhodes
2022-07-26 8:15 ` [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Sean Rhodes
2022-08-05 5:58 ` 回复: " gaoliming
2022-07-26 8:15 ` [PATCH 3/3] UefiPayloadPkg: Hook up FOLLOW_BGRT_SPEC macro Sean Rhodes
2022-08-04 10:01 ` [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification Sean Rhodes
2022-08-05 5:59 ` gaoliming [this message]
2022-08-05 6:55 ` Sean Rhodes
2022-08-05 7:04 ` Pedro Falcato
2022-08-12 4:54 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox