回复: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

["gaoliming" <gaoliming@byosoft.com.cn>]

Konstantin: 
  The changes for VolInfo tool is good to me . Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:15
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.feng@intel.com; gaoliming@byosoft.com.cn;
> yuwei.chen@intel.com; Konstantin Aladyshev <aladyshev22@gmail.com>
> 主题: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix
> EFI_SECTION_GUID_DEFINED parsing
> 
> Currently 'PutFileImage' function is called with arguments that are
> not advanced on each section parsing. This would lead to an error if
> EFI_SECTION_GUID_DEFINED is not the first in a file.
> The same mistake is present in the parsing of CRC32 guided section
> case.
> Use correct arguments to fix the issue.
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  BaseTools/Source/C/VolInfo/VolInfo.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
> b/BaseTools/Source/C/VolInfo/VolInfo.c
> index 135924e028..b5760d185e 100644
> --- a/BaseTools/Source/C/VolInfo/VolInfo.c
> +++ b/BaseTools/Source/C/VolInfo/VolInfo.c
> @@ -2012,8 +2012,8 @@ Returns:
>          Status =
> 
>            PutFileImage (
> 
>              ToolInputFile,
> 
> -            (CHAR8*) SectionBuffer + DataOffset,
> 
> -            BufferLength - DataOffset
> 
> +            (CHAR8*)Ptr + DataOffset,
> 
> +            SectionLength - DataOffset
> 
>              );
> 
> 
> 
>          system (SystemCommand);
> 
> @@ -2058,8 +2058,8 @@ Returns:
>          //
> 
>          printf ("/------------ Encapsulation section start
> -----------------\\\n");
> 
>          Status = ParseSection (
> 
> -                  SectionBuffer + DataOffset,
> 
> -                  BufferLength - DataOffset
> 
> +                  Ptr + DataOffset,
> 
> +                  SectionLength - DataOffset
> 
>                    );
> 
>          if (EFI_ERROR (Status)) {
> 
>            Error (NULL, 0, 0003, "parse of CRC32 GUIDED section failed",
> NULL);
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#92968): https://edk2.groups.io/g/devel/message/92968
> Mute This Topic: https://groups.io/mt/93345656/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>