From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.20482.1661910190331715838 for ; Tue, 30 Aug 2022 18:43:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=AHimW6CF; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 23A20CD1F637 for ; Wed, 31 Aug 2022 09:43:08 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1661910188; bh=WuDNiq8MlrutxDM2YVHIEjRFd/E7vYo0AOELnLEP8OM=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=AHimW6CFadG+mWw1IzVIQGYnHMv3nS72doYyGvDn8fSrO/naCzkRWrBJqrfeOkGe4 clDtsMlmterXQU/mY5Fb2nX/qoCu5c9OgI/cXBWlKJYRcdlyOlAIuV4OTFq/sxq9ZQ Vwz2raKwMPV85nqNLSPrvYfCqf1qlhl+1rcO13fI= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 2092BCD1F77B for ; Wed, 31 Aug 2022 09:43:08 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id DEB86CD1F6C7 for ; Wed, 31 Aug 2022 09:43:07 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 7ECFDCD1F7B2 for ; Wed, 31 Aug 2022 09:43:05 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 31 Aug 2022 09:43:03 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: , References: <20220830101445.18110-1-aladyshev22@gmail.com> In-Reply-To: <20220830101445.18110-1-aladyshev22@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvNl0gQmFzZVRvb2xzL1ZvbEluZm86IEZpeCBFRklfU0VDVElPTl9HVUlEX0RFRklORUQgcGFyc2luZw==?= Date: Wed, 31 Aug 2022 09:43:04 +0800 Message-ID: <032001d8bcdb$0379c000$0a6d4000$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHf+CdSH0LadR4kzkTaUnpF39v2rK25xXfQ Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Konstantin:=20 The changes for VolInfo tool is good to me . Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io = =B4=FA=B1=ED Konstantin > Aladyshev > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA8=D4=C230=C8=D5 18:15 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: bob.c.feng@intel.com; gaoliming@byosoft.com.cn; > yuwei.chen@intel.com; Konstantin Aladyshev > =D6=F7=CC=E2: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix > EFI_SECTION_GUID_DEFINED parsing >=20 > Currently 'PutFileImage' function is called with arguments that are > not advanced on each section parsing. This would lead to an error if > EFI_SECTION_GUID_DEFINED is not the first in a file. > The same mistake is present in the parsing of CRC32 guided section > case. > Use correct arguments to fix the issue. >=20 > Signed-off-by: Konstantin Aladyshev > --- > BaseTools/Source/C/VolInfo/VolInfo.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c > b/BaseTools/Source/C/VolInfo/VolInfo.c > index 135924e028..b5760d185e 100644 > --- a/BaseTools/Source/C/VolInfo/VolInfo.c > +++ b/BaseTools/Source/C/VolInfo/VolInfo.c > @@ -2012,8 +2012,8 @@ Returns: > Status =3D >=20 > PutFileImage ( >=20 > ToolInputFile, >=20 > - (CHAR8*) SectionBuffer + DataOffset, >=20 > - BufferLength - DataOffset >=20 > + (CHAR8*)Ptr + DataOffset, >=20 > + SectionLength - DataOffset >=20 > ); >=20 >=20 >=20 > system (SystemCommand); >=20 > @@ -2058,8 +2058,8 @@ Returns: > // >=20 > printf ("/------------ Encapsulation section start > -----------------\\\n"); >=20 > Status =3D ParseSection ( >=20 > - SectionBuffer + DataOffset, >=20 > - BufferLength - DataOffset >=20 > + Ptr + DataOffset, >=20 > + SectionLength - DataOffset >=20 > ); >=20 > if (EFI_ERROR (Status)) { >=20 > Error (NULL, 0, 0003, "parse of CRC32 GUIDED section = failed", > NULL); >=20 > -- > 2.25.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#92968): = https://edk2.groups.io/g/devel/message/92968 > Mute This Topic: https://groups.io/mt/93345656/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20