From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6EFBC9400FD for ; Wed, 15 May 2024 00:49:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=u/ze01KZWCJuJ/TitE1KOTtT8+1oQUWaUG1enNaDgCg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1715734171; v=1; b=i4BTFblqhh4NFgMKC6cdXV8MGI4zBmZaxXIdU6M2pR4Nx30nepo6AZ9QLXti4Un5/lFkZTsS diB0SXwwVFOt7+rnsiUCt8tCZXn7hD1L+YE24L1FL9CIq8Q9E6WnsYKIa2cJrl/7vr1gHUR8amK lXUgxYbnaXgocPemYS8gzeJzVvnfyYfkHWTXY5mcDjRomAzHEPkRq+D4Uf5lL43cKHrQE92jI03 9YdeoGKu0kIeyPlZLFvj3slZLV0PoIxcmIwVuu+kkifSiZ72/cktg+/2R/FCrinfMi/An7XSfF4 5sqn2R7yWi+uF+n8cIStanXkGHkJ3bOAHjcJ/jC0fY6FQ== X-Received: by 127.0.0.2 with SMTP id mfyHYY7687511xGhSzXrLon1; Tue, 14 May 2024 17:49:31 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.3619.1715734169260297800 for ; Tue, 14 May 2024 17:49:30 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 581F2DDA7C4 for ; Wed, 15 May 2024 08:49:27 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 533B4DDA798 for ; Wed, 15 May 2024 08:49:27 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 81754DDA7E8 for ; Wed, 15 May 2024 08:49:24 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 15 May 2024 08:49:13 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Kinney, Michael D'" , , "'Andrew Fish'" , "'Leif Lindholm'" Cc: "'Ard Biesheuvel'" , , , "'Mathews, John'" , "'Hou, Wenxing'" , "'Li, Yi1'" , "'Yao, Jiewen'" References: <17CD1075E73EEFD7.30273@groups.io> <002501daa2ee$c4445660$4ccd0320$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gU29mdCBGZWF0dXJlIEZyZWV6ZSBzdGFydHMgbm93IGZvciBlZGsyLXN0YWJsZTIwMjQwNQ==?= Date: Wed, 15 May 2024 08:49:15 +0800 Message-ID: <033201daa661$b5fbd670$21f38350$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKfbKTbXoEYRIOo6T31ZtZb+qHX+wLixre/AjTZjFWv5SaWcA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 14 May 2024 17:49:30 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cHuW0HsoBUkpGan38QSxpH2Hx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0333_01DAA6A4.C4224AC0" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=i4BTFblq; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io ------=_NextPart_000_0333_01DAA6A4.C4224AC0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mike: Thanks for your comments. I update the status below.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D = =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8815=E6=97=A5 0:= 35 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@ed= k2.groups.io; 'Andrew Fish' ; 'Leif Lindholm' =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; sam.kaynor@arm.com;= dougflick@microsoft.com; Mathews, John ; Hou, Wenx= ing ; Li, Yi1 ; Yao, Jiewen ; Kinney, Michael D =E4=B8=BB=E9=A2=98: RE: [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405 =20 Hi Liming, =20 My responses below in [Mike]. =20 Mike =20 =20 From: gaoliming = >=20 Sent: Friday, May 10, 2024 8:29 AM To: devel@edk2.groups.io ; Kinney, Michael D = >; 'Andrew = Fish' >; 'Leif Lindholm' > Cc: 'Ard Biesheuvel' >; sam.kayno= r@arm.com ; dougflick@microsoft.com ; Mathews, John >; Hou, Wenxing > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now fo= r edk2-stable202405 =20 Stewards: Now, there are several patches to catch this table tag. Could you give th= e comments for them? =20 1. Adding support for verbose UEFI Table dumping to Dmem.c (https://ed= k2.groups.io/g/devel/message/118582) [Liming] This patch set has been reviewed before soft feature freeze. It pl= ans to catch this stable tag.=20 =20 [Mike] I see this PR: https://github.com/tianocore/edk2/pull/5653 that is n= ot passing CI and appears it will require additional code changes =20 [Mike] Reject for edk2-stable202405 =20 2. MdePkg/BaseLib: Fix AARCH64 compilation error (https://edk2.groups.io/g= /devel/message/118690) [Liming] This bug fix is reviewed in soft feature freeze phase. It plans to= catch this stable tag.=20 =20 [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5642 =20 3. MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount (https://edk2= .groups.io/g/devel/message/118745) [Liming] This security fix is reviewed in soft feature freeze phase. It pla= ns to catch this stable tag. =20 [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5659 =20 4. NetworkPkg: CVE-2023-45236 and CVE-2023-45237 (https://edk2.groups.io/g= /devel/message/118768) [Liming] This security fix is still under code review. It plans to catch th= is stable tag. =20 [Mike] Is the code review complete? Is there a link to the PR? [Liming] NetworkPkg reviewer will review this patch set this week.=20 =20 Thanks =20 5. Add more crypt APIs based on Mbedtls (https://edk2.groups.io/g/devel/me= ssage/118772) [Liming] This patch set passes code review in soft feature freeze phase. It= plans to catch this stable tag. =20 [Mike] This patch series uses =E2=80=98..=E2=80=99 in INF to access source = files in another component. This is not legal. I am surprised this was no= t caught in code review. =20 DEFINE OPENSSL_PATH =3D ../OpensslLib/openssl DEFINE BASE_CRYPT_PATH =3D ../BaseCryptLib =20 [Mike] I see a reference to some =E2=80=9Cplatform integration=E2=80=9D tes= ting. Given that this patch series implements a number of crypto service APIs and is a large number of new lines of code, it would be= good to know if all of the newly added APIs=20 were tested in a platform integration. A table of the added APIs and the pl= atform integration test status would be good to=20 know if there was any functional testing of each API. If there are APIs th= at are not covered by any platform integration=20 testing, then I would be concerned with such a large change with limited te= sting. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8=A1= =A8 gaoliming via groups.io =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=887=E6=97=A5 9:2= 5 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; announce@edk2.groups.io =20 =E6=8A=84=E9=80=81: 'Michael D Kinney' >; 'Andrew Fish' >; 'Leif Lindholm' > =E4=B8=BB=E9=A2=98: [edk2-devel] Soft Feature Freeze starts now for edk2-st= able202405 =20 Hi, all =20 We enter into Soft Feature Freeze phase now. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. =20 The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable ta= g, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag= , please add edk2-stable202405 key words in the patch title and BZ, so the community know this patch target and give the feedback. =20 To avoid the unnecessary changes to be merged in edk2 stable tag release, all edk2 maintainers' write access will be temporarily disabled until stabl= e tag is released on 05-24. That means edk2 maintainer can't set push label i= n pull request after soft feature freeze starts. =20 If the change wants to catch this stable tag 202405, please follow above rules, then send the merge request to gaoliming@byosoft.com.cn or=20 michael.d.kinney@intel.com . =20 We will help merge the code change in soft feature freeze and hard featur= e freeze phase.=20 =20 Below is edk2-stable202405 tag planning Proposed Schedule Date (00:00:00 UTC-8) Description =20 2024-02-23 Beginning of development 2024-05-06 Soft Feature Freeze 2024-05-10 Hard Feature Freeze 2024-05-24 Release =20 Thanks Liming =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118898): https://edk2.groups.io/g/devel/message/118898 Mute This Topic: https://groups.io/mt/106106358/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0333_01DAA6A4.C4224AC0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Mik= e:

=C2=A0 Than= ks for your comments. I update the status below.

 

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D <= ;michael.d.kinney@intel.com>
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:<= /b> 2024=E5=B9=B45=E6=9C=8815=E6=97=A5 0:35
=E6=94=B6= =E4=BB=B6=E4=BA=BA: gaolim= ing <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Andrew Fish' &= lt;afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>=E6=8A=84=E9=80=81: 'Ard Biesheuvel' <ardb@kernel.org>; sam.kaynor@arm.com; dougfli= ck@microsoft.com; Mathews, John <john.mathews@intel.com>; Hou, Wenxin= g <wenxing.hou@intel.com>; Li, Yi1 <yi1.li@intel.com>; Yao, Jie= wen <jiewen.yao@intel.com>; Kinney, Michael D <michael.d.kinney@in= tel.com>
=E4=B8=BB=E9=A2=98:<= span lang=3DEN-US> RE: [edk2-devel] Soft Feature Freeze starts now for edk2= -stable202405

 =

Hi Liming,

 

 

Mike

 

 

From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, May= 10, 2024 8:29 AM
To: dev= el@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <= quic_llindhol@quicinc.com&= gt;
Cc: 'Ard Biesheuvel' <a= rdb@kernel.org>; sam.kaynor@ar= m.com; dougflick@microsoft.c= om; Mathews, John <john.ma= thews@intel.com>; Hou, Wenxing <wenxing.hou@intel.com>
Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405<= o:p>

 

Stewards:

  Now, there are several patches to catch = this table tag. Could you give the comments for them?

=

 

1.   &nb= sp;  Adding support for verbose UEFI Table dumping t= o Dmem.c (https://edk2.groups.io/g/devel/mes= sage/118582)

[Liming] This patch set has been reviewed before soft fe= ature freeze. It plans to catch this stable tag. =

 

[Mike] I see this PR: https://github.com/tianoco= re/edk2/pull/5653 that is not passing CI and appears it will require ad= ditional code changes

 

[Mike] Reject for edk2-stable2024= 05

 

= 2.  = MdePkg/BaseLib: Fix AARCH64 compilation error (https://edk2.groups.io/g/devel/message/118690)

[Liming] This bug fix is reviewed= in soft feature freeze phase. It plans to catch this stable tag.

 

[Mike] Approved for edk2-stable202405=

[Liming] I add push label for https://github.com/tianocore/edk2/pull/5642

 

3.&nbs= p; MdeModulePkg: Potential UINT32 overflow in S3 ResumeCo= unt (https://edk2= .groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft feature fre= eze phase. It plans to catch this stable tag.

 

[Mike] Approved for edk2-stable202405

= [Liming] I add push label for https://github.com/tianocore/edk2/pull/56= 59

 

4.  NetworkPkg: CVE-2023-45236 and CVE-2023-= 45237 (https://ed= k2.groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It = plans to catch this stable tag.=

 

[Mike]= Is the code review complete?  Is there a link to the PR?

[Liming] NetworkPkg reviewer will review this patch set this week.

 

Thanks

 

5.  Add more crypt APIs based on Mbedtls (https://edk2.groups.= io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze ph= ase. It plans to catch this stable tag.

 

[Mike] This patch series uses =E2=80=98..=E2= =80=99 in INF to access source files in another component.  This is no= t legal.  I am surprised this was not caught in code review.

 

DEFINE OP= ENSSL_PATH           = ; =3D ../OpensslLib/openssl

DEFINE BASE_CRYPT_PATH =         =3D ../BaseCryptLib

 

[Mike] I see a reference to some =E2=80=9Cplatform integration= =E2=80=9D testing.  Given that this patch series implements a number o= f

crypto service APIs and is = a large number of new lines of code, it would be good to know if all of the= newly added APIs

were teste= d in a platform integration. A table of the added APIs and the platform int= egration test status would be good to

know if there was any functional testing of each API.  If th= ere are APIs that are not covered by any platform integration

testing, then I would be concerned with s= uch a large change with limited testing.

 

Thanks

Li= ming

=E5=8F=91=E4= =BB=B6=E4=BA=BA: devel@edk2= .groups.io <devel@edk2.group= s.io> =E4=BB=A3=E8=A1=A8 = gaoliming via grou= ps.io
=E5=8F=91=E9=80=81=E6= =97=B6=E9=97=B4: 2024=E5=B9= =B45=E6=9C=887=E6=97=A5= 9:25
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; = announce@edk2.groups.io
=E6=8A=84=E9=80=81: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Andrew Fi= sh' <afish@apple.com>; 'Leif L= indholm' <quic_llindhol@qui= cinc.com>
=E4=B8=BB=E9=A2=98:= [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405

 

Hi, all

 

  We enter into Soft Feature Freeze phase now. In= this phase,

the feature under review will = not be allowed to be pushed. The feature

pass= ed review can still be merged.

<= span lang=3DEN-US style=3D'font-family:Consolas;color:black'> 

  The patch review can continue without break i= n edk2 community. If the

patch is sent before= Soft Feature Freeze, and plans to catch this stable tag, the

patch contributor need reply to his patch and notify edk2 = community. If the

patch is sent after Soft Fe= ature Freeze, and plans to catch this stable tag,

please add edk2-stable202405 key words in the patch title and BZ, so t= he

community know this patch target and give = the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 stable = tag release,

all edk2 maintainers' write ac= cess will be temporarily disabled until stable

tag is released on 05-24. That means edk2 maintainer can't set push label= in

pull request after soft feature freeze st= arts.

 

  If the change wants to catch this stable tag 202405, please follow = above

rules, then send the merge request to= gaoliming@byosoft.com.cn o= r

michael.d.kinney@intel.com.

&nbs= p;

  We will help merge the code change in so= ft feature freeze and hard feature

freeze pha= se.

 

Bel= ow is edk2-stable202405 tag planning Proposed Schedule

Date (00:00:00 UTC-8) Description

 

2024-02-23 Beginning of development

2024-05-06 Soft Feature Freeze

2024-05-10 Hard Feature Freeze

2024-05-24 Release

 

Thanks

Liming

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118898) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_0333_01DAA6A4.C4224AC0--