From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 51DB0AC1A70 for ; Wed, 24 Jan 2024 19:36:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wtow60flyIiEbsUPOrZE3OGWft2kMNPQvVjaT/N1Uxw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706124990; v=1; b=LjxxS4Fnyj9VdupVZCuBPaxu47zbQfyvSSVeCEadnMS/5QcKnQw4K/tNECF6kXPyb1Q7FnOG 5sX2o3g3syOGCzQ1JDA5bs2jPoPZEDLxJ0cOycAkC7QIOWeCxPPht9+bthU8UU7MePf0YKmgnZ/ +TOC4VN9u5+GqJXRpsDvRx4c= X-Received: by 127.0.0.2 with SMTP id 6xhbYY7687511xmufuapVCrt; Wed, 24 Jan 2024 11:36:30 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.124]) by mx.groups.io with SMTP id smtpd.web11.32688.1706124989771043995 for ; Wed, 24 Jan 2024 11:36:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hq0111Po62uplBOA4oFsOQz6nJ8xem+hhAUW1yXShNnkUzf3+ri29nh6aRSEjg6Mco57Sj8uzLXjpVDGDvYug9Xm+YOpLlHX2nBfHFV+dzbAP88g4AQmdT0XCiHftvMxJP11GIBVQoMyKLmsxssytsHDLOOH/QYa61fKGQu5LaDYMxn+pAlg/IjcZGDOvak5qNVOW2n0ayTCEShK4Yg4Vm2JjGCKUSwzREB1u9CKgOG1W+ttXx1hsLL5qtp1KI8hS63+j3a5tQaGt1kp1SlNyfhQwM6BstkEZ4VkjrmMj4gE2WV8Mt8u7IzrNKYSjvCpCrmtOWC9j5kI+/fdzTR7hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AXT/9fBcLDmuCjGE2f0p6j/6efJvcyWJdPkY72jStLE=; b=anBAnFgF+LwrI/0GJIDrFqwhIoVbsCpRzpXIJ8IvePwVddC7ejdp6c2mJ791ObxNZKtXkHXb02s95x5TyhUTjWy4bgAPNmT0/cN3Kos/ulNxAwWhVkucNuBt3B0WVYW6GoyLwWwOQPGFv2LlejikCq11T7n1jNBIlR4SppUX4c3vV6k+c/ry7p1pufX1Jw1j+yhEQRLinNj/jdI1NQL+jl4qOa+10hh74jnGZ9TaEjzL93BJwIBZvVhnwLTC1+DEhsx1OXRiMspzX3LpRrAJ3hvmYeubPk8AGE3NIbsiPbcMH23jlS7LzeJIxtXjded2Y3P0nC732W9AL3dclz1EaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by LV2PR01MB7694.prod.exchangelabs.com (2603:10b6:408:175::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 19:36:24 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 19:36:24 +0000 Message-ID: <03340612-833b-4554-a676-dccfc0fd8032@os.amperecomputing.com> Date: Wed, 24 Jan 2024 12:36:19 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset To: Sami Mujawar Cc: "devel@edk2.groups.io" , nd , Leif Lindholm , Ard Biesheuvel References: <20240119154554.1052736-1-rebecca@os.amperecomputing.com> <20240119154554.1052736-2-rebecca@os.amperecomputing.com> <9CD858BD-6154-484B-B474-652DBB498F39@arm.com> From: "Rebecca Cran via groups.io" In-Reply-To: <9CD858BD-6154-484B-B474-652DBB498F39@arm.com> X-ClientProxiedBy: CH2PR18CA0040.namprd18.prod.outlook.com (2603:10b6:610:55::20) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|LV2PR01MB7694:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c13fa46-6ee8-494a-8fd4-08dc1d13bff5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Wq5W/mblaTEY4EHQvNAnLxpRRFb2AC8mKWLdTtIW1hrkNgDdCfxzlCPS8nwOrQdZnwobvqFfmy6GHTqK47dEye9OE3CVTRuuyMwT6MmyUEXDwoX/qlP12/Vl4XvmdLoN7NGqeEkUjpW0YXPZFwfrqdJVBtSwgieNKgFdpJr4cKm6Gp0cy5FL2LQUANrmIWrvhG4Ko/dI4W25vuISAneBnO7nh2bzXvbQjipGgU5UhXguINy7/xvpM6kaDb9wD0YC1CYFZJxrzzguwxIAp36vqJ+C6jwDWP9H1vvgvm0MUfCZMOJAhp6M5X8i8uDhcVKeOC/6KKvdVfCfiyMWn+hLh2Dj/6HnTuDKusH05vMY0pgUOrhWIK9tHjLnNX98HyTJNk8fRYiuYBQ47PqkDc9oaI/CeYQAjDW94kYUzgvaRaRx/WVqSQMlFbJaryrsTq9Keh791bo6DQtovqid5qDBGyhNj/2BnwMtgw4GuYHuAF1PDSNdPvbrHCcZOf51QZKhi0Ke6LpEav2fs35y+VLoBHeVPW6Ifc4Qa8w5eS/M04m9HlOEv+osszZ/xfo3glZmE1lTqW3mW3t3oFKFUK1JG0TTZhVGnyfcfKH/56KR2Wj1P9QNc+7gb8TDDIl645H7 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWZqSlNVcnZQb0kwN0pYd3BOaGl2L1dSdjhYYW54QldlcDlUNzdOTW5CVkhK?= =?utf-8?B?K2NYOUdVU3g0SDFycXhvb2JKM3NTR1dUeHhiMWI0eE9MUEJDRkdRcE9PQlp2?= =?utf-8?B?bTVsdWlYY3J5NEZSVlhhK0hKQjZqNytnRXlZK1Z2Q2phVWVQQ1BIRDc5amhx?= =?utf-8?B?aVJuZ2I0bWVjN3FPNjc0V1lDQ3JFV25TMEpSZWNYM2tORnRodjcvRlE4YVJH?= =?utf-8?B?dzFGUEFPTXR0OVdGNDIwMnhQMEVqOE9FcDlWbzJGTVJzdDRiQWVGT01Udjlp?= =?utf-8?B?QnBvVzlCdnNYVVduQnZad3FjVmY0RXJFRW9QS01KUVVxU1FydDBLczNnZk1S?= =?utf-8?B?SVB3VGNkSVZDYlFaTW4xN2NRblJhcFdtQ3dTMmk3ZUpvRFJndnp5TzVqUkZo?= =?utf-8?B?QnZCMFJ1ajIreHFVR1NYYkhGUjJjL21WcXJZcmtiKzRrY1doSFcxbmVseU93?= =?utf-8?B?eHlkRmdWbEhuYStzdTJMeUpzdGd6ZFNZZkY5V045Yy8zdzRxYko4RlZ0Q2hh?= =?utf-8?B?bmdmajI1OUNMeWkxL1FKdFFpR3Y0aUlKUEtGL1dyVjMvd3JmWm5aUExjR29l?= =?utf-8?B?M0FJMTVjWm9PdEpETGlKMTRwQXl3MWdwck10cEwwcEIrZUxtSXpKdkZqQlV4?= =?utf-8?B?aS9RT1h3MFlkQlZIRG5YWTN6WFRlamFkNjhJY2FtQ2h1bVFpT1lyS0FJRFha?= =?utf-8?B?TkxRbUNLK1ZySkw3S0xoeVFVQWdHZWNUT3dGdUhUUVp2SXhHRURPc1I1L01Q?= =?utf-8?B?N2JpVkxZMkhDZ3NXb21CYlp6U3N2bzFtMVdCVS92b1YvbzlvUGVFeFMzTC8y?= =?utf-8?B?eWh5NUUrbGJBTzBjNVkzNUkwbktwT0NiRDRHZW44cU1pTEpoMzMxZkxoaERR?= =?utf-8?B?R251RDJyUENBTmpuOE5mUjFuMEJISE1BY3Y1TE5YWFE5TlhFcWZDZzVJaDdh?= =?utf-8?B?VjFyR3RHczNsUEtTTys5WjVDdWp2TkYxTjcxMG5Bd1BURnF1Nko1ZWU1aWJ6?= =?utf-8?B?ZFo3dGsvSDJqZlhTbWFKd0FueG1Va3Y5ZkpvYVN6WVFIejgxK1hWYnU1Si9J?= =?utf-8?B?MDFvUjhJaDk0Qzk5aDhwM0NOZDFwN3E4QzIraERsRUg5VjVZQ3ZuV09oa24r?= =?utf-8?B?QXozQ3ZrTk94ZE9QZklWQWlONTMrdzJHejNTOC92N0JjUlM0dEtDdWlONHR1?= =?utf-8?B?QnVuZ01BZFFtNUNQNlNEZG1ZblBCMmsyNEJkbXljdldsRk9iWWV5MnZXUWpm?= =?utf-8?B?dHk0ekk3Yi90TzhzSVJoeDRkOXR6RWVqU01PMURQWmpVWGw1c1NUL0w1WFZi?= =?utf-8?B?SE1MUnJlVU9MV1FmQkRyQ2E0dHZYQ2VNUVVpZm5sNElpazY1S2d4WlVZendV?= =?utf-8?B?ck84UFFzSERvZlVOY0E1OXQzb09pdE0rM0xvaitIRml4dDcvZVltN3Q1b0o3?= =?utf-8?B?VVhncWpxSUlubW95L05QL3EvUU9yYis0MFBheVlDWVZBWmdYdjFrODhQVmVM?= =?utf-8?B?aDVWeHJpbmJEeURCZkxoUExsRWNOVjRZUkdTZ2VpRkswSkxySnNGZUVZbHZY?= =?utf-8?B?alVnRTZLb0owQW1uUU05NjErZUNBTGh1MGFZdk1kNHJvU1lueWpkQ3dQOW0v?= =?utf-8?B?RjhMdW5kWC9IMzFTTnlUOUxTSTBxQnMyalpBOUhPdFI4Sm1rODV2Q3RtdnRz?= =?utf-8?B?Zzk1MEF3ZzZ5UmpDa1A0ZEZNMlN0UnVvMWF3b1JFSmo3ejM5YXljcVRMRm9i?= =?utf-8?B?cFpZeTFScCt2dldaR3JyOWZhaHloWXZrMGJSbUtrZXVDRDBmS1JLc1BJL0hl?= =?utf-8?B?bjRGaWpQemZnS2N2MVdaZWplRVF1ajZQczlhK01xejM0cmJrQnZhaEtPYnEy?= =?utf-8?B?VjEyb1BnVUU1N0x1SElCM2pOTWdFMUhSYW5GY2JWUkF4UDBCZ0FRTXVXUnV6?= =?utf-8?B?VGN6eUptTTVYdVZFSmR1aUN2TVZvV2xXZU1EMGRZK3dERFJMWnMrRUg1Nkds?= =?utf-8?B?R1l6ejlyaU95eUFJOG52Zk1MSFhESjVCTHNxN0hxS1ZSZ25BUnd5MGE1Z1RP?= =?utf-8?B?dGt0K21qaWhvdDQ3eVhwK3JxVlpDWkpYdzhHd3h1MFJ6Y2QwSlhRa3o1QzFQ?= =?utf-8?B?ZnlpQXZTNGVCWnBDT1l6d1NURDdYRVJ5ZFpqeGE0eWgrQ2NIMnozZzZ5VnNE?= =?utf-8?Q?QdSSAfVsh/Qkd4Kz0Ia3EZU=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c13fa46-6ee8-494a-8fd4-08dc1d13bff5 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 19:36:24.3841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4OHJd0EOQ7FansPLdNTkd2Bp2+tGhibnX5NzcAiYN/zoUwPw1+QGrx5kPS8t0bJCmL2YcFQJMGREM+xgtmS93ihYkCweA5ZG5POh8uCsNbXXp9yWVTLVq3D+5bfv5oiy X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7694 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wgE81XhdAr9LmixKyiK2BGHjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LjxxS4Fn; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/23/2024 7:10 AM, Sami Mujawar wrote: > @@ -310,6 +318,7 @@ GenericWatchdogEntry ( > { > EFI_STATUS Status; > EFI_HANDLE Handle; > + UINT32 WatchdogIId; > [SAMI] Minor, the above variable name should be WatchdogIid to comply wit= h the coding standard. I was wondering about the naming, since it's the "Watchdog Interface=20 ID". Since the second "I" is for another word, should it still be=20 lower-case? --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114351): https://edk2.groups.io/g/devel/message/114351 Mute This Topic: https://groups.io/mt/103832319/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-