public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds
Date: Wed, 20 Apr 2022 13:52:59 -0400	[thread overview]
Message-ID: <033d7eb2-dc53-2a0e-cf78-b93151f59d25@linux.microsoft.com> (raw)
In-Reply-To: <16E777609E777E5C.10736@groups.io>

Here's a PR with this change that has an additional temp commit to 
trigger builds:

https://github.com/tianocore/edk2/pull/2806

Ignore the patch check failure, that is related to the temp commit.

Regards,
Michael

On 4/19/2022 9:43 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> The NOOPT build target is used for host-based unit tests. This
> change adds the NOOPT target for all packages to ensure that tests
> are executed if present.
> 
> If the host-based DSC is not specified in the packages CI YAML file,
> the host-based compiler plugin will be reported as a skipped test.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 69e4c50afdbb..0e4ad019bf03 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -35,10 +35,10 @@ jobs:
>           Build.Targets: 'RELEASE,NO-TARGET'
>         TARGET_NETWORK:
>           Build.Pkgs: 'NetworkPkg,RedfishPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_OTHER:
>           Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_FMP_FAT_TEST:
>           Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> @@ -47,15 +47,15 @@ jobs:
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_SECURITY:
>           Build.Pkgs: 'SecurityPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_UEFIPAYLOAD:
>           Build.Pkgs: 'UefiPayloadPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_PLATFORMS:
>           # For Platforms only check code. Leave it to Platform CI
>           # to build them.
>           Build.Pkgs: 'ArmVirtPkg,EmulatorPkg,OvmfPkg'
> -        Build.Targets: 'NO-TARGET'
> +        Build.Targets: 'NO-TARGET,NOOPT'
>   
>     workspace:
>       clean: all

       reply	other threads:[~2022-04-20 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16E777609E777E5C.10736@groups.io>
2022-04-20 17:52 ` Michael Kubacki [this message]
2022-04-20  1:43 [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds Michael Kubacki
2022-04-21 21:07 ` [edk2-devel] " Sean
2022-04-22 14:33   ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=033d7eb2-dc53-2a0e-cf78-b93151f59d25@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox