From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.44771.1683187622042311361 for ; Thu, 04 May 2023 01:07:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=jnvOMOcp; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 1479CDDA7D1 for ; Thu, 4 May 2023 16:06:35 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683187595; bh=Du6GQ3KuYmEouM/j5d/ydAxifLsybLiLUSzhOKKAL+A=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=jnvOMOcp72c4lu6BEft3SzpWp6aIdHdzpkWG/NYEq+LC/ZRq8n6CawC6cBdOCMub5 Jcd2tjmCgBoUvZrMnqgQ4u6ZwrkD4APOCBGHZApySpTSZSRxllk6KhJNQ1pNp5alns VcZOoAu9lTS69cJOvHQY/tG/Zr77BRuOC6EBFC+c= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 0FB04DDA7CD for ; Thu, 4 May 2023 16:06:35 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id B81B9DDA7A9 for ; Thu, 4 May 2023 16:06:34 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 53745DDA7A6 for ; Thu, 4 May 2023 16:06:31 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 04 May 2023 16:06:19 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: , , , References: <20230503112415.2073176-1-tinhnguyen@os.amperecomputing.com> <20230503112415.2073176-4-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230503112415.2073176-4-tinhnguyen@os.amperecomputing.com> Subject: =?UTF-8?B?5Zue5aSNOiBbICoqIFNQQU1NQUlMICoqIF1bZWRrMi1kZXZlbF0gW1BBVENIIHYzIDMvM10gTWRlUGtnL0luZHVzdHJ5U3RhbmRhcmQ6IEFkZCBJbnRlcmZhY2UgQ2FwYWJpbGl0aWVzIGRlZmluaXRpb25z?= Date: Thu, 4 May 2023 16:06:22 +0800 Message-ID: <034401d97e5f$50e8d790$f2ba86b0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHaeuW9vzyh5P61Emy+npDyZqZAFgKbNfwArzLu0jA= Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Tinh: For the patch subject, I suggest to add IPMI key word to specify this cha= nge is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Capabi= lities definitions Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Tinh Nguyen > via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=883=E6=97=A5 1= 9:24 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: patches@amperecomputing.com; michael.d.kinney@intel.c= om; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com; > Tinh Nguyen > =E4=B8=BB=E9=A2=98: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] > MdePkg/IndustryStandard: Add Interface Capabilities definitions >=20 > This adds more definitions for the IPMI Get System Interface > Capabilities command. >=20 > Signed-off-by: Tinh Nguyen > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Abner Chang > Reviewed-by: Abner Chang > --- > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 > ++++++++++++++++++++ > 1 file changed, 46 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > index a5835ba08c00..b6bc91f46c2d 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > @@ -13,6 +13,7 @@ >=20 > Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
> Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -1046,6 +1047,51 @@ typedef struct { > // Constants and Structure definitions for "Get System Interface > Capabilities" command to follow here > // >=20 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF 0x0 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS 0x1 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC 0x2 > + > +typedef union { > + struct { > + UINT8 InterfaceType : 4; > + UINT8 Reserved : 4; > + } Bits; > + UINT8 Uint8; > +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST; > + > +typedef union { > + struct { > + UINT8 Version : 3; > + UINT8 PecSupport : 1; > + UINT8 Reserved : 2; > + UINT8 TransactionSupport : 2; > + } Bits; > + UINT8 Uint8; > +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES; > + > +typedef union { > + struct { > + UINT8 SystemInterfaceVersion : 3; > + UINT8 Reserved : 5; > + } Bits; > + UINT8 Uint8; > +} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES; > + > +typedef struct { > + UINT8 CompletionCode; > + UINT8 Reserved; > + IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES InterfaceCap; > + UINT8 InputMsgSize; > + UINT8 OutputMsgSize; > +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE; > + > +typedef struct { > + UINT8 > CompletionCode; > + UINT8 Reserved; > + IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES InterfaceCap; > + UINT8 > InputMaxMsgSize; > +} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE; > + > // > // Definitions for Get System Interface Capabilities command SSIF > transaction support > // > -- > 2.40.0 >=20 >=20 >=20 >=20 >=20