From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: "'Oliver Smith-Denny'" <osde@linux.microsoft.com>,
<devel@edk2.groups.io>
Cc: "'Leif Lindholm'" <quic_llindhol@quicinc.com>,
"'Ard Biesheuvel'" <ardb+tianocore@kernel.org>,
"'Sami Mujawar'" <sami.mujawar@arm.com>
Subject: 回复: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
Date: Thu, 14 Mar 2024 22:52:36 +0800 [thread overview]
Message-ID: <034701da761f$41052190$c30f64b0$@byosoft.com.cn> (raw)
In-Reply-To: <20240309190559.28677-1-osde@linux.microsoft.com>
For this patch set, I have no comments. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Oliver Smith-Denny <osde@linux.microsoft.com>
> 发送时间: 2024年3月10日 3:06
> 收件人: devel@edk2.groups.io
> 抄送: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>;
> Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
>
> This patch series is the third version of
> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations.
> The subject line has been updated because this went from a one commit
> patch with no cover letter to a multi-commit patch.
>
> The commit messages cover the vast amount of detail here, but this
> patchset fixes three issues:
> - a UEFI spec violation for which memory types require runtime page
> allocation granularity alignment
> - An incompatibility of the heap guard system to guard these regions
> that require runtime page allocation granularities greater than
> the EFI_PAGE_SIZE.
> - A CodeQL error that fails CI when updating the Page.c code
>
> v3:
> - edit comments for readability
>
> v2:
> - Add commit to fix UEFI spec violation
> - Add commit to fix newly flagged CodeQL error
> - Update guard commit message, comments, and static assert to use
> the correct types
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Oliver Smith-Denny (3):
> MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
> MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
> MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types
>
> MdeModulePkg/MdeModulePkg.dec | 10 +++++++++
> MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14
> +++++++++++++
> MdeModulePkg/Core/Dxe/Mem/Page.c | 22
> +++++++++++++++++---
> MdeModulePkg/Core/Dxe/Mem/Pool.c | 15
> +++++++++++--
> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++--
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +-
> 6 files changed, 59 insertions(+), 8 deletions(-)
>
> --
> 2.40.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116762): https://edk2.groups.io/g/devel/message/116762
Mute This Topic: https://groups.io/mt/104927832/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-14 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 19:06 [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues Oliver Smith-Denny
2024-03-09 19:06 ` [edk2-devel][PATCH v3 1/3] MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages Oliver Smith-Denny
2024-03-09 19:06 ` [edk2-devel][PATCH v3 2/3] MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type Oliver Smith-Denny
2024-03-09 19:06 ` [edk2-devel][PATCH v3 3/3] MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types Oliver Smith-Denny
2024-03-11 14:01 ` Ard Biesheuvel
2024-03-14 14:52 ` gaoliming via groups.io [this message]
2024-03-14 16:31 ` [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034701da761f$41052190$c30f64b0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox