From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mx.groups.io with SMTP id smtpd.web12.1164.1606332967056966901 for ; Wed, 25 Nov 2020 11:36:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=NQKcgUDe; spf=pass (domain: nuviainc.com, ip: 209.85.210.180, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f180.google.com with SMTP id q10so3323704pfn.0 for ; Wed, 25 Nov 2020 11:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=iL1bi/7JUyh1RI+6E+86RpsQYcBiHkvAoC/tOxPLYbY=; b=NQKcgUDe5BEPjUoTcFCp5+i1FHdCmbg3TLt5C9gJeUyfQyzfGl+sK4+N/N+L0EUQHf xuvm5Ql0hi4pP4jOitmBWMfIHHgP4glBPmSeBGobySeR0JZjnvipdNQDVDM6PWq5+KWc C8rbiub6pqXVy8nzrGZRubMALbGutwcPe+hQd3FsqylDi3sYqU4I0DmGtnHHDE6ueeuC eOEXAmJIU4AcN1o2TrKAeuTu2QdOVFlehWwhkSOx66U6nDqdO67bPe3dLNpUn06AJJLh 4rqf3Pl8FXD3ZyTjCwucsICU/ZJXNzRErFM0GjlJAynW3d74SAjULt6uCG+5yWuO3OEb b3gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=iL1bi/7JUyh1RI+6E+86RpsQYcBiHkvAoC/tOxPLYbY=; b=AJiIB4X1bT38jMoDXSyZvn95camCmC1pIJVsiqIOkkMqxQamaFBMxYzhMcpucY94Vy 76wFtBwdU/UtCEyB1MWrU3LIy6JE2ih/aY+EpMVKOst5P7Eg3jTc6/NudGjONx2FFJma L8/2Lr+h70Mw9SUF27K4FFpVZf2VGfKIkgouC+lEOwAPH/jwHMfvGZXHvOvooHJQGCXE wC8dcyFHzVKnI1u4ptyMDTQnzPEfOER9X/zQOF4T+or3BunRJTiIFAB3/HvB0vv4WHUW Ccg9+JSgozDRzxV9XejRGcg5exs3d4Mp+7XapPFs4ptrOkmtTyMHsQwW4zP2O7CG+mOj JOAQ== X-Gm-Message-State: AOAM532pTYN41z9tDf4ndZ78euyWRP2sSors5XsYTk84d2Q1IW0ECly+ z4FVZS6OsxYzSZoaE0NAilGlfg== X-Google-Smtp-Source: ABdhPJw7ckpK1K44NJMT+nWTRaVcPlW91iu24pRZhkMprczRnwhBdWdUWASgWU7gqEd8ErqcDCq29Q== X-Received: by 2002:a65:5948:: with SMTP id g8mr4253475pgu.51.1606332966634; Wed, 25 Nov 2020 11:36:06 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id gb4sm3736478pjb.30.2020.11.25.11.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Nov 2020 11:36:05 -0800 (PST) Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Bret Barkelew , Liming Gao , "Justen, Jordan L" , Laszlo Ersek , Ard Biesheuvel References: <20201125050758.1507-1-michael.d.kinney@intel.com> <20201125050758.1507-4-michael.d.kinney@intel.com> <422b3c4f-0918-89f3-6257-ca28ac1c2dd1@nuviainc.com> From: "Rebecca Cran" Message-ID: <034b8d30-d926-eecb-905c-86fb5c7bf3f3@nuviainc.com> Date: Wed, 25 Nov 2020 12:35:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------65A8B2B1C20ECF5F965FA2F1" Content-Language: en-US --------------65A8B2B1C20ECF5F965FA2F1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mike, That does appear to be the current general approach, but I'd suggest changing it. Because in the last week before release we shouldn't be chasing new versions of unrelated software, in my opinion. Fortunately the switch to Ubuntu 20.04 hasn't happened yet, and is due to be rolled out beginning November 30th (https://github.com/actions/virtual-environments/issues/1816). The CI pipeline has a set of warnings: "##[warning]Ubuntu-latest pipelines will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816" -- Rebecca Cran On 11/25/20 9:20 AM, Michael D Kinney wrote: > Hi Rebecca, > > I think the general approach is to verify the latest version of everything > including the CI infrastructure components. > > If a failure is detected due to a new component, then we can temporarily > lock in a previous stable version until the issues with the new component > are resolved. > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Rebecca Cran >> Sent: Wednesday, November 25, 2020 6:58 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> Cc: Sean Brogan ; Bret Barkelew ; Liming Gao >> ; Justen, Jordan L ; Laszlo Ersek ; Ard Biesheuvel >> >> Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU >> >> Related, should we use a known version of Ubuntu in testing? >> >> Currently, there are several lines with 'ubuntu-latest' - e.g.: >> >> .azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest' >> .azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest' >> >> OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image: >> 'ubuntu-latest' >> >> >> I'm not familiar with how Azure works, but could this cause problems >> when they update their Ubuntu latest image to 21.04 etc. and things >> change under us? >> >> >> -- >> Rebecca Cran >> >> >> On 11/24/20 10:07 PM, Michael D Kinney wrote: >>> Install the 2020.08.14 release of QEMU for Windows. >>> >>> The QEMU release from 2020.11.20 is installed into the incorrect >>> directory and is causing EDK II CI failures in the run to shell >>> step. >>> >>> Cc: Sean Brogan >>> Cc: Bret Barkelew >>> Cc: Liming Gao >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Signed-off-by: Michael D Kinney >>> --- >>> OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows- >> VS2019.yml >>> index 02ed233fdb60..dd19fff50066 100644 >>> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml >>> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml >>> @@ -132,7 +132,7 @@ jobs: >>> build_flags: $(Build.Flags) >>> run_flags: $(Run.Flags) >>> extra_install_step: >>> - - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu" >>> + - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program >> Files\qemu" >>> displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI >>> condition: and(gt(variables.pkg_count, 0), succeeded()) >>> >> >> >> > > > > > --------------65A8B2B1C20ECF5F965FA2F1 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Mike,


That does appear to be the current general approach, but I'd suggest changing it.

Because in the last week before release we shouldn't be chasing new versions of unrelated software, in my opinion.


Fortunately the switch to Ubuntu 20.04 hasn't happened yet, and is due to be rolled out beginning November 30th (https://github.com/actions/virtual-environments/issues/1816). The CI pipeline has a set of warnings: "##[warning]Ubuntu-latest pipelines will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816"


--
Rebecca Cran


On 11/25/20 9:20 AM, Michael D Kinney wrote:

Hi Rebecca,

I think the general approach is to verify the latest version of everything
including the CI infrastructure components.

If a failure is detected due to a new component, then we can temporarily 
lock in a previous stable version until the issues with the new component
are resolved.

Mike


-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Wednesday, November 25, 2020 6:58 AM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
<ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Related, should we use a known version of Ubuntu in testing?

Currently, there are several lines with 'ubuntu-latest' - e.g.:

.azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest'
.azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest'

OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image:
'ubuntu-latest'


I'm not familiar with how Azure works, but could this cause problems
when they update their Ubuntu latest image to 21.04 etc. and things
change under us?


--
Rebecca Cran


On 11/24/20 10:07 PM, Michael D Kinney wrote:

Install the 2020.08.14 release of QEMU for Windows.

The QEMU release from 2020.11.20 is installed into the incorrect
directory and is causing EDK II CI failures in the run to shell
step.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-

VS2019.yml

index 02ed233fdb60..dd19fff50066 100644
--- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
+++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
@@ -132,7 +132,7 @@ jobs:
          build_flags: $(Build.Flags)
          run_flags: $(Run.Flags)
          extra_install_step:
-        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
+        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program

Files\qemu"

            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
            condition: and(gt(variables.pkg_count, 0), succeeded())
--------------65A8B2B1C20ECF5F965FA2F1--