public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Rebecca Cran'" <rebecca@bsdio.com>, <devel@edk2.groups.io>,
	"'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet
Date: Fri, 24 Mar 2023 12:55:18 +0800	[thread overview]
Message-ID: <035001d95e0c$d52042a0$7f60c7e0$@byosoft.com.cn> (raw)
In-Reply-To: <20230225005431.12173-3-rebecca@bsdio.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@bsdio.com>
> 发送时间: 2023年2月25日 8:55
> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>
> 主题: [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with
> __PcdGet
> 
> Replace the duplicate __PcdSet prototype in PcdValueCommon.h
> with the prototype for __PcdGet.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BaseTools/Source/C/Common/PcdValueCommon.h | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h
> b/BaseTools/Source/C/Common/PcdValueCommon.h
> index 02ef803be479..7dac5bd92dbc 100644
> --- a/BaseTools/Source/C/Common/PcdValueCommon.h
> +++ b/BaseTools/Source/C/Common/PcdValueCommon.h
> @@ -78,13 +78,12 @@ __PcdSet (
> 
>    @return PCD value
>  **/
> -VOID
> -__PcdSet (
> -  CHAR8   *SkuName             OPTIONAL,
> -  CHAR8   *DefaultValueName    OPTIONAL,
> -  CHAR8   *TokenSpaceGuidName,
> -  CHAR8   *TokenName,
> -  UINT64  Value
> +UINT64
> +__PcdGet (
> +  CHAR8  *SkuName             OPTIONAL,
> +  CHAR8  *DefaultValueName    OPTIONAL,
> +  CHAR8  *TokenSpaceGuidName,
> +  CHAR8  *TokenName
>    )
>  ;
> 
> --
> 2.37.1 (Apple Git-137.1)




  parent reply	other threads:[~2023-03-24  4:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25  0:54 [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify Rebecca Cran
2023-02-25  0:54 ` [PATCH 1/3] BaseTools: Source/C/Common: Fix doc block locations and convert to Doxygen Rebecca Cran
2023-02-25  0:54 ` [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet Rebecca Cran
2023-03-23 17:06   ` Rebecca Cran
2023-03-24  4:55   ` gaoliming [this message]
2023-02-25  0:54 ` [PATCH 3/3] BaseTools: Run Uncrustify over files in Source/C/Common Rebecca Cran
     [not found] ` <1746EB2C4B4E3528.29542@groups.io>
2023-03-09 15:43   ` [edk2-devel] [PATCH 1/3] BaseTools: Source/C/Common: Fix doc block locations and convert to Doxygen Rebecca Cran
2023-03-10  2:57 ` 回复: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify gaoliming
2023-03-10 17:57   ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='035001d95e0c$d52042a0$7f60c7e0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox