From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.94666.1679633861220578286 for ; Thu, 23 Mar 2023 21:57:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=PhL1Utl/; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 6D275DDA7A6 for ; Fri, 24 Mar 2023 12:57:39 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1679633859; bh=4VuROCdPtuD+epwZOnsUoc8PNYxObvzVsBZdn27dlYA=; h=From:To:References:In-Reply-To:Subject:Date; b=PhL1Utl/v4x53pBhGh6HSfcZoJUHCzV+kG2IP9gTQ0yh4vcpw+E0jgHvT6eFh+C+7 jW8h+a/rw5h8uX0vMsNvEoYBaDHUP1pElUoNUkIpcLb0Frl97GXOvkYSJ8q6eZ2T1V HeULetpKnh56LVi0hWB3CQMst5+I0Vw0SD65LHVY= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 69A2CDDA7A4 for ; Fri, 24 Mar 2023 12:57:39 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 307B1DDA7A1 for ; Fri, 24 Mar 2023 12:57:39 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id C6A57DDA789 for ; Fri, 24 Mar 2023 12:57:36 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 24 Mar 2023 12:57:25 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Andrew Fish'" , "'Leif Lindholm'" , "'Michael D Kinney'" , "'Bob Feng'" , "'Yuwei Chen'" References: <20230217035101.880854-1-rebecca@quicinc.com> <174ACADCDC6439C2.24021@groups.io> <174EE719E87C3CB3.19937@groups.io> In-Reply-To: <174EE719E87C3CB3.19937@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDAvM10gQmFzZVRvb2xzOiBhbGxvdyB1c2VycyB0byBvdmVycmlkZSBDQyBhbmQgQ1hYIG9uIHRoZSBtYWtlIGNvbW1hbmQgbGluZQ==?= Date: Fri, 24 Mar 2023 12:57:29 +0800 Message-ID: <035101d95e0d$2320acb0$69620610$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHhdjEqbj5m9MVt3JVUnbFfdWfwNgHYLn3SAkXeJZsCfWnFvK7EUgfQ Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Rebecca: I create PR https://github.com/tianocore/edk2/pull/4162 . But PR shows so= me failure. Can you help fix them? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming via > groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B43=E6=9C=8823=E6=97=A5 = 9:10 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; rebecca@bsdio.com; 'An= drew Fish' > ; 'Leif Lindholm' ; 'Michael = D > Kinney' ; 'Bob Feng' ; > 'Yuwei Chen' > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 0/3] BaseTool= s: allow users to override CC > and CXX on the make command line >=20 > Rebecca: > This patch looks good to me. Reviewed-by: Liming Gao > >=20 > I will help to merge this patch set. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Rebecca Cran > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B43=E6=9C=8815=E6=97= =A5 0:17 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Andrew Fish ; Leif > > Lindholm ; Michael D Kinney > > ; Bob Feng ; Liming > > Gao ; Yuwei Chen > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 0/3] BaseTools: allow users= to override CC > and > > CXX on the make command line > > > > This is a patch series that I'd really like to get committed. > > > > It'll allow us to drop the dependency on gcc for building edk2 on FreeB= SD. > > > > > > The Github branch is https://github.com/bcran/edk2/tree/mdepkg-c11 and > > there's a PR at https://github.com/tianocore/edk2/pull/4142. > > > > > > -- > > > > Rebecca Cran > > > > > > On 3/9/23 8:47 AM, Rebecca Cran wrote: > > > Could I get some reviews on this please? > > > > > > > > > Thanks. > > > > > > Rebecca Cran > > > > > > > > > On 2/16/23 8:50 PM, Rebecca Cran wrote: > > >> Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which > > >> doesn't allow users to override the compiler to use in the expected = way > > >> by running e.g. "make CC=3Dclang-17 CXX=3Dclang++-17". clang/llvm su= pport > > >> was added in https://bugzilla.tianocore.org/show_bug.cgi?id=3D2842 i= n a > > >> way that required users to run "make CXX=3Dllvm" and have clang and > > >> clang++ > > >> executables under $(CLANG_BIN). As far as I know this isn't a standa= rd > > >> way of telling a build system to use clang, and so is likely difficu= lt > > >> to discover by users. > > >> > > >> This patch series fixes that, and as a side effect allows the clang > > >> analyzer to run via "scan-build make". > > >> > > >> Since clang 17 defaults to C++17 or newer where the 'register' keywo= rd > > >> is deprecated and the warning turned into an error, override the > > >> version used when building C++ code via "-std=3Dc++14". > > >> > > >> Rebecca Cran (3): > > >> BaseTools: Allow users to specify compiler to use with make CC=3D > > CXX=3D > > >> BaseTools: Improve detection of users wanting to build using clan= g > > >> BaseTools: Build against C++14 when building with clang > > >> > > >> BaseTools/Source/C/DevicePath/GNUmakefile | 7 ++- > > >> BaseTools/Source/C/LzmaCompress/GNUmakefile | 2 +- > > >> BaseTools/Source/C/Makefiles/app.makefile | 2 +- > > >> BaseTools/Source/C/Makefiles/footer.makefile | 6 +- > > >> BaseTools/Source/C/Makefiles/header.makefile | 59 > > >> ++++++++++---------- > > >> BaseTools/Source/C/VfrCompile/GNUmakefile | 19 > > ++++--- > > >> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 20 +++---- > > >> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 31 > +++++----- > > >> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > > >> 9 files changed, 76 insertions(+), 72 deletions(-) > > >> >=20 >=20 >=20 >=20 >=20 >=20