public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Pete Batard <pete@akeo.ie>, devel@edk2.groups.io
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org
Subject: Re: [edk2-platforms][PATCH 1/3] Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
Date: Mon, 2 Dec 2019 13:16:18 +0100	[thread overview]
Message-ID: <03519429-df58-ab74-b913-6fe8e9e14e31@redhat.com> (raw)
In-Reply-To: <20191202115506.4068-2-pete@akeo.ie>

On 12/2/19 12:55 PM, Pete Batard wrote:
> The Bcm283x architecture provides multiple implementations of the
> Random Number Generator, that have incompatibilities with one
> another.
> 
> Because we will need to add a new driver for the Bcm2838 RNG we
> rename the existing Bcm2835-compatible driver to Bcm2835RngDxe
> and update the one platform that depends on this driver (RPi3).
> 
> We also rename the internal function calls from Bcm2836 to
> Bcm2835 since, if we ever add platform support for Pi models
> that use this SoC (original Pi, Pi Zero, etc), it may look
> confusing to reference a feature that seems to belongs to the
> next SoC iteration.
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc                                                      |  2 +-
>   Platform/RaspberryPi/RPi3/RPi3.fdf                                                      |  2 +-
>   Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c}     | 16 ++++++++--------
>   Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} |  6 +++---
>   4 files changed, 13 insertions(+), 13 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


  reply	other threads:[~2019-12-02 12:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 11:55 [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements Pete Batard
2019-12-02 11:55 ` [edk2-platforms][PATCH 1/3] Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver Pete Batard
2019-12-02 12:16   ` Philippe Mathieu-Daudé [this message]
2019-12-02 11:55 ` [edk2-platforms][PATCH 2/3] Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header Pete Batard
2019-12-02 12:17   ` Philippe Mathieu-Daudé
2019-12-02 11:55 ` [edk2-platforms][PATCH 3/3] Silicon/Broadcom/Bcm283x: Add Bcm2838 RNG driver Pete Batard
2019-12-02 16:03 ` [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements Ard Biesheuvel
2019-12-02 16:53   ` [edk2-devel] " Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03519429-df58-ab74-b913-6fe8e9e14e31@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox