From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.232.1575288984051278708 for ; Mon, 02 Dec 2019 04:16:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U8YstK10; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575288983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OWGk9/JBYuISLkP/QA2O6sDHOByK8ek05msPavDNb9g=; b=U8YstK10FZJsEMvx9bsumdpOJn56V5JeI0GTtNyTI7rJQsd5+DqI89IDJ6gxSWnAkMqht+ 5XMAF4YEz2UtfEyblOTjSI6mSo4YfHw/Ou1p0JkB4fr/Rj63AGaMAEozawO7u46jAjp2Rw v30jv1Ue+gGWslml4QO9Dnx1AOw23wM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-bca0aqmBMm-xP38_3jxeEA-1; Mon, 02 Dec 2019 07:16:21 -0500 Received: by mail-wr1-f69.google.com with SMTP id q12so20411462wrr.3 for ; Mon, 02 Dec 2019 04:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OWGk9/JBYuISLkP/QA2O6sDHOByK8ek05msPavDNb9g=; b=ASUEULPa0FAE4airm8aUVoNEIuPUUGBWI2wCt2rkgX5P2eMC9o/TZEtwweLL9fRgzp kwynB1p+aPneMCiggDvTXoUxTu9Eq1f6F9y2aWaeX+1auGEL5J+aSdQYElVliatiiagm 0PnyfFQUE3Y91TFqw8P5I2MY9X+cHh+Aqor9Oz2seS9uT2dte1wGkEtxOhhKBKGL0Hc3 Okaw4afnTiaaOToP4W1+9EHzl4JD/BMz0ND2A9IpM8QgAaymoxJYXpUZ1MDqB0gaj6xK X29wwrXrK1u5m8vLCLsH6O4CqAskYL45DDyQqNVmZ9aMztQP8IWfL+RCrKHw0xspHBAd vZIw== X-Gm-Message-State: APjAAAWrZ+LeT2ZrIfuh3E+O7MJNvcqRjId+bRqdkDC+pn2HUZ4qcCue Pg/vL1gGlfMqq6BpvKzfNiLpMj+FFf9TMxCNgnmKyuiLDGYg8g7v0PsRTaqLZSqCv28gqYyHSXl ftoYivLi3aF6FsQ== X-Received: by 2002:a05:6000:1142:: with SMTP id d2mr9364052wrx.253.1575288980665; Mon, 02 Dec 2019 04:16:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxJet+q9kZAltbNb1tGGgKglfKUKNpd3+qLkIGDI3F6fX/sSGpw8puPiaJMrRO4YPMs8hgxdw== X-Received: by 2002:a05:6000:1142:: with SMTP id d2mr9364022wrx.253.1575288980441; Mon, 02 Dec 2019 04:16:20 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id z13sm324126wmi.18.2019.12.02.04.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2019 04:16:19 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/3] Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver To: Pete Batard , devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org References: <20191202115506.4068-1-pete@akeo.ie> <20191202115506.4068-2-pete@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <03519429-df58-ab74-b913-6fe8e9e14e31@redhat.com> Date: Mon, 2 Dec 2019 13:16:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191202115506.4068-2-pete@akeo.ie> X-MC-Unique: bca0aqmBMm-xP38_3jxeEA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/19 12:55 PM, Pete Batard wrote: > The Bcm283x architecture provides multiple implementations of the > Random Number Generator, that have incompatibilities with one > another. > > Because we will need to add a new driver for the Bcm2838 RNG we > rename the existing Bcm2835-compatible driver to Bcm2835RngDxe > and update the one platform that depends on this driver (RPi3). > > We also rename the internal function calls from Bcm2836 to > Bcm2835 since, if we ever add platform support for Pi models > that use this SoC (original Pi, Pi Zero, etc), it may look > confusing to reference a feature that seems to belongs to the > next SoC iteration. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- > Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- > Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} | 16 ++++++++-------- > Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} | 6 +++--- > 4 files changed, 13 insertions(+), 13 deletions(-) Reviewed-by: Philippe Mathieu-Daude