From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.60.1598460423522067723 for ; Wed, 26 Aug 2020 09:47:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OeMyhTVk; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598460422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2FE9tIKCdvLaZMlTCf3HG2DoOztvuyr2DfkZvt7HEUk=; b=OeMyhTVkN+bxmH1MBAPl3S+6fH7RNmkW9yK9mJUEC2rTbB9Ssg8tcbcWFjK2jY8BSzOD6N e7fc1wgSRNI4U7jA8T+e6fM+yQ2TeWKC52ElvdcwejKYGBwkRHeOkmaDcrSUFaXiW7TQQT 5yYpESAM4YGvonikwkcP8pBqxPSX9Hc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-NWXUufqfOK6r3FTMSn2Qzg-1; Wed, 26 Aug 2020 12:46:55 -0400 X-MC-Unique: NWXUufqfOK6r3FTMSn2Qzg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD3901DDFC; Wed, 26 Aug 2020 16:46:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-182.ams2.redhat.com [10.36.114.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90EAC19C58; Wed, 26 Aug 2020 16:46:53 +0000 (UTC) Subject: Re: [edk2-devel] Patch to improve DNS answers parser To: devel@edk2.groups.io, lbecker@positivo.com.br References: Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu From: "Laszlo Ersek" Message-ID: <0357532a-eca4-7482-2427-8978655b79cc@redhat.com> Date: Wed, 26 Aug 2020 18:46:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US On 08/26/20 18:24, Leandro G. B. Becker wrote: > Hello folks, > > I made an improvement to DNS client (DnsImpl.c, line 1392) that instead of abort processing answer records when a record that is not of type PTR is received, skip the record and goes to the next one if there is one. I had a problem while resolving some names when DNS receives more than one answer and the first one is not of type 0xC0 (PTR) and now it is working fine. > > So to submit the patch for review is through this e-mail group, following the instructions at https://github.com/tianocore/edk2, section "Code Contributions"? Yes please! See also the official description at: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process and if you care for a very long & unofficial one: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers When you post the patch for NetworkPkg, please CC the NetworkPkg reviewers / maintainers (see Maintainers.txt). Thanks! Laszlo