From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.11365.1682562308852818654 for ; Wed, 26 Apr 2023 19:25:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=KIe0wXE7; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id B6118DDA7DC for ; Thu, 27 Apr 2023 10:25:05 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1682562305; bh=m8zgd1Wz0PZ8OSSiTSiMUDwXUFW/AXkkV0AsYlQJUj0=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=KIe0wXE72h8J+YtLRhH0MmSpYnc+L5Bfh4EJi1+hFLwIUlpN6YwF5TlA0YAUdXqF5 X7eeuaS18pgu7Kyk5s3t7T+uVfof9KNsO24UyuWxOhGFpG6kWxW1yVF9h28WJ6dlkr dPusArt5o0qmmHe668JHKpmOhhl2d8pqHiVenE+k= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id B1912DDA7CC for ; Thu, 27 Apr 2023 10:25:05 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 8175ADDA816 for ; Thu, 27 Apr 2023 10:25:05 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 1D840DDA7DC for ; Thu, 27 Apr 2023 10:25:02 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 27 Apr 2023 10:24:57 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Jian J Wang'" , "'Dandan Bi'" , "'Eric Dong'" , "'Jiewen Yao'" References: <20230425064027.18117-1-pen-chunx.lu@intel.com> In-Reply-To: <20230425064027.18117-1-pen-chunx.lu@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBGaXggR0NDNSBSZWxlYXNlIGJ1aWxkIHdhcm5pbmcgWy1XcmV0dXJuLWxvY2FsLWFkZHJd?= Date: Thu, 27 Apr 2023 10:25:01 +0800 Message-ID: <035a01d978af$78535f40$68fa1dc0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIokKCM3LPqB3RoYFfHzw9xVnJ1eq6gPWcQ Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Pen: How do you find this warning message? And, please separate the patch for the different packages.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED JoeX Lu > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA4=D4=C225=C8=D5 14:40 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: JoeX Lu ; Jian J Wang > ; Liming Gao ; Dandan > Bi ; Eric Dong ; Jiewen Yao > > =D6=F7=CC=E2: [edk2-devel] [PATCH] Fix GCC5 Release build warning > [-Wreturn-local-addr] >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Dandan Bi > Cc: Eric Dong > Cc: devel@edk2.groups.io > Cc: Jiewen Yao > Signed-off-by: JoeX Lu > --- > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 20 ++++++++++++------- > .../HashLibBaseCryptoRouterPei.c | 19 > ++++++++++++++---- > 2 files changed, 28 insertions(+), 11 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > index 63a37ab59a..a024d3b8d2 100644 > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > @@ -3415,25 +3415,31 @@ HiiCreateGuidOpCode ( > IN UINTN OpCodeSize > ) > { > - EFI_IFR_GUID OpCode; > + EFI_IFR_GUID *OpCode; > EFI_IFR_GUID *OpCodePointer; >=20 > ASSERT (Guid !=3D NULL); > ASSERT (OpCodeSize >=3D sizeof (OpCode)); >=20 > - ZeroMem (&OpCode, sizeof (OpCode)); > - CopyGuid ((EFI_GUID *)(VOID *)&OpCode.Guid, Guid); > + OpCode =3D (EFI_IFR_GUID *) AllocateZeroPool (sizeof (EFI_IFR_GUID)); > + if (OpCode =3D=3D NULL) { > + return NULL; > + } > + CopyGuid ((EFI_GUID *)(VOID *)&OpCode->Guid, Guid); >=20 > OpCodePointer =3D (EFI_IFR_GUID *)InternalHiiCreateOpCodeExtended ( > OpCodeHandle, > - &OpCode, > + OpCode, > EFI_IFR_GUID_OP, > - sizeof (OpCode), > - OpCodeSize - sizeof (OpCode), > + sizeof (EFI_IFR_GUID), > + OpCodeSize - sizeof > (EFI_IFR_GUID), > 0 > ); > if ((OpCodePointer !=3D NULL) && (GuidOpCode !=3D NULL)) { > - CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, > OpCodeSize - sizeof (OpCode)); > + CopyMem (OpCodePointer + 1, (EFI_IFR_GUID *)GuidOpCode + 1, > OpCodeSize - sizeof (EFI_IFR_GUID)); > + } > + if (OpCode !=3D NULL) { > + FreePool (OpCode); > } >=20 > return (UINT8 *)OpCodePointer; > diff --git > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > index eeb424b6c3..c8052fed15 100644 > --- > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > +++ > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > @@ -84,11 +84,22 @@ InternalCreateHashInterfaceHob ( > EFI_GUID *Identifier > ) > { > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *HobBuffer; >=20 > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > + HobBuffer =3D NULL; > + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof > (HASH_INTERFACE_HOB)); > + if (LocalHashInterfaceHob =3D=3D NULL) { > + return NULL; > + } > + > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > + HobBuffer =3D (HASH_INTERFACE_HOB *) BuildGuidDataHob > (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof > (LocalHashInterfaceHob)); > + > + if (LocalHashInterfaceHob !=3D NULL) { > + FreePool (LocalHashInterfaceHob); > + } > + return HobBuffer; > } >=20 > /** > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20