From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from loongson.cn (loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.8019.1683688585945838041 for ; Tue, 09 May 2023 20:16:26 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: loongson.cn, ip: 114.242.206.163, mailfrom: lichao@loongson.cn) Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Cxd+mFDFtkdjwHAA--.12020S3; Wed, 10 May 2023 11:16:22 +0800 (CST) Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxQbSFDFtkS3xTAA--.18542S3; Wed, 10 May 2023 11:16:21 +0800 (CST) Message-ID: <03756ea7-bc58-1408-9acb-af43c7a9d2bf@loongson.cn> Date: Wed, 10 May 2023 11:16:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/4] LoongArchQemuPkg: Use MdeModulePkg's SataControllerDxe To: devel@edk2.groups.io, pedro.falcato@gmail.com Cc: Bibo Mao , Xianglai li References: <20230509161439.288422-1-pedro.falcato@gmail.com> <20230509161439.288422-4-pedro.falcato@gmail.com> From: "Chao Li" In-Reply-To: <20230509161439.288422-4-pedro.falcato@gmail.com> X-CM-TRANSID: AQAAf8AxQbSFDFtkS3xTAA--.18542S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAHCGRaN-14egAAs4 X-Coremail-Antispam: 1Uk129KBjvJXoW7Zry5Jr1rCw15Zr1kGryDKFg_yoW8CrW8pF 15u3W7Kr1UJa1qkw1rGa45WwsFyr9IkrykXrs5Xw12kF97G3WDu345JF4rCry2y347ta48 Z348Kw4UWa1DXFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj DUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbxxYFVCjjxCrM7AC8VAFwI0_Jr0_ Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFV AK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2 z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr 1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG 8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aV AFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8GjcxK6IxK0xII j40E5I8CrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r 1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_ JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCT nIWIevJa73UjIFyTuYvjxUr38nUUUUU Content-Type: multipart/alternative; boundary="------------cIA0l5L6TjZv17Ab4gfUbI0o" --------------cIA0l5L6TjZv17Ab4gfUbI0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit If ther driver is ok in the MdeModulePkg version, that's fine. Reviewed-by: Chao Li Thanks, Chao 在 2023/5/10 00:14, Pedro Falcato 写道: > As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the > generic version in MdeModulePkg. > > Cc: Bibo Mao > Cc: Xianglai li > Cc: Chao Li > Signed-off-by: Pedro Falcato > --- > Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 2 +- > Platform/Loongson/LoongArchQemuPkg/Loongson.fdf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc > index 465e9229a2c4..6875e39cc604 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc > +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc > @@ -550,7 +550,7 @@ > # > # IDE/SCSI > # > - OvmfPkg/SataControllerDxe/SataControllerDxe.inf > + MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > > diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf > index 03cbcf86301b..8a759c0238ee 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf > +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf > @@ -178,7 +178,7 @@ INF OvmfPkg/PlatformDxe/Platform.inf > # > # SATA/SCSI > # > -INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf > +INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > --------------cIA0l5L6TjZv17Ab4gfUbI0o Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

If ther driver is ok in the MdeModulePkg version, that's fine.

Reviewed-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/5/10 00:14, Pedro Falcato 写道:
As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
generic version in MdeModulePkg.

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 2 +-
 Platform/Loongson/LoongArchQemuPkg/Loongson.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
index 465e9229a2c4..6875e39cc604 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
@@ -550,7 +550,7 @@
   #
   # IDE/SCSI
   #
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
index 03cbcf86301b..8a759c0238ee 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
@@ -178,7 +178,7 @@ INF  OvmfPkg/PlatformDxe/Platform.inf
 #
 # SATA/SCSI
 #
-INF  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+INF  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
 INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
--------------cIA0l5L6TjZv17Ab4gfUbI0o--