From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.48599.1683203948976256423 for ; Thu, 04 May 2023 05:39:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=O90LFedY; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 2A7FADDA799 for ; Thu, 4 May 2023 20:39:05 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683203945; bh=CSAGn/y4jZe7iZ1lEKraLEblQTDdUqwV55UgvFk5W1Y=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=O90LFedYC/IFaRJHcIGAjD4uftbK62xnIZj7AeJ7OHwB8W4qEHf1cUh5s5KmQUd9u 4dfo6akGcf6auzHTiYW21exAtC0lJdSAUl+xLIFcXMu1eFZaN4r6Dpyp5cWu6xXn/P kv2OjDKSWqoAgsTjsjdO0r+dgwRgsD0eP5cgVw4E= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 25EEFDDA794 for ; Thu, 4 May 2023 20:39:05 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C67E2DDA792 for ; Thu, 4 May 2023 20:39:04 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 58145DDA791 for ; Thu, 4 May 2023 20:39:01 +0800 (CST) Received: from DESKTOPS6D0PVI ([114.92.84.222]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 04 May 2023 20:38:44 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.92.84.222 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Gerd Hoffmann'" , Cc: "'Yuwei Chen'" , "'Oliver Steffen'" , "'Bob Feng'" , =?UTF-8?Q?'Marvin_H=C3=A4user'?= , "'Daniel Schaefer'" , "'Chao Li'" , "'Dongyan Qian'" , "'Michael D Kinney'" , "'Pawel Polawski'" , "'Baoqi Zhang'" , "'Leif Lindholm'" , "'Rebecca Cran'" , "'Zhiguang Liu'" , "'Sunil V L'" , "'Ard Biesheuvel'" References: <20230421044535.4030762-1-kraxel@redhat.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjUgMDAvMTBdIEJhc2VUb29sczogcmVtb3ZlIGR1cGxpY2F0ZSBpbmNsdWRlcy4=?= Date: Thu, 4 May 2023 20:38:47 +0800 Message-ID: <037f01d97e85$5f450810$1dcf1830$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHoTQPDElfWP+Rj6QAvucuw8o8oPAFjdDs4ryFT+kA= Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Gerd: I have no other comments for this patch set. This change is great to = reduce the duplication definitions. Reviewed-by: Liming Gao Besides, GCC49 tool chain doesn't define USING_LTO macro. If GCC49 is = verified, it will be better. Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Gerd Hoffmann > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2023=E5=B9=B45=E6=9C=884=E6=97=A5 18:11 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Yuwei Chen ; Oliver Steffen > ; Bob Feng ; Marvin = H=C3=A4user > ; Daniel Schaefer ; Chao Li > ; Dongyan Qian ; Michael > D Kinney ; Pawel Polawski > ; Baoqi Zhang ; Leif > Lindholm ; Rebecca Cran = ; > Zhiguang Liu ; Sunil V L > ; Ard Biesheuvel = ; > Liming Gao > =E4=B8=BB=E9=A2=98: Re: [PATCH v5 00/10] BaseTools: remove duplicate = includes. >=20 > Ping. >=20 > On Fri, Apr 21, 2023 at 06:45:25AM +0200, Gerd Hoffmann wrote: > > There is alot of code duplication between BaseTools and MdePkg (and = also > > MdeModulePkg). This patch series starts reducing this by removing = some > > header files. BaseTools are switched over to use the include files = in > > MdePkg instead. It also cleans up some (apparently) obsolete code = and > > adapts BaseTools code in a few places to work with the MdePkg = version of > > the include files. > > > > v5 changes: > > - remove visibility hidden on x64 > > - add assert for GOT being empty. > > v4 changes: > > - fix clang build failure > > v3 changes: > > - fix build failure on ubuntu 22.04 > > v2 changes: > > - rebase to latest master, resolve conflicts. > > - pick up reviews and acks. > > > > take care, > > Gerd > > > > Gerd Hoffmann (10): > > BaseTools: make sure the got is empty > > MdePkg: don't set visibility to hidden > > BaseTools: remove WinNtInclude.h > > BaseTools: remove duplicate includes: /ProcessorBind.h > > BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h > > MdePkg/PeImage.h: add bits from BaseTools version > > BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks > > BaseTools: switch from EFI_IMAGE_MACHINE_* to > IMAGE_FILE_MACHINE_* > > BaseTools: remove duplicate includes: IndustryStandard/PeImage.h > > BaseTools: remove duplicate includes: IndustryStandard/*.h > > > > BaseTools/Source/C/Common/WinNtInclude.h | 66 -- > > BaseTools/Source/C/EfiRom/EfiRom.h | 14 +- > > .../Source/C/Include/AArch64/ProcessorBind.h | 148 ---- > > .../Source/C/Include/Arm/ProcessorBind.h | 147 ---- > > .../Source/C/Include/Ia32/ProcessorBind.h | 155 ---- > > .../Source/C/Include/IndustryStandard/Acpi.h | 117 --- > > .../C/Include/IndustryStandard/Acpi1_0.h | 285 ------- > > .../C/Include/IndustryStandard/Acpi2_0.h | 520 ------------ > > .../C/Include/IndustryStandard/Acpi3_0.h | 668 --------------- > > .../C/Include/IndustryStandard/Bluetooth.h | 56 -- > > .../C/Include/IndustryStandard/EfiPci.h | 51 -- > > ...emoryMappedConfigurationSpaceAccessTable.h | 39 - > > .../C/Include/IndustryStandard/PeImage.h | 789 = ------------------ > > .../Source/C/Include/IndustryStandard/pci22.h | 536 ------------ > > .../Source/C/Include/IndustryStandard/pci23.h | 18 - > > .../Source/C/Include/IndustryStandard/pci30.h | 38 - > > .../C/Include/LoongArch64/ProcessorBind.h | 80 -- > > .../Source/C/Include/Protocol/DevicePath.h | 2 +- > > .../Source/C/Include/RiscV64/ProcessorBind.h | 85 -- > > .../Source/C/Include/X64/ProcessorBind.h | 183 ---- > > MdePkg/Include/IndustryStandard/PeImage.h | 31 + > > MdePkg/Include/X64/ProcessorBind.h | 14 - > > BaseTools/Source/C/Common/BasePeCoff.c | 51 +- > > BaseTools/Source/C/Common/Decompress.c | 1 + > > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 43 +- > > BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +- > > BaseTools/Source/C/GenFw/Elf64Convert.c | 12 +- > > BaseTools/Source/C/GenFw/ElfConvert.c | 2 - > > BaseTools/Source/C/GenFw/GenFw.c | 18 +- > > BaseTools/Scripts/ClangBase.lds | 10 + > > BaseTools/Scripts/GccBase.lds | 10 + > > BaseTools/Source/C/Makefiles/header.makefile | 15 +- > > BaseTools/Source/C/Makefiles/ms.common | 13 +- > > 33 files changed, 132 insertions(+), 4093 deletions(-) > > delete mode 100644 BaseTools/Source/C/Common/WinNtInclude.h > > delete mode 100644 > BaseTools/Source/C/Include/AArch64/ProcessorBind.h > > delete mode 100644 BaseTools/Source/C/Include/Arm/ProcessorBind.h > > delete mode 100644 BaseTools/Source/C/Include/Ia32/ProcessorBind.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/Acpi.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/Acpi1_0.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/Acpi2_0.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/Acpi3_0.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/Bluetooth.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/EfiPci.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/MemoryMappedConfiguration > SpaceAccessTable.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/PeImage.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/pci22.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/pci23.h > > delete mode 100644 > BaseTools/Source/C/Include/IndustryStandard/pci30.h > > delete mode 100644 > BaseTools/Source/C/Include/LoongArch64/ProcessorBind.h > > delete mode 100644 > BaseTools/Source/C/Include/RiscV64/ProcessorBind.h > > delete mode 100644 BaseTools/Source/C/Include/X64/ProcessorBind.h > > > > -- > > 2.40.0 > > >=20 > --