From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.3394.1670374775092373749 for ; Tue, 06 Dec 2022 16:59:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=QbTZsHGz; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id B5B77CD1F802 for ; Wed, 7 Dec 2022 08:59:31 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1670374771; bh=h2J/QhGGUPpRGF89HcjPbFpxqRgLRs5pDbHGq69g8ZE=; h=From:To:References:In-Reply-To:Subject:Date; b=QbTZsHGzjUB6Su7pRAHCEKOaCqA1T78p6m2algTNWpKg4WS7gMt21iVUB7rSwxlY/ s1x/KsCjCipgwMTgdUbHLYHM/KaFomhzG2GsPvg46MKcuWHvKFpWUzWG/Gmip3xA9o 9EE7K73kRZEpJNO9raRjVsiLY3BJOWu5j3zN8DPw= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id B1481CD1F809 for ; Wed, 7 Dec 2022 08:59:31 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 83E72CD1F7F0 for ; Wed, 7 Dec 2022 08:59:31 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 1115FCD1F78A for ; Wed, 7 Dec 2022 08:59:28 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 07 Dec 2022 08:59:23 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kinney, Michael D'" , , References: In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gZmVhdHVyZSBmbGFnIGNoYW5nZSBub3RpZmljYXRpb25z?= Date: Wed, 7 Dec 2022 08:59:25 +0800 Message-ID: <039201d909d7$2681f510$7385df30$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQF5CpKSV3mZpSCsoYOIqvVCuS0YPQH2Zi7zrxHlRMA= Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Dann: I base on new features to collect the incompatible changes, and add them = into the updated notes.=20 If you find any missing, please send the mail to me.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B412=E6=9C=886=E6=97=A5 = 9:22 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; dann.frazier@canonical= .com; Gao, Liming > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] feature flag change notifications >=20 > Hi Dann, >=20 > These are reasonable requests. >=20 > Adding Liming Gao who is currently responsible for the edk2 releases. >=20 > Let's start with release notes and see if some of these can be added > to the release documentation and add to the edk2 release process > to clearly note these type of changes in future release notes. >=20 > As far as #error and #warn. Those are possible, but we would need > to do some analysis for the types of changes that would require > that behavior. Your examples are useful as a starting point. >=20 > Once concern is how many of those #error/#warn conditions will > build up over time and then a process to remove them after an > expiration period. >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of dann > frazier > > Sent: Monday, December 5, 2022 4:10 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] feature flag change notifications > > > > Hi, > > I maintain the edk2 packages in the Debian and Ubuntu > > distributions. A few times over the years I've had users report > > regressions that turned out to be due to upstream build flag > > changes. I wonder if it would be possible for upstream to communicate > > such changes - either via release notes or, where possible, as > > build-time checks - to us downstream projects. Here are the examples I > > recall: > > > > > commit 4de8d61bcec02a13ceed84f92b0cf3ea58adf9c5 > > > Author: Gerd Hoffmann > > > Date: Wed Dec 15 12:39:20 2021 +0100 > > > > > > OvmfPkg: rework TPM configuration > > > > > > > For this I needed to change -DTPM_ENABLE=3DTRUE to > -DTPM2_ENABLE=3DTRUE. I > > feel like a build-time check would've been a good way to communicate > > this one, e.g.: > > > > #ifdef TPM_ENABLE > > #error TPM_ENABLE has been renamed to TPM2_ENABLE > > #endif > > > > > commit 1631bb26ae991e530d3c96fe3161ea15144b358e > > > Author: Gary Lin > > > Date: Mon Jun 10 14:55:09 2019 +0800 > > > > > > OvmfPkg/README: Update the network build flags > > > > > > The following network build flags changed due to the inclusion of > > > NetworkPkg/Network.fdf.inc. > > > > > Similar to the above, I needed to deal with this by setting > > -DNETWORK_HTTP_BOOT_ENABLE=3DTRUE instead of > -DHTTP_BOOT_ENABLE=3DTRUE. It > > seems like maybe an #error on the removed #define could've helped > > here as well. > > > > And finally: > > > > > commit 57783adfb579da32b1eeda77b2bec028a5e0b7b3 > > > Author: Michael D Kinney > > > Date: Tue Jul 26 12:40:00 2022 -0700 > > > > > > OvmfPkg: Change default to disable MptScsi and PvScsi > > > > With this types of change, it would be useful just to know this is > > coming and why so I can decide to either notify users of the change > > and/or override the default to avoid the regression. Would it be > > possible to describe such changes in the release notes at > > https://github.com/tianocore/edk2/releases - and, if not urgent, > > perhaps #warn of deprecation in the source for one stable release > > cycle? > > > > -dann > > > > > >=20 > >