回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS

["gaoliming" <gaoliming@byosoft.com.cn>]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunil V L
> 发送时间: 2023年6月22日 12:23
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei Chen
> <yuwei.chen@intel.com>; Andrei Warkentin <andrei.warkentin@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add
> "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS
> 
> Hi Liming,
> 
> Gentle ping!
> 
> We need this to support gcc-13.
> 
> Thanks!
> Sunil
> On Wed, Jun 14, 2023 at 05:29:12PM +0530, Sunil V L via groups.io wrote:
> > Hi Liming,
> >
> > Could you please help with review and merge of this patch? Do I need to
> > raise a BZ ticket?
> >
> > Thanks!
> > Sunil
> > On Fri, Jun 02, 2023 at 10:32:54PM +0530, Sunil V L wrote:
> > > gcc-13 for RISC-V enables unwind tables by default similar to ARM64.
> > > This generates .eh_frame_hdr section which is not handled well by
> > > GenFw causing failures.
> > >
> > > Disable the unwind tables by adding -fno-unwind-tables flag similar
> > > to [1].
> > >
> > > [1] - https://github.com/tianocore/edk2/commit/cbf00651eda6
> > >
> > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> > > ---
> > >  BaseTools/Conf/tools_def.template | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> > > index 92421e3d0118..90f4105506e5 100755
> > > --- a/BaseTools/Conf/tools_def.template
> > > +++ b/BaseTools/Conf/tools_def.template
> > > @@ -858,7 +858,7 @@ DEFINE GCC5_RISCV_OPENSBI_TYPES
> = -DOPENSBI_EXTERNAL_SBI_TYPES
> > >
> > >  DEFINE GCC5_RISCV64_ARCH                   = rv64gc
> > >  DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS =
> DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u
> ReferenceAcpiTable
> > > -DEFINE GCC5_RISCV64_CC_FLAGS               =
> DEF(GCC5_RISCV_ALL_CC_FLAGS)
> DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE)
> DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH)
> -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address
> -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable
> -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax
> > > +DEFINE GCC5_RISCV64_CC_FLAGS               =
> DEF(GCC5_RISCV_ALL_CC_FLAGS)
> DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE)
> DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH)
> -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address
> -fno-asynchronous-unwind-tables -fno-unwind-tables
> -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany
> -mabi=lp64 -mno-relax
> > >  DEFINE GCC5_RISCV64_DLINK_FLAGS            =
> DEF(GCC5_RISCV_ALL_DLINK_FLAGS)
> -Wl,-melf64lriscv,--oformat=elf64-littleriscv,--no-relax
> > >  DEFINE GCC5_RISCV64_DLINK2_FLAGS           =
> DEF(GCC5_RISCV_ALL_DLINK2_FLAGS)
> > >  DEFINE GCC5_RISCV64_ASM_FLAGS              =
> DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH)
> -mcmodel=medany -mabi=lp64
> > > --
> > > 2.34.1
> > >
> >
> >
> >
> >
> >
> 
> 
> 
>