From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.4219.1687655291777422188 for ; Sat, 24 Jun 2023 18:08:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=Ueh8YU2e; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 4AE92DDA78A for ; Sun, 25 Jun 2023 09:06:41 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1687655201; bh=jazN1bmnOZxyWWOOWvlrbQavkB3KwqIlrBY7qM+VAPs=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=Ueh8YU2eeVqONbdNBUMbk9A9UNfLDaoMzsbiNCbfZp7GV7PjjQBO3ApLaywlJHmfY dToKunZ3A11ZWUU5l3v0+bBA+RVcUlbJewx6OMgKkhCVKXFAo0ff86+MLM3fDJDWXg ozYw8Bdp36MUAbPhMNZRzqPLSmM9gK5l8GE6P/oQ= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 46765DDA787 for ; Sun, 25 Jun 2023 09:06:41 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 04621DDA7B8 for ; Sun, 25 Jun 2023 09:06:41 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 98917DDA78A for ; Sun, 25 Jun 2023 09:06:37 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sun, 25 Jun 2023 09:06:33 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Rebecca Cran'" , "'Bob Feng'" , "'Yuwei Chen'" , "'Andrei Warkentin'" References: <20230602170254.394449-1-sunilvl@ventanamicro.com> <176884B1D2310EB7.32355@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzL3Rvb2xzX2RlZjogQWRkICItZm5vLXVud2luZC10YWJsZXMiIHRvIEdDQzVfUklTQ1Y2NF9DQ19GTEFHUw==?= Date: Sun, 25 Jun 2023 09:06:34 +0800 Message-ID: <03a301d9a701$490bdb60$db239220$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGMe4/ONO5QqQ2uYeF+Myw5+f1/vAKDnBfZAYfb2kuwFK+S8A== Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Sunil V L > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA6=D4=C222=C8=D5 12:23 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Rebecca Cran ; Liming Gao > ; Bob Feng ; Yuwei Chen > ; Andrei Warkentin > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add > "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS >=20 > Hi Liming, >=20 > Gentle ping! >=20 > We need this to support gcc-13. >=20 > Thanks! > Sunil > On Wed, Jun 14, 2023 at 05:29:12PM +0530, Sunil V L via groups.io wrote: > > Hi Liming, > > > > Could you please help with review and merge of this patch? Do I need to > > raise a BZ ticket? > > > > Thanks! > > Sunil > > On Fri, Jun 02, 2023 at 10:32:54PM +0530, Sunil V L wrote: > > > gcc-13 for RISC-V enables unwind tables by default similar to ARM64. > > > This generates .eh_frame_hdr section which is not handled well by > > > GenFw causing failures. > > > > > > Disable the unwind tables by adding -fno-unwind-tables flag similar > > > to [1]. > > > > > > [1] - https://github.com/tianocore/edk2/commit/cbf00651eda6 > > > > > > Signed-off-by: Sunil V L > > > Cc: Rebecca Cran > > > Cc: Liming Gao > > > Cc: Bob Feng > > > Cc: Yuwei Chen > > > Cc: Andrei Warkentin > > > --- > > > BaseTools/Conf/tools_def.template | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > > > index 92421e3d0118..90f4105506e5 100755 > > > --- a/BaseTools/Conf/tools_def.template > > > +++ b/BaseTools/Conf/tools_def.template > > > @@ -858,7 +858,7 @@ DEFINE GCC5_RISCV_OPENSBI_TYPES > =3D -DOPENSBI_EXTERNAL_SBI_TYPES > > > > > > DEFINE GCC5_RISCV64_ARCH =3D rv64gc > > > DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS =3D > DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u > ReferenceAcpiTable > > > -DEFINE GCC5_RISCV64_CC_FLAGS =3D > DEF(GCC5_RISCV_ALL_CC_FLAGS) > DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) > DEF(GCC5_RISCV_OPENSBI_TYPES) -march=3DDEF(GCC5_RISCV64_ARCH) > -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address > -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable > -fpack-struct=3D8 -mcmodel=3Dmedany -mabi=3Dlp64 -mno-relax > > > +DEFINE GCC5_RISCV64_CC_FLAGS =3D > DEF(GCC5_RISCV_ALL_CC_FLAGS) > DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) > DEF(GCC5_RISCV_OPENSBI_TYPES) -march=3DDEF(GCC5_RISCV64_ARCH) > -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address > -fno-asynchronous-unwind-tables -fno-unwind-tables > -Wno-unused-but-set-variable -fpack-struct=3D8 -mcmodel=3Dmedany > -mabi=3Dlp64 -mno-relax > > > DEFINE GCC5_RISCV64_DLINK_FLAGS =3D > DEF(GCC5_RISCV_ALL_DLINK_FLAGS) > -Wl,-melf64lriscv,--oformat=3Delf64-littleriscv,--no-relax > > > DEFINE GCC5_RISCV64_DLINK2_FLAGS =3D > DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) > > > DEFINE GCC5_RISCV64_ASM_FLAGS =3D > DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=3DDEF(GCC5_RISCV64_ARCH) > -mcmodel=3Dmedany -mabi=3Dlp64 > > > -- > > > 2.34.1 > > > > > > > > > > > > > >=20 >=20 >=20 >=20