From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0D236740040 for ; Thu, 25 Jan 2024 23:06:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D1yPPQkTwRAs9Wi8Bwr5nDphVcirg7j+i48ogfPHq4Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1706223994; v=1; b=MlG2w7UVja6qSqdIvcLNToBN9TrTIsLWY20FhxHmQSFQIPaVfdssT3d4+wYDYPkunhER1m0x GUkomKERJQKYOUQZaS4buw7cr7bDIS3vM4nT2nq6IbPf4thrVJhM3EsNRjyUnRK0nKDAN1c3byn TcXT1/opaltgOpN67Zqr4fuI= X-Received: by 127.0.0.2 with SMTP id VfUHYY7687511x5XsMcTwsSE; Thu, 25 Jan 2024 15:06:34 -0800 X-Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web11.781.1706223993293539648 for ; Thu, 25 Jan 2024 15:06:33 -0800 X-Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d746856d85so303125ad.0 for ; Thu, 25 Jan 2024 15:06:33 -0800 (PST) X-Gm-Message-State: DNJWT95v2iBODDyyttacLrHbx7686176AA= X-Google-Smtp-Source: AGHT+IEa6RmuLqeIMB14GcwS5L55e3K5KuiGsTz0cTEu9IL42rk+gJT8gQSPLxeaFcDIylvCpQvnqg== X-Received: by 2002:a17:902:c94d:b0:1d4:8be0:4494 with SMTP id i13-20020a170902c94d00b001d48be04494mr476254pla.125.1706223992539; Thu, 25 Jan 2024 15:06:32 -0800 (PST) X-Received: from localhost.localdomain ([24.17.138.83]) by smtp.gmail.com with ESMTPSA id jh1-20020a170903328100b001d752c4f180sm16779plb.94.2024.01.25.15.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 15:06:32 -0800 (PST) From: "Doug Flick via groups.io" To: devel@edk2.groups.io Cc: Doug Flick , Saloni Kasbekar , Zachary Clark-williams , "Doug Flick [MSFT]" Subject: [edk2-devel] [PATCH v2 06/15] NetworkPkg: Ip6Dxe: SECURITY PATCH CVE-2023-45231 Patch Date: Thu, 25 Jan 2024 13:54:48 -0800 Message-ID: <03b422eb7b3f88136810da4ed290d2e2374483fe.1706219324.git.doug.edk2@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dougflick@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MlG2w7UV; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Doug Flick REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4536 Bug Overview: PixieFail Bug #3 CVE-2023-45231 CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N CWE-125 Out-of-bounds Read Out-of-bounds read when handling a ND Redirect message with truncated options Change Overview: Adds a check to prevent truncated options from being parsed + // + // Cannot process truncated options. + // Cannot process options with a length of 0 as there is no Type field. + // + if (OptionLen < sizeof (IP6_OPTION_HEADER)) { + return FALSE; + } Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: Doug Flick [MSFT] --- NetworkPkg/Ip6Dxe/Ip6Option.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/Ip6Dxe/Ip6Option.c b/NetworkPkg/Ip6Dxe/Ip6Option.c index 199eea124dfe..8718d5d8756a 100644 --- a/NetworkPkg/Ip6Dxe/Ip6Option.c +++ b/NetworkPkg/Ip6Dxe/Ip6Option.c @@ -137,6 +137,14 @@ Ip6IsNDOptionValid ( return FALSE;=0D }=0D =0D + //=0D + // Cannot process truncated options.=0D + // Cannot process options with a length of 0 as there is no Type field.= =0D + //=0D + if (OptionLen < sizeof (IP6_OPTION_HEADER)) {=0D + return FALSE;=0D + }=0D +=0D Offset =3D 0;=0D =0D //=0D --=20 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114468): https://edk2.groups.io/g/devel/message/114468 Mute This Topic: https://groups.io/mt/103964981/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-