public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: rfc@edk2.groups.io, michael.d.kinney@intel.com,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Leif Lindholm <leif@nuviainc.com>,
	"Andrew Fish (afish@apple.com)" <afish@apple.com>
Subject: Re: [edk2-devel] [edk2-rfc] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024
Date: Fri, 24 May 2024 06:20:29 -0600	[thread overview]
Message-ID: <03b4513b-01f3-42d0-b271-2af69f54ef4e@bsdio.com> (raw)
In-Reply-To: <CO1PR11MB49295D09CD04BBC97AC27613D2192@CO1PR11MB4929.namprd11.prod.outlook.com>

There's a GitHub Project for this at 
https://github.com/orgs/tianocore/projects/5 which it looks like Michael 
Kubacki created last year. I suspect it's obsolete though, since it 
looks like the tasks haven't been updated recently.


-- 

Rebecca Cran


On 5/1/24 11:43 AM, Michael D Kinney wrote:
> Hello,
>
> I would like to propose that TianoCore move all code review from email
> based code reviews to GitHub Pull Requests based code reviews.
>
> The proposed date to switch would be immediately after the next stable
> tag which is currently scheduled for May 24, 2024.
>
> Updates to the following Wiki page would be required to describe the
> required process when using GitHub Pull Requests for all code review
> related activity.
>
>      https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
> A couple examples of the changes that would need to be documented are:
>
> * All contributors, maintainers, and reviewers must have GitHub IDs.
> * The commit message would no longer require Cc:, Reviewed-by:, Acked-by:
>    or Tested-by: tags.  The only required tag would be Signed-off-by.
> * The Pull Request submitter is required to invite the required
>    maintainers and reviewers to the pull request. This is the same
>    set of maintainers and reviewers that are required to be listed in
>    Cc: tags in today's process.
> * Maintainers are responsible for verifying that all conversations in
>    the code review are resolved and that all review approvals from the
>    required set of maintainers are present before setting the 'push' label.
>
>
> Please provide feedback
> 1) If you are not in favor of this change.
> 2) If you are not in favor of the proposed date of this change.
> 3) On the process changes you would like to see documented in the Wiki
>     pages related to using GitHub Pull Request based code reviews.
>
> There is some prototype work to automate/simplify some of the PR based
> code review process steps. Those could be added over time as resources
> are available to finish and support them.
>
> Best regards,
>
> Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119255): https://edk2.groups.io/g/devel/message/119255
Mute This Topic: https://groups.io/mt/106280281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-05-24 12:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 17:43 [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 Michael D Kinney
2024-05-01 18:12 ` Leif Lindholm
2024-05-01 23:19   ` Dionna Glaze via groups.io
2024-05-02 15:59     ` Brian J. Johnson
2024-05-02 16:09       ` Dionna Glaze via groups.io
2024-05-02 16:30       ` [edk2-rfc] " Michael D Kinney
2024-05-06 16:41   ` Leara, William via groups.io
2024-05-02  1:28 ` Rebecca Cran
2024-05-02 10:21   ` Leif Lindholm
2024-05-02  3:08 ` Michael Kubacki
2024-05-02 10:57   ` Leif Lindholm
2024-05-02 16:37     ` Michael D Kinney
2024-05-03 16:58       ` Michael Kubacki
2024-05-03 16:54     ` Michael Kubacki
2024-05-02  6:33 ` Marcin Juszkiewicz
2024-05-02 10:34   ` Leif Lindholm
2024-05-02 15:21     ` Michael Kubacki
2024-05-02 16:24       ` Michael D Kinney
2024-05-03 17:21         ` Michael Kubacki
2024-05-03 19:16           ` [edk2-rfc] " Michael D Kinney
2024-05-02  9:37 ` Ard Biesheuvel
2024-05-02 15:14   ` Michael Kubacki
2024-05-03  0:35     ` [edk2-rfc] " Rebecca Cran
2024-05-02 17:50 ` Pedro Falcato
2024-05-02 18:17   ` [edk2-rfc] " Michael D Kinney
2024-05-03 17:38     ` Pedro Falcato
2024-05-03 20:12       ` Michael D Kinney
2024-05-03 20:38         ` Michael D Kinney
2024-05-04  0:57           ` Michael Kubacki
2024-05-05 18:10             ` Pedro Falcato
2024-05-06 10:00           ` Ard Biesheuvel
2024-05-06 15:11             ` Michael D Kinney
2024-05-06 15:30               ` Ard Biesheuvel
2024-05-06 15:56                 ` Michael D Kinney
2024-05-06 16:09                   ` Ard Biesheuvel
2024-05-10 20:57       ` Brian J. Johnson
2024-05-15 17:03         ` Michael D Kinney
2024-05-24 12:20 ` Rebecca Cran [this message]
2024-05-24 14:53   ` [edk2-devel] [edk2-rfc] " Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03b4513b-01f3-42d0-b271-2af69f54ef4e@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox