From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0E43D8118D for ; Fri, 24 May 2024 12:20:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Kip+5l1+ka98Wv8SsFzTqZslZi3CMuBA4R35cGXHdVQ=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716553241; v=1; b=FoSt3Tf9R+R2vhf60vmb07E9PIaZkxzt9VtlGk32uHmB0oL/qi1S+5S6TSyuAPOLVJufndAB sKPf2UvmG5U4xSxX0dfjRS1kvCuTZjNm0Y8HB84bLnhxFvc1rR7LzChbFs7wqxh35iUarb2TfNR wchQyqMaSu2rHw5ROyRtJLLaFabLLHNI7hNmjUthUDzupZGHcPkhvMp7xESH8pw8tdo0YPS/ajX eP/6t5af3nKHE0xGD++489xPR2Gfu6Q7awWolbp6ZoMe04JrOt0k1ShksRiWEHfMJsexip5z8mv QwsGWtdLF0GzRbRgpJqEFcVRXU2iU4dVJstU5cKq6X0fQ== X-Received: by 127.0.0.2 with SMTP id mThOYY7687511xmqIaJoO35D; Fri, 24 May 2024 05:20:41 -0700 X-Received: from fout5-smtp.messagingengine.com (fout5-smtp.messagingengine.com [103.168.172.148]) by mx.groups.io with SMTP id smtpd.web11.14413.1716553240664494753 for ; Fri, 24 May 2024 05:20:40 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 03B431380136; Fri, 24 May 2024 08:20:40 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 24 May 2024 08:20:40 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeikedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnecujfgurhepkfffgggfuffvvehfhfgj tgfgsehtjeertddtvdejnecuhfhrohhmpeftvggsvggttggrucevrhgrnhcuoehrvggsvg gttggrsegsshguihhordgtohhmqeenucggtffrrghtthgvrhhnpeehhedtgffhieefudfg keeuueffvdfhheejgeffvdfgfeduhfekfeehudeludekfeenucffohhmrghinhepghhith hhuhgsrdgtohhmpdhgihhthhhusgdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 May 2024 08:20:38 -0400 (EDT) Message-ID: <03b4513b-01f3-42d0-b271-2af69f54ef4e@bsdio.com> Date: Fri, 24 May 2024 06:20:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-rfc] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: rfc@edk2.groups.io, michael.d.kinney@intel.com, "devel@edk2.groups.io" , Michael Kubacki Cc: Leif Lindholm , "Andrew Fish (afish@apple.com)" References: From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 24 May 2024 05:20:40 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: K3Mzrmkrq9mre19FdnqtaCYGx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=FoSt3Tf9; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none There's a GitHub Project for this at=20 https://github.com/orgs/tianocore/projects/5 which it looks like Michael=20 Kubacki created last year. I suspect it's obsolete though, since it=20 looks like the tasks haven't been updated recently. --=20 Rebecca Cran On 5/1/24 11:43 AM, Michael D Kinney wrote: > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > tag which is currently scheduled for May 24, 2024. > > Updates to the following Wiki page would be required to describe the > required process when using GitHub Pull Requests for all code review > related activity. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Develop= ment-Process > > A couple examples of the changes that would need to be documented are: > > * All contributors, maintainers, and reviewers must have GitHub IDs. > * The commit message would no longer require Cc:, Reviewed-by:, Acked-by: > or Tested-by: tags. The only required tag would be Signed-off-by. > * The Pull Request submitter is required to invite the required > maintainers and reviewers to the pull request. This is the same > set of maintainers and reviewers that are required to be listed in > Cc: tags in today's process. > * Maintainers are responsible for verifying that all conversations in > the code review are resolved and that all review approvals from the > required set of maintainers are present before setting the 'push' labe= l. > > > Please provide feedback > 1) If you are not in favor of this change. > 2) If you are not in favor of the proposed date of this change. > 3) On the process changes you would like to see documented in the Wiki > pages related to using GitHub Pull Request based code reviews. > > There is some prototype work to automate/simplify some of the PR based > code review process steps. Those could be added over time as resources > are available to finish and support them. > > Best regards, > > Mike -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119255): https://edk2.groups.io/g/devel/message/119255 Mute This Topic: https://groups.io/mt/106280281/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-