From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 976E581D07 for ; Tue, 8 Nov 2016 05:04:19 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55CF981236; Tue, 8 Nov 2016 13:04:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-85.phx2.redhat.com [10.3.116.85]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA8D4KHU008377; Tue, 8 Nov 2016 08:04:21 -0500 To: Ruiyu Ni , edk2-devel@ml01.01.org References: <20161108122928.53984-1-ruiyu.ni@intel.com> <20161108122928.53984-7-ruiyu.ni@intel.com> Cc: Jordan Justen From: Laszlo Ersek Message-ID: <03d5c67c-716e-eb37-3f80-494295fcbb9e@redhat.com> Date: Tue, 8 Nov 2016 14:04:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161108122928.53984-7-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 08 Nov 2016 13:04:22 +0000 (UTC) Subject: Re: [PATCH v2 6/9] OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 13:04:19 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/08/16 13:29, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index 66ee590..cc35630 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -389,6 +389,11 @@ Returns: > NULL); > ASSERT_EFI_ERROR (Status); > > + // > + // Dispatch deferred images after EndOfDxe event and ReadyToLock installation. > + // > + EfiBootManagerDispatchDeferredImages (); > + > PlatformInitializeConsole (gPlatformConsole); > PcdStatus = PcdSet16S (PcdPlatformBootTimeOut, > GetFrontPageTimeoutFromQemu ()); > Can you please add a note to the commit message that, if the platform installs EfiDxeSmmReadyToLockProtocol, then the deferred images must not be dispatched prior to that either, not just prior to EndOfDxe? Simultaneously, I propose the following subject (72 chars): OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe/ReadyToLock No need to repost just because of this; the commit message can be updated before you commit the series. With the commit message update: Reviewed-by: Laszlo Ersek Thank you! Laszlo