From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 131B8740032 for ; Tue, 30 Jan 2024 01:21:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PDg2XXXCLEqfPJ5MV3w07mcPQMCX5aGcMB0asTk5FOA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1706577681; v=1; b=SRehLj7k5bhom1PCs4FQbGECKPiirbZSLLxC+VEfv5MklD4irdX4HboCEkt0J4PHcm88ZVeh qE4TeNEMlllhYNsuGE06RXeafD4kpK+9AB9h+sg6UoPwNj0Imx9XyShHvdI4Tow9oDPKSmJeBXF 9OClaCxiDJdmU6fcEdb1NObA= X-Received: by 127.0.0.2 with SMTP id SLfnYY7687511xUxZXMZyf6p; Mon, 29 Jan 2024 17:21:21 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.8349.1706577680441764606 for ; Mon, 29 Jan 2024 17:21:21 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id CA699A32E045 for ; Tue, 30 Jan 2024 09:21:17 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id A39C4A32E00F for ; Tue, 30 Jan 2024 09:21:17 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id B40D3A32E053 for ; Tue, 30 Jan 2024 09:21:14 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 30 Jan 2024 09:21:12 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: , , , References: <20240128134816.236973-1-dhaval@rivosinc.com> <20240128134816.236973-2-dhaval@rivosinc.com> In-Reply-To: <20240128134816.236973-2-dhaval@rivosinc.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY1IDEvMV0gTWRlTW9kdWxlUGtnL0FjcGlUYWJsZUR4ZTogUHJlZmVyIHhEU0RUIG92ZXIgRFNEVCB3aGVuIGluc3RhbGxpbmcgdGFibGVz?= Date: Tue, 30 Jan 2024 09:21:13 +0800 Message-ID: <03d701da531a$9dbc2820$d9347860$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJ1X4weabpdeYlK69vIleSKkw/llAK6Xh1er6WjB2A= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RMKdlkSCj0edCm8Nytn7SDiEx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SRehLj7k; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This version is good to me. Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Dhaval > Sharma > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA1=D4=C228=C8=D5 21:39 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; > dandan.bi@intel.com; pedro.falcato@gmail.com; chasel.chiu@intel.com > =D6=F7=CC=E2: [edk2-devel] [PATCH v5 1/1] MdeModulePkg/AcpiTableDxe: Pref= er > xDSDT over DSDT when installing tables >=20 > As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available, > it should be used first. Handle required flow when xDSDT > is absent or present. >=20 > Test: Tested on RISCV64 Qemu platform with xDSDT and booted to > linux kernel. >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Dandan Bi > Cc: Pedro Falcato > Cc: devel@edk2.groups.io > Signed-off-by: Dhaval Sharma > Acked-by: Chasel Chiu > --- >=20 > Notes: > v5: > - If DSDT is not found, throw error and continue to build other table= s > v4: > - Fix typos and commit message adding more clarity to patch subject > v3: > - Added description of ACPI spec clarification based on which this patch is > created > - Optimizing if-else flow > v2: > - Added proper indentation for else if >=20 > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 24 > ++++++++++++++------ > 1 file changed, 17 insertions(+), 7 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > index e09bc9b704f5..3879e10b3349 100644 > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > @@ -1892,14 +1892,24 @@ InstallAcpiTableFromHob ( > } > } >=20 > - if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->Dsdt !=3D 0) { > + // > + // First check if xDSDT is available, as that is preferred as pe= r > + // ACPI Spec 6.5+ Table 5-9 X_DSDT definition > + // > + if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->XDsdt !=3D 0) { > + TableToInstall =3D (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->XDsdt; > + } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->Dsdt !=3D 0) { > TableToInstall =3D (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->Dsdt; > - Status =3D AddTableToList (AcpiTableInstance, > TableToInstall, TRUE, Version, TRUE, &TableKey); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to > add ACPI table DSDT\n")); > - ASSERT_EFI_ERROR (Status); > - break; > - } > + } else { > + DEBUG ((DEBUG_ERROR, "DSDT table not found\n")); > + continue; > + } > + > + Status =3D AddTableToList (AcpiTableInstance, TableToInstall, TR= UE, > Version, TRUE, &TableKey); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to add > ACPI table DSDT\n")); > + ASSERT_EFI_ERROR (Status); > + break; > } > } > } > -- > 2.39.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114754): https://edk2.groups.io/g/devel/message/114754 Mute This Topic: https://groups.io/mt/104045452/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-