From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 923DA81E84 for ; Thu, 19 Jan 2017 02:30:22 -0800 (PST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 18E28C05AA52; Thu, 19 Jan 2017 10:30:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.phx2.redhat.com [10.3.116.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0JAUJPe028925; Thu, 19 Jan 2017 05:30:20 -0500 To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Fan, Jeff" , "Tian, Feng" , "Ni, Ruiyu" , "Ma, Maurice" , "Agyeman, Prince" , "Steele, Kelly" , Leif Lindholm References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B818420@shsmsx102.ccr.corp.intel.com> Cc: "Gao, Liming" , Ard Biesheuvel From: Laszlo Ersek Message-ID: <03db0f4d-610f-7cbf-76d1-a85938833c3d@redhat.com> Date: Thu, 19 Jan 2017 11:30:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B818420@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 19 Jan 2017 10:30:23 +0000 (UTC) Subject: Re: [PATCH 0/7] Make the event empty function in UefiLib public X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 10:30:22 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi Star, On 01/19/17 11:27, Zeng, Star wrote: > Hi, > > Please kindly help take a review to the patches. :) > > So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPkg. I didn't ignore the series, it's just that I don't co-maintain any of the packages being modified. Thanks Laszlo > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 17, 2017 3:09 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; Kinney, Michael D ; Fan, Jeff ; Tian, Feng ; Ni, Ruiyu ; Ma, Maurice ; Agyeman, Prince ; Steele, Kelly ; Leif Lindholm ; Ard Biesheuvel ; Laszlo Ersek > Subject: [PATCH 0/7] Make the event empty function in UefiLib public > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298 > > We found there are many event empty functions in EDK2 code base, these patches are to make the event empty function in UefiLib public, then this event empty function can be used to remove the duplication in drivers and other libraries. > > In CorebootPayloadPkg/QuarkPlatformPkg/ArmPlatformPkg, EfiEventGroupSignal from UefiLib can be used to remove the duplication of event empty function. > > Cc: Liming Gao > Cc: Michael Kinney > Cc: Jeff Fan > Cc: Feng Tian > Cc: Ruiyu Ni > Cc: Maurice Ma > Cc: Prince Agyeman > Cc: Kelly Steele > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > > Star Zeng (7): > MdePkg UefiLib: Make the event empty function public > IntelFrameworkPkg UefiLib: Make the event empty function public > MdeModulePkg: Use EfiEventEmptyFunction from UefiLib > IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib > CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib > QuarkPlatformPkg: Use EfiEventGroupSignal from UefiLib > ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib > > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++----------------- .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- > .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > .../Universal/BdsDxe/BdsEntry.c | 20 +---------- > .../Library/FrameworkUefiLib/UefiLib.c | 42 +++++++++++----------- > .../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +---------- > .../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +-- > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 23 ++---------- > MdeModulePkg/Core/Dxe/DxeMain.h | 18 +--------- > MdeModulePkg/Core/Dxe/Event/Event.c | 4 +-- > MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 19 ++-------- .../Universal/Console/ConSplitterDxe/ConSplitter.c | 22 ++---------- .../Universal/Console/ConSplitterDxe/ConSplitter.h | 18 +--------- > .../Universal/DriverSampleDxe/DriverSample.c | 20 ++--------- > .../Universal/SetupBrowserDxe/Presentation.c | 20 ++--------- > MdePkg/Include/Library/UefiLib.h | 18 +++++++++- > MdePkg/Library/UefiLib/UefiLib.c | 42 +++++++++++----------- > MdePkg/Library/UefiLib/UefiLibInternal.h | 20 +---------- > MdePkg/Library/UefiLib/UefiNotTiano.c | 10 +++--- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > 21 files changed, 91 insertions(+), 321 deletions(-) > > -- > 2.7.0.windows.1 >