From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6B57774003B for ; Tue, 21 Nov 2023 14:14:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UXmecKbAiviw0OcjH7a2vTZrg5W/Ptk42/SSxDc07j0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1700576083; v=1; b=hGpXP9TGVqBFdEbv8G9KOhZBt0nT5KLu0thyVj4LMLULgF56w0B2/jeCtMVwcTQj/NtcH9S4 3aibIzfH5Wycw4sKVG0pSJcW/C5obeVdbFaYWj+rkAFIluFbiBVDLmnK1VYOk3zlZIa1meBieJx PvtJe659BhYpM4LnB4cQB/GQ= X-Received: by 127.0.0.2 with SMTP id hMJxYY7687511x0VKt0vzUQK; Tue, 21 Nov 2023 06:14:43 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.41528.1700576081604957174 for ; Tue, 21 Nov 2023 06:14:42 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 773CFA32E108 for ; Tue, 21 Nov 2023 22:14:38 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 655ABA32E0A4 for ; Tue, 21 Nov 2023 22:14:38 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id A3C91A32E0FB for ; Tue, 21 Nov 2023 22:14:35 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.93.194.54]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 21 Nov 2023 22:14:29 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.93.194.54 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , "'Laszlo Ersek'" , "'Michael Kinney'" , , , , "'Jeff Brasen'" Cc: "'nd'" References: <61F7F1EE-02C3-4DF9-AD8D-0006829FB99E@arm.com> In-Reply-To: <61F7F1EE-02C3-4DF9-AD8D-0006829FB99E@arm.com> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IGVkazItc3RhYmxlMjAyMzExOiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSF0gRHluYW1pY1RhYmxlc1BrZzogRml4IEVURSBfVUlEIENyZWF0aW9u?= Date: Tue, 21 Nov 2023 22:14:31 +0800 Message-ID: <03f101da1c85$0be276f0$23a764d0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQHSHaRJAMnXqR6ZrjRZLdzoroBDOrCUzr3Q Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hSHtA7psXfiybLVTcLybJIpRx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hGpXP9TG; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sami: I have merged it. Please check.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Sami > Mujawar > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B411=E6=9C=8821=E6=97=A5= 19:57 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; 'Laszl= o Ersek' > ; 'Michael Kinney' ; > devel@edk2.groups.io; ashishsingha@nvidia.com; quic_llindhol@quicinc.com; > ardb+tianocore@kernel.org; Jeff Brasen (jbrasen@nvidia.com) > > =E6=8A=84=E9=80=81: nd > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: edk2-stable202311: Re: [edk2-= devel] [PATCH] > DynamicTablesPkg: Fix ETE _UID Creation >=20 > Hi Liming, >=20 > =EF=BB=BFOn 21/11/2023, 01:05, "gaoliming" > wrote: >=20 >=20 > Sami: > I am OK to merge this patch for this stable bug. I will add push label fo= r > https://github.com/tianocore/edk2/pull/5061 > > [SAMI] Thank you for picking this patch for the stable tag. Apparently, t= he > patch does not seem to have merged. > I am not sure if you have already applied the push label. Please let me k= now if > there are any issues that I can help with. >=20 > Regards, >=20 > Sami Mujawar >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Sami Mujawar > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B411=E6=9C=8821=E6=97= =A5 0:07 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Laszlo Ersek >; > Liming Gao (Byosoft address) > > >; Michael > Kinney >; > > devel@edk2.groups.io ; > ashishsingha@nvidia.com ; > quic_llindhol@quicinc.com ; > > ardb+tianocore@kernel.org ; > jbrasen@nvidia.com > > =E6=8A=84=E9=80=81: nd@arm.com > > =E4=B8=BB=E9=A2=98: edk2-stable202311: Re: [edk2-devel] [PATCH] Dynamic= TablesPkg: Fix > > ETE _UID Creation > > > > Hi Laszlo, Liming, Mike, > > > > Please see my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar > > > > On 17/11/2023 09:20 am, Laszlo Ersek wrote: > > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > > >> Just like CPU _UID, ETE UID also needs to be unique so > > >> use AcpiProcessorUid instead of CpuName > > >> > > >> Signed-off-by: Ashish Singhal > > > >> --- > > >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 > > ++++- > > >> 1 file changed, 4 insertions(+), 1 deletion(-) > > > Is this a fixup for the recent feature > > > > > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > > > https://edk2.groups.io/g/devel/message/108996 > > > > > > > ? > > > > > > If so, then I *think* this qualifies to be merged during the hard > > > feature freeze (+Liming +Mike), but: > > > > [SAMI] I raised a bugzilla for this issue at > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4600 > > > > > and have also created a pull request at > > https://github.com/tianocore/edk2/pull/5061 > . > > > > This patch has also passed the CI checks when I did a draft pull reques= t. > > > > I am not sure if I can apply the push label as we are in the code freez= e > > stage. > > > > Can you advise on how to proceed, please? > > > > [/SAMI] > > > > > - I think we should have a "Fixes:" tag in the commit message (for > > > pointing out the commit that should have contained the code being > > > added/updated now) > > > > > > - I think we should have a BZ too (also linked into the commit messag= e). > > > > > > Laszlo > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111547): https://edk2.groups.io/g/devel/message/111547 Mute This Topic: https://groups.io/mt/102728858/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-