public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
@ 2023-11-21 11:56 Sami Mujawar
  2023-11-21 14:14 ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2023-11-21 11:56 UTC (permalink / raw)
  To: gaoliming, 'Laszlo Ersek', 'Michael Kinney',
	devel@edk2.groups.io, ashishsingha@nvidia.com,
	quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
	Jeff Brasen (jbrasen@nvidia.com)
  Cc: nd

Hi Liming,

On 21/11/2023, 01:05, "gaoliming" <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>> wrote:


Sami:
I am OK to merge this patch for this stable bug. I will add push label for https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061> 
[SAMI] Thank you for picking this patch for the stable tag. Apparently, the patch does not seem to have merged. 
I am not sure if you have already applied the push label. Please let me know if there are any issues that I can help with.

Regards,

Sami Mujawar

Thanks
Liming
> -----邮件原件-----
> 发件人: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> 发送时间: 2023年11月21日 0:07
> 收件人: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>; Liming Gao (Byosoft address)
> <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>; Michael Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>;
> devel@edk2.groups.io <mailto:devel@edk2.groups.io>; ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>; quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>;
> ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>; jbrasen@nvidia.com <mailto:jbrasen@nvidia.com>
> 抄送: nd@arm.com <mailto:nd@arm.com>
> 主题: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix
> ETE _UID Creation
> 
> Hi Laszlo, Liming, Mike,
> 
> Please see my response inline marked [SAMI].
> 
> Regards,
> 
> Sami Mujawar
> 
> On 17/11/2023 09:20 am, Laszlo Ersek wrote:
> > On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
> >> Just like CPU _UID, ETE UID also needs to be unique so
> >> use AcpiProcessorUid instead of CpuName
> >>
> >> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>>
> >> ---
> >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5
> ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> > Is this a fixup for the recent feature
> >
> > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
> > https://edk2.groups.io/g/devel/message/108996 <https://edk2.groups.io/g/devel/message/108996>
> >
> > ?
> >
> > If so, then I *think* this qualifies to be merged during the hard
> > feature freeze (+Liming +Mike), but:
> 
> [SAMI] I raised a bugzilla for this issue at
> https://bugzilla.tianocore.org/show_bug.cgi?id=4600 <https://bugzilla.tianocore.org/show_bug.cgi?id=4600>
> 
> and have also created a pull request at
> https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061>.
> 
> This patch has also passed the CI checks when I did a draft pull request.
> 
> I am not sure if I can apply the push label as we are in the code freeze
> stage.
> 
> Can you advise on how to proceed, please?
> 
> [/SAMI]
> 
> > - I think we should have a "Fixes:" tag in the commit message (for
> > pointing out the commit that should have contained the code being
> > added/updated now)
> >
> > - I think we should have a BZ too (also linked into the commit message).
> >
> > Laszlo
> >









-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111543): https://edk2.groups.io/g/devel/message/111543
Mute This Topic: https://groups.io/mt/102720225/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: 回复: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
@ 2023-11-21 14:16 Sami Mujawar
  0 siblings, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2023-11-21 14:16 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io, 'Laszlo Ersek',
	'Michael Kinney', ashishsingha@nvidia.com,
	quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
	Jeff Brasen (jbrasen@nvidia.com)
  Cc: nd

Hi Liming,

Thanks a lot. I can see it in the mainline.

Regards,

Sami Mujawar

On 21/11/2023, 14:15, "gaoliming" <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>> wrote:


Sami:
I have merged it. Please check. 


Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> 代表 Sami
> Mujawar
> 发送时间: 2023年11月21日 19:57
> 收件人: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>; 'Laszlo Ersek'
> <lersek@redhat.com <mailto:lersek@redhat.com>>; 'Michael Kinney' <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>;
> devel@edk2.groups.io <mailto:devel@edk2.groups.io>; ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>; quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>;
> ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>; Jeff Brasen (jbrasen@nvidia.com <mailto:jbrasen@nvidia.com>)
> <jbrasen@nvidia.com <mailto:jbrasen@nvidia.com>>
> 抄送: nd <nd@arm.com <mailto:nd@arm.com>>
> 主题: Re: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH]
> DynamicTablesPkg: Fix ETE _UID Creation
> 
> Hi Liming,
> 
> On 21/11/2023, 01:05, "gaoliming" <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>
> <mailto:gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>> wrote:
> 
> 
> Sami:
> I am OK to merge this patch for this stable bug. I will add push label for
> https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061>
> <https://github.com/tianocore/edk2/pull/5061> <https://github.com/tianocore/edk2/pull/5061&gt;>
> [SAMI] Thank you for picking this patch for the stable tag. Apparently, the
> patch does not seem to have merged.
> I am not sure if you have already applied the push label. Please let me know if
> there are any issues that I can help with.
> 
> Regards,
> 
> Sami Mujawar
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>
> <mailto:sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>>
> > 发送时间: 2023年11月21日 0:07
> > 收件人: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> <mailto:lersek@redhat.com <mailto:lersek@redhat.com>>>;
> Liming Gao (Byosoft address)
> > <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> <mailto:gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>>; Michael
> Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>>;
> > devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>;
> ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> <mailto:ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>>;
> quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com> <mailto:quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>>;
> > ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org> <mailto:ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>>;
> jbrasen@nvidia.com <mailto:jbrasen@nvidia.com> <mailto:jbrasen@nvidia.com <mailto:jbrasen@nvidia.com>>
> > 抄送: nd@arm.com <mailto:nd@arm.com> <mailto:nd@arm.com <mailto:nd@arm.com>>
> > 主题: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix
> > ETE _UID Creation
> >
> > Hi Laszlo, Liming, Mike,
> >
> > Please see my response inline marked [SAMI].
> >
> > Regards,
> >
> > Sami Mujawar
> >
> > On 17/11/2023 09:20 am, Laszlo Ersek wrote:
> > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
> > >> Just like CPU _UID, ETE UID also needs to be unique so
> > >> use AcpiProcessorUid instead of CpuName
> > >>
> > >> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>
> <mailto:ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>>>
> > >> ---
> > >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5
> > ++++-
> > >> 1 file changed, 4 insertions(+), 1 deletion(-)
> > > Is this a fixup for the recent feature
> > >
> > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
> > > https://edk2.groups.io/g/devel/message/108996 <https://edk2.groups.io/g/devel/message/108996>
> <https://edk2.groups.io/g/devel/message/108996> <https://edk2.groups.io/g/devel/message/108996&gt;>
> > >
> > > ?
> > >
> > > If so, then I *think* this qualifies to be merged during the hard
> > > feature freeze (+Liming +Mike), but:
> >
> > [SAMI] I raised a bugzilla for this issue at
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4600 <https://bugzilla.tianocore.org/show_bug.cgi?id=4600>
> <https://bugzilla.tianocore.org/show_bug.cgi?id=4600> <https://bugzilla.tianocore.org/show_bug.cgi?id=4600&gt;>
> >
> > and have also created a pull request at
> > https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061>
> <https://github.com/tianocore/edk2/pull/5061> <https://github.com/tianocore/edk2/pull/5061&gt;>.
> >
> > This patch has also passed the CI checks when I did a draft pull request.
> >
> > I am not sure if I can apply the push label as we are in the code freeze
> > stage.
> >
> > Can you advise on how to proceed, please?
> >
> > [/SAMI]
> >
> > > - I think we should have a "Fixes:" tag in the commit message (for
> > > pointing out the commit that should have contained the code being
> > > added/updated now)
> > >
> > > - I think we should have a BZ too (also linked into the commit message).
> > >
> > > Laszlo
> > >
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 











-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111548): https://edk2.groups.io/g/devel/message/111548
Mute This Topic: https://groups.io/mt/102728858/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 14:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 11:56 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Sami Mujawar
2023-11-21 14:14 ` 回复: " gaoliming via groups.io
  -- strict thread matches above, loose matches on Subject: below --
2023-11-21 14:16 Sami Mujawar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox