From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mx.groups.io with SMTP id smtpd.web12.7642.1603356304362693034 for ; Thu, 22 Oct 2020 01:45:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=l01SizLL; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 216.228.121.65, mailfrom: jonathanh@nvidia.com) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 22 Oct 2020 01:44:51 -0700 Received: from [10.26.45.122] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 22 Oct 2020 08:44:57 +0000 Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Retry device slot init on failure To: "Luo, Heng" , "Wu, Hao A" , "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "Ni, Ray" References: From: Jon Hunter Message-ID: <040616b6-c7e9-d28d-69ac-bccb406d4730@nvidia.com> Date: Thu, 22 Oct 2020 09:44:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Return-Path: jonathanh@nvidia.com X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603356291; bh=ixsBDESOBLfVaU/cTvP9oaew1Vdy3/Ry44utoIym5lo=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=l01SizLLD4WMCB4g5d6sofpK/1hD/xNsuS2eXgcdU8BHX6bjMyol5dnvfCx0fJhx+ mG00j1kxLt7M4b+x7sM5FPVik6QA+SquhxAoNb5+vPI2ggfFYudYYQxSxKjM6rBZTK Q6/mHPk9nD+hxIDr9sE3Hc995c4xUsxKpvt9TS7KyUIJg8ztYb4hwKP3IHwdiYANXL bQxA0c5DH+an7mDjUZBbjrKBOL1N9tIvmRdesG8Sz4vYSwuexgbLIoQpNR2o2d+5ax jDNQoQdw6zMR40FEpgyaO4UaL+3SgdFDCHRk9YOMEVCNJIU+Ze5BA/LVGDAjoonQZs OTIYYQ5TvdbVA== Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Heng, On 22/10/2020 04:01, Luo, Heng wrote: > Hi Hao, > I applying this patch, it cannot fix BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3007. Can you elaborate more on why that is? Unfortunately, your patch does not work for the scenario we are testing. In your case does the bad USB device never enumerate even on the 2nd attempt? If so, then maybe we can apply your patch to do the disable slot and in our patch we just try the device init again once, without calling the slot disable because that is handled by your patch. Cheers Jon -- nvpublic