From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web11.12066.1679701830608203580 for ; Fri, 24 Mar 2023 16:50:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=X2zyHkYu; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 47FDD3200974; Fri, 24 Mar 2023 19:50:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 24 Mar 2023 19:50:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679701828; x=1679788228; bh=CBDxw0a6MWueGHYZ/QraaP4Dvul+DzXoK8c KIKmMRIU=; b=X2zyHkYu7IFgmuU+vMwQ2/EFXS70Iclw0knwLar3Id8HMxX3JX8 revc6plRrwlXyAXrua8sL23K062A6m9AYcQ7h4HGZZLszG/Kyq+8x+Q780UpKgMU pQVMiDus2XCLC1Fk9Vd9TKWO2jF5epLaL6jBNav94PMNWQEy3gxBUwUlo9ZGq0fS HGUR3cb5CVQum+nHIwJerZLDyUfDMYBbnZh4bSIeJeUzGc+3cUfhNJcig0UrphMS ZKoKhiPcwjYfyvzRHLA7iUusJlVjnZzPZgEgten0cejRy/QKkssfrMvXKQ3QHdM9 tb3gVLqKJyWA6Qjmup6QBapsXowVMvC309Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679701828; x=1679788228; bh=CBDxw0a6MWueGHYZ/QraaP4Dvul+DzXoK8c KIKmMRIU=; b=T2faRF8BkiHkTaiE1ugCpW7vez6/I5B9m8KR9fTMLnXZBqKM3W4 4y6/UMtlVjAdv7PfB4ubsNu1iSWEi9dwgir4wI5cy9ab/gl+ZQ23RqlJ23z8rEcM ftVce5h4ZCBYMF6mGrbGhn8e+wnSMnHyFguUs0s4V20uilOzvs0DadXasqgqi9K8 g7yOoEfUS26wILiuCkkBtGqy4V1rlHXfvFmLLXh5klud4NaY50CkBG/4VmhE1W9o F68HGhRY18vjJoVFgOT4KhcTwzNXg4k4ONTAHAlYaNQqoe+Sph95jIto8bXM2sdb af6NZ2qLbHmmnUAqk5iBL5SPCdc4kjM571A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegjedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 19:50:27 -0400 (EDT) Message-ID: <0412d6e6-f065-da79-f388-f2463d219902@bsdio.com> Date: Fri, 24 Mar 2023 17:50:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v7 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Bob Feng , Liming Gao , Michael D Kinney , Sean Brogan , Yuwei Chen References: <20230324223034.1560-1-mikuback@linux.microsoft.com> <20230324223034.1560-3-mikuback@linux.microsoft.com> From: "Rebecca Cran" In-Reply-To: <20230324223034.1560-3-mikuback@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran On 3/24/23 4:30 PM, Michael Kubacki wrote: > From: Michael Kubacki > > Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ > pasted into BaseTools/Source/C/VfrCompile/Pccts/. > > The code contains tab characters instead of spaces. > > PatchCheck.py gives an error on modifications to files that > contain tabs. > > The goal of my upcoming change there is not to mix tabs and spaces > but to fix a bug while preserving its current formatting characters. > > This change adds that directory to the pre-existing list of > directories in which tab checks are ignored in PatchCheck.py > and also updates the check for makefiles to check for *.makefile: > this allows {header,footer,app,lib}.makefile in > BaseTools/Source/C/Makefiles to be detected and avoid having > PatchCheck.py complain about tab characters. > > The check for "Makefile" is updated to be case-insensitive since > there are some Makefiles named 'makefile' instead of 'Makefile'. > > Co-authored-by: Rebecca Cran > Cc: Bob Feng > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Yuwei Chen > Signed-off-by: Michael Kubacki > Reviewed-by: Liming Gao > Reviewed-by: Michael D Kinney > --- > BaseTools/Scripts/PatchCheck.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py > index fcdabfc8acea..5d17d99a12ef 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -383,7 +383,10 @@ class GitDiffCheck: > self.force_crlf = False > self.force_notabs = False > if os.path.basename(self.filename) == 'GNUmakefile' or \ > - os.path.basename(self.filename) == 'Makefile': > + os.path.basename(self.filename).lower() == 'makefile' or \ > + os.path.splitext(self.filename)[1] == '.makefile' or \ > + self.filename.startswith( > + 'BaseTools/Source/C/VfrCompile/Pccts/'): > self.force_notabs = False > elif len(line.rstrip()) != 0: > self.format_error("didn't find diff command")