From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 609957803CE for ; Tue, 7 May 2024 01:12:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6rf3si+t4y9t4s9r2wZsHDsR1pT9FWxnFpXxyW6c3TQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1715044321; v=1; b=ipi/kCJPoAvUcCrhNbvG1mdsQI+DvHFMe4m3JWNaDVn9hKQmbV5qYmdN1lKnAV9k2DKJ5PkO YEeLcD+gGNk+Aunto5RKBYC+oc3WVqD8H8uIDVuEvznarkVmI4wzZkoWGmHB8DsKQ/C0/6FgTMS YLHXm1JJN1rwnyQ2KvmTB6NxukaMhjsUwlDGQOMfxvjhnIZb/WpsdXhd8pFnvbTXQ1jtp2kL2yn C9SK1wDlr+iJfzJW5XIlqHIdK43vukB51mj8OK/muYTdrgUyBGbWoZlvPgHv9OQhlOuE1OYUxL/ Nh7YS8BCAy3uY7diOV/YWuVPCuIYywrcw+FnYKoVPiPyg== X-Received: by 127.0.0.2 with SMTP id rw9TYY7687511xlQg8itdUKN; Mon, 06 May 2024 18:12:01 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.1082.1715044314965960451 for ; Mon, 06 May 2024 18:11:56 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id A7164A32E1EB for ; Tue, 7 May 2024 09:11:52 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 8DC6AA32E1E9 for ; Tue, 7 May 2024 09:11:52 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id F0A29A32E0E5 for ; Tue, 7 May 2024 09:11:48 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 07 May 2024 09:11:46 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Shih, More'" , "'Cai, Xianglei'" , Cc: "'Ni, Ray'" , "'Lewandowski, Krzysztof'" , "'Huang, Jenny'" References: <23b74af38dddeff43d19da4e6de82ed1ae7b4ed8.1713164057.git.xianglei.cai@intel.com> <01dd01da8f1a$8eb0bd00$ac123700$@byosoft.com.cn> <021001da97b5$ea6f04f0$bf4d0ed0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYyIDEvMV0gTWRlTW9kdWxlUGtnL1hoY2lEeGU6IFJlc2V0IGVuZHBvaW50IHdoaWxlIFVTQiBUcmFuc2FjdGlvbiBlcnJvcg==?= Date: Tue, 7 May 2024 09:11:47 +0800 Message-ID: <042901daa01b$88d0fe10$9a72fa30$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJw/gOq2/7eq0WBWVaWK72V6LPrpQF82+UCAisyoWoBuBYk6gKbU2BYAcRBgiMCta1IbQI4hcAZr+jLmSA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 06 May 2024 18:11:56 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TE1KYuZDMGWxNSGCJLBA5s6wx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_042A_01DAA05E.96F6AF10" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="ipi/kCJP"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io ------=_NextPart_000_042A_01DAA05E.96F6AF10 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable I will merge it this week.=20 =20 =B7=A2=BC=FE=C8=CB: Shih, More =20 =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA5=D4=C26=C8=D5 11:34 =CA=D5=BC=FE=C8=CB: Cai, Xianglei ; gaoliming ; devel@edk2.groups.io =B3=AD=CB=CD: Ni, Ray ; Lewandowski, Krzysztof ; Huang, Jenny =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset e= ndpoint while USB Transaction error =20 Hi Gaoliming, =20 Could you help push the PR ? =20 BR, More Shih _____ =20 From: Cai, Xianglei > Sent: Friday, April 26, 2024 5:13 PM To: gaoliming >= ; devel@edk2.groups.io > Cc: Ni, Ray >; Lewandowski, Krzysztof >; Huang, Jenny >; Shih, More > Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error=20 =20 I have no access to push PR. But I tried with my personal fork, it can pass CI. Thanks, Xianglei -----Original Message----- From: gaoliming >=20 Sent: Friday, April 26, 2024 4:44 PM To: devel@edk2.groups.io ; Cai, Xianglei > Cc: Ni, Ray >; Lewandowski, Krzysztof >; Huang, Jenny >; Shih, More > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Re= set endpoint while USB Transaction error Can you create PR for this patch? If it passes CI, I will add push label.= =20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io > =B4=FA=B1=ED Xianglei= Cai > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA4=D4=C225=C8=D5 17:58 > =CA=D5=BC=FE=C8=CB: gaoliming >; devel@edk2.groups.io =20 > =B3=AD=CB=CD: Ni, Ray >; Lewa= ndowski, Krzysztof=20 > >; Huang, Jenny=20 > >; Shih, More > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset= =20 > endpoint while USB Transaction error >=20 > Hi @gaoliming >=20 > Could you provide the eta when the patch can be merged? >=20 > Thanks, > Xianglei >=20 > -----Original Message----- > From: Cai, Xianglei > Sent: Thursday, April 18, 2024 4:59 PM > To: gaoliming >; devel@edk2.groups.io =20 > Cc: Ni, Ray >; Lewandowski, Krzysztof=20 > >; Huang, Jenny=20 > >; Shih, More > > Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset=20 > endpoint while USB Transaction error >=20 > Hi Liming, >=20 > Could you help pick the change to the master branch? >=20 > Thanks, > Xianglei >=20 > -----Original Message----- > From: gaoliming > > Sent: Monday, April 15, 2024 5:52 PM > To: devel@edk2.groups.io ; Cai, Xianglei > > Cc: Ni, Ray >; Lewandowski, Krzysztof=20 > >; Huang, Jenny=20 > >; Shih, More > > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: = Reset=20 > endpoint while USB Transaction error >=20 > Reviewed-by: Liming Gao > >=20 > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io = > =B4=FA=B1=ED Xianglei > Cai > > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA4=D4=C215=C8=D5 14:55 > > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io = =20 > > =B3=AD=CB=CD: Xianglei Cai >; Ray Ni=20 > > >; Liming Gao >; Krzysztof=20 > > Lewandowski >; Jenny Huang=20 > > >; More Shih > > > =D6=F7=CC=E2: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset > endpoint > > while USB Transaction error > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4556 > > > > Based on XHCI spec 4.8.3, software should do the reset endpoint=20 > > while USB Transaction occur. > > Add the error code for USB Transaction error since UEFI spec don't=20 > > have the related definition. > > > > Cc: Ray Ni > > > Cc: Liming Gao > > > Cc: Krzysztof Lewandowski > > Cc: Jenny Huang > > > Cc: More Shih > > > Signed-off-by: Xianglei Cai > > > Reviewed-by: Krzysztof Lewandowski > > > --- > > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 5 ++++- > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 ++++-=20 > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++++++ > > 3 files changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > index f4e61d223c1b..cf6b32959e68 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > @@ -825,7 +825,10 @@ XhcTransfer ( > > *TransferResult =3D Urb->Result; > > *DataLength =3D Urb->Completed; > > > > - if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D > > EFI_USB_ERR_BABBLE)) { > > + // > > + // Based on XHCI spec 4.8.3, software should do the reset=20 > > + endpoint > while > > USB Transaction occur. > > + // > > + if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult = =3D=3D > > EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D > > EDKII_USB_ERR_TRANSACTION)) { > > ASSERT (Status =3D=3D EFI_DEVICE_ERROR); > > RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, Urb); > > if (EFI_ERROR (RecoveryStatus)) { diff --git=20 > > a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > index 5d735008ba31..a97ed44dbfc3 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > @@ -1192,8 +1192,11 @@ XhcCheckUrbResult ( > > DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: ERR_BUFFER! > > Completecode =3D %x\n", EvtTrb->Completecode)); > > goto EXIT; > > > > + // > > + // Based on XHCI spec 4.8.3, software should do the reset=20 > > + endpoint > > while USB Transaction occur. > > + // > > case TRB_COMPLETION_USB_TRANSACTION_ERROR: > > - CheckedUrb->Result |=3D EFI_USB_ERR_TIMEOUT; > > + CheckedUrb->Result |=3D EDKII_USB_ERR_TRANSACTION; > > CheckedUrb->Finished =3D TRUE; > > DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: > > TRANSACTION_ERROR! Completecode =3D %x\n", EvtTrb->Completecode)); > > goto EXIT; > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h > > index 7c85f7993b5c..e606e212a1d3 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h > > @@ -78,6 +78,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #define TRB_COMPLETION_STOPPED 26 > > #define TRB_COMPLETION_STOPPED_LENGTH_INVALID 27 > > > > +// > > +// USB Transfer Results Internal Definition // Based on XHCI spec=20 > > +4.8.3, software should do the reset endpoint while > > USB Transaction occur. > > +// Add the error code for USB Transaction error since UEFI spec=20 > > +don't > have > > the related definition. > > +// > > +#define EDKII_USB_ERR_TRANSACTION 0x200 > > + > > // > > // The topology string used to present usb device location // > > -- > > 2.42.0.windows.2 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118618): https://edk2.groups.io/g/devel/message/118618 Mute This Topic: https://groups.io/mt/105952289/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_042A_01DAA05E.96F6AF10 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

I will merge it this week.

 

= =B7=A2=BC=FE=C8= =CB: Shih, More <more.shih@intel.com>= ;
= =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA5=D4=C26=C8=D5 11:34=
=CA=D5=BC=FE=C8=CB: Cai, Xianglei <xianglei.cai@intel.com>; gaoliming <gaoli= ming@byosoft.com.cn>; devel@edk2.groups.io
=B3=AD=CB=CD: Ni, Ray <ray.ni@intel.com= >; Lewandowski, Krzysztof <krzysztof.lewandowski@intel.com>; Huang= , Jenny <jenny.huang@intel.com>
=D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2 1/1] Md= eModulePkg/XhciDxe: Reset endpoint while USB Transaction error

&n= bsp;

Hi Gaoliming,=

 

Could you help push the PR ?

 

BR,

More Shih=

From= : Cai, Xianglei <xianglei.cai@intel.com>
Sent: Friday, April = 26, 2024 5:13 PM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Lewandowski, Krzysztof <= ;krzysztof.lewandowski@i= ntel.com>; Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>
Subject: RE: [edk2-devel] = [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction e= rror

 

I have no access to push PR. But I tried with my pers= onal fork, it can pass CI.

Thanks,
Xianglei

-----Original = Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, April 26, 2024 4:44= PM
To: devel@edk2.groups.io= ; Cai, Xianglei <xianglei.cai@= intel.com>
Cc: Ni, Ray <ra= y.ni@intel.com>; Lewandowski, Krzysztof <krzysztof.lewandowski@intel.com>; Huang, = Jenny <jenny.huang@intel.com>; Shih, More <more.shih@inte= l.com>
Subject: =BB=D8=B8= =B4: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: R= eset endpoint while USB Transaction error

Can you create PR for this= patch? If it passes CI, I will add push label.

Thanks
Liming> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> = =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=B1=ED Xi= anglei Cai
> =B7=A2=CB=CD=CA=B1=BC=E4: 2024= =C4=EA4=D4=C225= =C8=D5 17:58
> =CA=D5=BC=FE=C8=CB: gaoliming <gaolim= ing@byosoft.com.cn>; devel@e= dk2.groups.io
> =B3=AD=CB=CD: Ni, Ray &= lt;ray.ni@intel.com>; Lewandowsk= i, Krzysztof
> <krzysztof.lewandowski@intel.com>; Huang, Jenny
> <jenny.huang@intel.com>; Shih, Mor= e <more.shih@intel.com>> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2 1/= 1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction erro= r
>
> Hi @gaoliming
>
> Could you provide the eta= when the patch can be merged?
>
> Thanks,
> Xianglei>
> -----Original Message-----
> From: Cai, Xianglei
&g= t; Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Ni= , Ray <ray.ni@intel.com>; Lew= andowski, Krzysztof
> <krzysztof.lewandowski@intel.com>; Huang, Jenny
> <= ;jenny.huang@intel.com>; Sh= ih, More <more.shih@intel.com= >
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe:= Reset
> endpoint while USB Transaction error
>
> Hi Li= ming,
>
> Could you help pick the change to the master branch?=
>
> Thanks,
> Xianglei
>
> -----Original M= essage-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, April 15, 2= 024 5:52 PM
> To: devel@edk2.= groups.io; Cai, Xianglei <= xianglei.cai@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Lewandowski, Krzysztof
> &= lt;krzysztof.lewandowski= @intel.com>; Huang, Jenny
> <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>
> Subject: = =BB=D8=B8=B4: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/X= hciDxe: Reset
> endpoint while USB Transaction error
>
>= ; Reviewed-by: Liming Gao <g= aoliming@byosoft.com.cn>
>
> > -----=D3=CA=BC= =FE=D4=AD=BC=FE-----
> > =B7=A2=BC=FE=C8= =CB: devel@edk2.= groups.io <devel@edk2.groups= .io> =B4=FA=B1=ED Xianglei
> Cai
= > > =B7=A2=CB=CD=CA=B1=BC=E4: 2024= =C4=EA4=D4=C215=C8=D5 14:55
> > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io> > =B3=AD=CB=CD: Xianglei Cai <xianglei.cai@intel.com>; Ray Ni <= br>> > <ray.ni@intel.com&g= t;; Liming Gao <gaoliming@by= osoft.com.cn>; Krzysztof
> > Lewandowski <krzysztof.lewandowski@intel.com&g= t;; Jenny Huang
> > <= jenny.huang@intel.com>; More Shih <more.shih@intel.com>
> > =D6=F7=CC=E2: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
&= gt; endpoint
> > while USB Transaction error
> >
> = > http= s://bugzilla.tianocore.org/show_bug.cgi?id=3D4556
> >
> = > Based on XHCI spec 4.8.3, software should do the reset endpoint
&g= t; > while USB Transaction occur.
> > Add the error code for US= B Transaction error since UEFI spec don't
> > have the related de= finition.
> >
> > Cc: Ray Ni     = ;             &= lt;ray.ni@intel.com>
> >= ; Cc: Liming Gao          = ;    <gaolimi= ng@byosoft.com.cn>
> > Cc: Krzysztof Lewandowski  = ; <krzysztof.lewandow= ski@intel.com>
> > Cc: Jenny Huang    &= nbsp;        <jenny.huang@intel.com>
> > Cc: More Shih&= nbsp;           &nbs= p;  <more.shih@intel.com= >
> > Signed-off-by: Xianglei Cai <xianglei.cai@intel.com>
> > Reviewed-by: K= rzysztof Lewandowski <krzysztof.lewandowski@intel.com>
> > ---
> > = ; MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c      | 5 +++= +-
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 ++++- > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++++++
> &g= t;  3 files changed, 15 insertions(+), 2 deletions(-)
> >
= > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > b/M= deModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > index f4e61d223c1b..cf6b329= 59e68 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
>= > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > @@ -825,7 +825= ,10 @@ XhcTransfer (
> >    *TransferResult =3D Urb= ->Result;
> >    *DataLength   &n= bsp; =3D Urb->Completed;
> >
> > -  if ((*Transfe= rResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D=3D
> > E= FI_USB_ERR_BABBLE)) {
> > +  //
> > +  // Based= on XHCI spec 4.8.3, software should do the reset
> > + endpoint<= br>> while
> > USB Transaction occur.
> > +  //> > +  if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*Tra= nsferResult =3D=3D
> > EFI_USB_ERR_BABBLE) || (*TransferResult =3D= =3D
> > EDKII_USB_ERR_TRANSACTION)) {
> >  &nbs= p;   ASSERT (Status =3D=3D EFI_DEVICE_ERROR);
> > &= nbsp;    RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, U= rb);
> >      if (EFI_ERROR (RecoveryStat= us)) { diff --git
> > a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c<= br>> > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > index = 5d735008ba31..a97ed44dbfc3 100644
> > --- a/MdeModulePkg/Bus/Pci/X= hciDxe/XhciSched.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSche= d.c
> > @@ -1192,8 +1192,11 @@ XhcCheckUrbResult (
> >&nb= sp;         DEBUG ((DEBUG_ERROR, &q= uot;XhcCheckUrbResult: ERR_BUFFER!
> > Completecode =3D %x\n"= , EvtTrb->Completecode));
> >     &nbs= p;    goto EXIT;
> >
> > +  &nbs= p;   //
> > +      // Based on = XHCI spec 4.8.3, software should do the reset
> > + endpoint
&= gt; > while USB Transaction occur.
> > +    = ;  //
> >        case TRB_= COMPLETION_USB_TRANSACTION_ERROR:
> > -    &nb= sp;   CheckedUrb->Result  |=3D EFI_USB_ERR_TIMEOUT;
&g= t; > +        CheckedUrb->Result&n= bsp; |=3D EDKII_USB_ERR_TRANSACTION;
> >    &n= bsp;     CheckedUrb->Finished =3D TRUE;
> >=           DEBUG ((DEBUG_ERROR,= "XhcCheckUrbResult:
> > TRANSACTION_ERROR! Completecode =3D = %x\n", EvtTrb->Completecode));
> >    =       goto EXIT;
> > diff --git a/MdeModu= lePkg/Bus/Pci/XhciDxe/XhciSched.h
> > b/MdeModulePkg/Bus/Pci/XhciD= xe/XhciSched.h
> > index 7c85f7993b5c..e606e212a1d3 100644
>= > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > +++ b/Mde= ModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > @@ -78,6 +78,13 @@ SPDX-= License-Identifier: BSD-2-Clause-Patent
> >  #define TRB_COMP= LETION_STOPPED          &= nbsp;      26
> >  #define TRB_COMPL= ETION_STOPPED_LENGTH_INVALID  27
> >
> > +//
>= > +// USB Transfer Results Internal Definition // Based on XHCI spec > > +4.8.3, software should do the reset endpoint while
> >= ; USB Transaction occur.
> > +// Add the error code for USB Transa= ction error since UEFI spec
> > +don't
> have
> > = the related definition.
> > +//
> > +#define EDKII_USB_ER= R_TRANSACTION  0x200
> > +
> >  //
> >=   // The topology string used to present usb device location  //<= br>> > --
> > 2.42.0.windows.2
> >
> >
= > >
> >
> >
>
>
>
>
= >
>
>


_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118618) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_042A_01DAA05E.96F6AF10--