public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <brent.holtsclaw@intel.com>
Subject: 回复: [edk2-devel] [PATCH] Pkg-Module: MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
Date: Fri, 11 Mar 2022 09:18:04 +0800	[thread overview]
Message-ID: <043001d834e5$dbbcfaa0$9336efe0$@byosoft.com.cn> (raw)
In-Reply-To: <282832659b0b12d84d91108a17e0c4456e0dfbfa.1646779008.git.brent.holtsclaw@intel.com>

Brent:

Please update commit title as MdePkg Include: Update Protocol
PxeBaseCodeCallBack.h

With this change, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>  

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> brentholtsclaw
> 发送时间: 2022年3月9日 7:19
> 收件人: devel@edk2.groups.io
> 抄送: brentholtsclaw <brent.holtsclaw@intel.com>
> 主题: [edk2-devel] [PATCH] Pkg-Module:
> MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3849
> 
> PxeBaseCodeCallBack.h lacks definition for EFI_PXE_BASE_CODE_PACKET
> 
> +  #include <Protocol/PxeBaseCode.h>
> 
> ///
> 
> Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com>
> ---
>  MdePkg/Include/Protocol/PxeBaseCodeCallBack.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
> b/MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
> index 65b3220698..ac7269cf78 100644
> --- a/MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
> +++ b/MdePkg/Include/Protocol/PxeBaseCodeCallBack.h
> @@ -13,6 +13,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #ifndef _PXE_BASE_CODE_CALLBACK_H_
>  #define _PXE_BASE_CODE_CALLBACK_H_
> 
> +#include <Protocol/PxeBaseCode.h>
> +
>  ///
>  /// Call Back Definitions.
>  ///
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 






      reply	other threads:[~2022-03-11  1:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 23:18 [PATCH] Pkg-Module: MdePkg/Include/Protocol/PxeBaseCodeCallBack.h brent.holtsclaw
2022-03-11  1:18 ` gaoliming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='043001d834e5$dbbcfaa0$9336efe0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox