From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D321D941D7D for ; Wed, 30 Aug 2023 17:11:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=krKN62xtDqw5JLeKfalxgg8BVmSN2rgKIsgTB9rtkSo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693415473; v=1; b=GCY+Ud2B7lnSspRBuQJfgogk6OiD23GqtQTL5auIX1qHNyxxEnMQtlm9JALJ0/6vM2cGiPI5 p/QdNePmTyGo1h+pz7lYfuCp36P7YmGAorNujdHmTX0WccAlfGnER8C7J+E3mrLTJN1LkCJWbfK wCetHwy7rfA4DUEIgHEgMVhs= X-Received: by 127.0.0.2 with SMTP id 8KK0YY7687511x0U23VDJkCr; Wed, 30 Aug 2023 10:11:13 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.9944.1693386794127098112 for ; Wed, 30 Aug 2023 02:13:14 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="374499932" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="374499932" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 02:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="809057829" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="809057829" X-Received: from shserverbios518.ccr.corp.intel.com ([10.5.215.122]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2023 02:13:11 -0700 From: horacex.lien@intel.com To: devel@edk2.groups.io Cc: HoraceX Lien , Zhiguang Liu , Dandan Bi , Star Zeng , Zhichao Gao Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Date: Wed, 30 Aug 2023 17:12:44 +0800 Message-Id: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,horacex.lien@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OHNW6U23wNUOwl8zU0ijnvxQx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GCY+Ud2B; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 These value of Major/Minor version are updated from SMBIOS memory data, but BCD Revision is updated from PCD PcdSmbiosVersion. We should also update PCD PcdSmbiosVersion from SMBIOS memory data, to ensure that get consistent version value. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Signed-off-by: HoraceX Lien --- MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c b/MdeModulePkg/Un= iversal/SmbiosDxe/SmbiosDxe.c index 1a86e69d3c..e3f6215033 100644 --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry point = structure\n"));=0D EntryPointStructureData.MajorVersion =3D mPrivateData.Smbios.Majo= rVersion;=0D EntryPointStructureData.MinorVersion =3D mPrivateData.Smbios.Mino= rVersion;=0D - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 (PcdSm= biosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion) & 0x0f);=0D + EntryPointStructureData.SmbiosBcdRevision =3D (mPrivateData.Smbios.Maj= orVersion << 4) | mPrivateData.Smbios.MinorVersion;=0D PhysicalAddress =3D 0xffffffff;=0D Status =3D gBS->AllocatePages (=0D AllocateMaxAddress,= =0D --=20 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108150): https://edk2.groups.io/g/devel/message/108150 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-