From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 676237803CC for ; Mon, 20 May 2024 17:19:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=X1Z9WGKYqAuDZFpfhN34ZSSpBulLxcuGC27mqjMAD9A=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:To:Cc:References:From:Subject:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716225569; v=1; b=UtG975xB3ZnROAqiMVppqZ8Py72b79BvFVXASjEYCGHWkcVRhBave1gWXsl8NQntrBLtEFYE 9yWanZaxhtbIE6VgSXtM1q99AjPLylGHDdx8INrh/oEp0G7ciy8uy6ekCRTRHF1sd8FVyg5noL2 Izj9MlOv4/vW75nBJZxooweynwmwJFjbd116NMkN+JalmEFPA30mxdvkc8P+8cbvxl6cUrJV2ng CPBFQNDZE5Q/Zg7zX+rPVNezFJ/RK+Co7OMhaTFyDipX6drO6cMCHhKPvXcg8Mofm/u6aBMQLfd +L140KQ6ZTF+9k8x6pjqz/tExfx+AyNIfhytTtC1s/kYw== X-Received: by 127.0.0.2 with SMTP id aEG2YY7687511x3L0AslaMLD; Mon, 20 May 2024 10:19:29 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.52]) by mx.groups.io with SMTP id smtpd.web10.2294.1716225568721613345 for ; Mon, 20 May 2024 10:19:28 -0700 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by MW6PR12MB9020.namprd12.prod.outlook.com (2603:10b6:303:240::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 17:19:25 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::bf0:d462:345b:dc52]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::bf0:d462:345b:dc52%7]) with mapi id 15.20.7587.030; Mon, 20 May 2024 17:19:25 +0000 Message-ID: <043edee3-be1d-2fed-7dd4-547a3b5212dd@amd.com> Date: Mon, 20 May 2024 12:19:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Alexey Kardashevskiy , devel@edk2.groups.io Cc: Liming Gao , Michael D Kinney , Zhiguang Liu , Ard Biesheuvel , Erdem Aktas , Gerd Hoffmann , Jiewen Yao , Michael Roth , Min Xu References: <20240502143445.526098-1-aik@amd.com> <20240502143445.526098-2-aik@amd.com> From: "Lendacky, Thomas via groups.io" Subject: Re: [edk2-devel] [PATCH ovmf v3 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER In-Reply-To: <20240502143445.526098-2-aik@amd.com> X-ClientProxiedBy: SA9PR13CA0147.namprd13.prod.outlook.com (2603:10b6:806:27::32) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|MW6PR12MB9020:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ed14951-cc6c-4fd7-07d4-08dc78f0ff58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?d05mWmVCbi9pZ1lWQVBHc2NFc1NIYm05MkdyNlR4a25MMnlCczBkOTlSSDVo?= =?utf-8?B?OHFsaHNZR2lKc3NOSExXZUZBSW5nbkZvQ0xwN3cyaXJNWkdsUXEzSnJPUytD?= =?utf-8?B?WFYzZFpBREdWaSsvM2JLa3FndHc5bFZaN1hJalcyemNKWU5zSXhNSnEwRHU3?= =?utf-8?B?VFUyS3pmd0krMFBDeWVseVRKNDc3a3JGelVGZVA1VENKbnpnNTJ1KzU2N0JO?= =?utf-8?B?MnVEWG1QQStIV1F3OWRlTS90LzM1NGpSWGJ1a0RvWllqY2xBTzJMR1JGUFdi?= =?utf-8?B?eUNaQ0ZxTi93TmV4QkZaOW5sTUNnbm12S3NtbExKUU94MVhCclVXQjlxODFB?= =?utf-8?B?RDlYRElmR0UxQjlieGdqZGR3Q2FHTWVXNEJkYUtMRXRIYXM4c0tCVnJZSWZw?= =?utf-8?B?YTYrWUVmdWRtaXVTWEs1NFl6VEVIam1CS05USVp0N1pXVVlIY0VnRyttTFdG?= =?utf-8?B?TjlaaFNlT01uZWJIY2p3cVNDZlpNY013Rk9YRTN4dWhla2RuMG8vS21UMXJL?= =?utf-8?B?c2VCZkZnbEhDVXJJV0NaeHF3emh2NDRIdmlYcjllMHNYbENsOFhlS2MvZ2Ji?= =?utf-8?B?YUdIQVhLbTc5eTBRdXh0UHA4RW56THYzWll6cWFwWmRKZVdtUjJ5Y3BwbTBh?= =?utf-8?B?bm1sbDNib0xMd28rdnp4Ym1IeWtucW9SbWRnaXZCOXFaUThsWkNrNE55eWpW?= =?utf-8?B?QVkwdUdLNWRUQnFwVTFMQjgxNmRuT015TlpiTVJYM1pRN3Job1lucUNpcVh1?= =?utf-8?B?L3FmRkRwWmxKQ1BDWGhJd0dac0Fyb20ySWpyb0ZKWEZ4bDAwTVc3ZHpGTHlT?= =?utf-8?B?Mldvb3BiZWNyWmhTWVVpejE0SWRCRWIvZmp0M0NHZkpxaTJTNGE5VXJ5REZm?= =?utf-8?B?Wm85SzBMbnc3ZXNwWC9YcStlK09DU1Y2NnRVa2EyNnhYamhHd0pFRi9xT2px?= =?utf-8?B?a0ZiZk9tWWN2UFN1N1lKa2hLbE5jRUJQS1hTNUNockpXS0p1SjNXejl3UnY3?= =?utf-8?B?eTQwUlRRSVNBVktrUU5ka0VzekhiRi9oamZjY2kxRFd2cnF4aTVRc0tEZmVQ?= =?utf-8?B?a3B2eTh0OERXOTg1TVBCMGMvUUZON1lZQlFONXR2Z2J1UjhKdnRUOXVndXFO?= =?utf-8?B?a25JRGt4ODFuWDV1eWlsRnBvUzJaQU1JODcxUW9mZGRUc052TEx6VjEvMFMw?= =?utf-8?B?YWJldnRTeGljQjdZNGlpL0h4K09kSGt3SExralppcmJ2bU44MDVqZ01QRVhh?= =?utf-8?B?US9Ca3RXRUtKeWloWjNZTnRISjM1b1FJLzFSY2ZkeEpTKzV2Ni94SjR5WlRp?= =?utf-8?B?R2ZTMVVFanJ4Q0dUNWlJMDgvdmJIcVB6bll6MGJSZGtoWjVtY2Jxc05QaXlT?= =?utf-8?B?Q2Vtb2pqZnkza2pNMmJhVkZjWFdyc3lqcDhsOW9haGdFQ25Bc3Z4SE9ZVmJJ?= =?utf-8?B?Z0JMOFhpdW9sdFdxOENiNzIzVFlyYm56eW92OGJzZk9UK25Sbis2NXh4YXpk?= =?utf-8?B?RVZFV05GR1NEYmE5R28zd0VoNWZKenFmLzRpQUJyODIrcmMvWG1WbXN6WUVO?= =?utf-8?B?UVhseVlCa0t1SHFZNWZ3UG5obit3T1I1bzIra05mbmF6cVZIZHpiMVdBOWxz?= =?utf-8?B?dEZxaWtMdHZVVHlhK3NrcG4yMG1mbWc4WW42Q0hhU3h5VXB6Q01XMmN3N1pD?= =?utf-8?B?VmRuNkNLTjFUQkdFZy9oOWxhWkhzQ0JLdlJUNXowT1lIR3Z6Q2FZUk1nPT0=?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UURuSTkweVRrajI2Zm9KclBnblJVVEVpaTZxdzFJNHR6ejQ3N2J2WFU1Y1Q0?= =?utf-8?B?Uk00Z0pNVHl0aEZXQ3IxVko4U0NQR2xEdDF6b0hCTklUNHY4WkRPaWcvQ1Qz?= =?utf-8?B?YUc4OXByZ2orZUphN0N0UWlPUTJEOHFkWW44QkM0ZFdsWGk3VGFQdHkxUHZN?= =?utf-8?B?TGRLSWlrOEhSVmhIRnpFNnRCOEpaMlVQWGZDeVI0SmJ4WlJ3Si9QcHgzdERw?= =?utf-8?B?MGJ0SzN4VVMzRFVLM0NReTJLZzlLOXB3ZEpXSmFLNkF4dXphc3U1bVpqZFhK?= =?utf-8?B?SnlreVZnZEJJRmRwaWxhMkZKMEc2a0dRanhFM2FaeFVtd1VqcERoRTR1S3ZI?= =?utf-8?B?ay8vZWNteHdlVnJBMjlDa3dpSi9mczN3Vm5jb0xKMzVKRDNWTkJhbmw4RmFt?= =?utf-8?B?ZVlOcEFsUnFQbVhHRHhzNVZYVDZNdWt0MmVkbS81cDRxUWc2eUxZMUhCZGNy?= =?utf-8?B?cmh3bFhKanVNaTlZZ1h5c24rMEZJV212aHAvOFVDVk9lREdZa1g0bFNLbmdC?= =?utf-8?B?RHBLZ2lpdE5ieHFtQmJuYVlOb0gvUHV4dzBRMnJRcnNqWkwwN1BTU2t3L3RQ?= =?utf-8?B?ZkNvRnIyTlFrZDkza3g3by9Eanp2RHNiOWdLVDMvZWliemZUUHgvNFl5Vzh4?= =?utf-8?B?bGxqZDJiL1hLTmV6NjY0cGVFR0s4cFp1N2UzOWZ5cGJjblhxWTZCeDNaSzNp?= =?utf-8?B?SG5tUC9URTd1MC81U0JLSktlZnhIcGY2OStVZG9nNUJlZFp2Wlp6QTUzUi9T?= =?utf-8?B?Wm96MHhVajJiMkVkQ2xjUW1LOGZKSHpBMDdWYXdkWTRlNUYzNUgvTDJuOUs5?= =?utf-8?B?a2U3YmZjWDdZK1VIdGFpVGkzaDM1VXF5OER0NlZFTS8wYUhCYzl4RXZJWDJq?= =?utf-8?B?dVpvRWpadDFNT1F2YmtnRzFRRGZmNkZHS2ZyRGFVcExGUE9zKzJHNzlodnBn?= =?utf-8?B?RXpqWXdySzZWOWIwZmpwcEErZk9senUvV0lkdlRBKzVVN1c1N1d3NUxQM0Fj?= =?utf-8?B?WGtWOElQVkxmTzBBWHFqRFFhdi94ZGUvbEVwYmtVaXpscndqSDFQRmJ3ems2?= =?utf-8?B?MFpRL2Ivei93S3o0TUVSVkpORFNrZUdNM2l5cnpwdkdZRkpubkpjU3RmYjFF?= =?utf-8?B?ekFyY0FPWStCa3Zzam56NDRwa0ljeXBsYktIMUI3RHFnVCtxYUg1YVRsT0V1?= =?utf-8?B?QTNSQ0pDYXJkR05DR1E5cEtZdm42ZG9rbnNxbjM2TVNMZVphUzl1K2ljdjl2?= =?utf-8?B?TGxvMGZUcHc1RFk3eDVza3dmcW5ITEgyZjhZb1AvT2NWbDF3Z1BJU1hOeE0r?= =?utf-8?B?cXF1L0pqeWNWVjBnR2luMmxaVWwzRTZFbzhTZWR6LzY5bzdvUWRYcFd0YVFu?= =?utf-8?B?UTFGbStiSXZNSEJQZTRoa1hVcFlPL01RbzhyKzdjbHpqZExBUUJJUkhJcjVP?= =?utf-8?B?dWpBK0lyVVNnT2FrWHl2aVNOdzRrYlZzK0lMR1FQR3pqZDJKYk4xa2JGWjU4?= =?utf-8?B?a2JGeFNaaFFNaXVBRnhENndCOVlBTW9LVzZMRXMvVGhkYXB5YnFURllYV1lq?= =?utf-8?B?eDRNRTZpTG5HcGx0SDNWTGRPeGFJM2dTRHpFNGdaQmQzRVVnZE9QNDQrZ3hS?= =?utf-8?B?ZHF6ZDgxem1sdW03VmJUWk9qRHd5YUtFaEhRL3V5bHBJVCtJYmxnU25KOGps?= =?utf-8?B?RTdGRFY1aE8zYkhXWlh3Q09NbDJ3TlFRYmk5V3dlK2JUWUptOThpaWRiZEZT?= =?utf-8?B?a3R0WkVxMDFTQitpWkRTcEQzYmhUWHBnMzdDTFUxTFEzUTlvU2I2VlVOanIw?= =?utf-8?B?YjFtL1pvckFlRGNJV2Erb0k2TzkwcXpiSTdPL1BvVXdLUmpsV3NBUzRTZElr?= =?utf-8?B?eGRyUFJkZnd4VVJ0RVNNSEVQbVZUdFBzQklDc2VldDZVanJLSnhQNURyUnVr?= =?utf-8?B?VXBDYklUWUdGekNab3l5eVF2Y1RYRzhhdkRac0RXN1F1RjVWOXVHKyt1VWFs?= =?utf-8?B?Ni85c0FOTHA3Sy9PZVpPQ3R1clVLaWdKR2tLYWQrQjllTXp0QTFPeXBiQjQv?= =?utf-8?B?TjVmQVIzTG80MTUrUTM0SXFDVXg4bDRrZCsrdHFKdjZkVThacmN6c2VnSVRX?= =?utf-8?Q?GvLazleKY8pjkjQwoPupdTXyw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed14951-cc6c-4fd7-07d4-08dc78f0ff58 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 17:19:25.3270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AfgtJpxGVFLso0+/hHDQGqdqFSovUpqd/X9hcnFIW7ERCbgktMcErCI1THTDWAyfJ0C7dIji9Rl+P5RRXt8nQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB9020 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 20 May 2024 10:19:28 -0700 Resent-From: thomas.lendacky@amd.com Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kN1SfwVY8ST0sZevjeVRsjDPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UtG975xB; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/2/24 09:34, Alexey Kardashevskiy wrote: > For now we need DebugSwap but others are likely to be needed too. >=20 > Cc: Tom Lendacky > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Zhiguang Liu > Signed-off-by: Alexey Kardashevskiy A recent APM has defined a few more and has slightly different naming=20 (see below). If you have to submit another version it might be good to=20 update them. Otherwise: Reviewed-by: Tom Lendacky > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 63 ++++++++++++++++++-- > 1 file changed, 59 insertions(+), 4 deletions(-) >=20 > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Regi= ster/Amd/Fam17Msr.h > index f2d5ccb39dc7..bce51a66517f 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -126,19 +126,74 @@ typedef union { > /// > /// [Bit 0] Secure Encrypted Virtualization (Sev) is enabled > /// > - UINT32 SevBit : 1; > + UINT32 SevBit : 1; > =20 > /// > /// [Bit 1] Secure Encrypted Virtualization Encrypted State (SevEs)= is enabled > /// > - UINT32 SevEsBit : 1; > + UINT32 SevEsBit : 1; > =20 > /// > /// [Bit 2] Secure Nested Paging (SevSnp) is enabled > /// > - UINT32 SevSnpBit : 1; > + UINT32 SevSnpBit : 1; > =20 > - UINT32 Reserved2 : 29; > + /// > + /// [Bit 3] The guest was run with the Virtual TOM feature enabled i= n SEV_FEATURES[1] > + /// > + UINT32 vTOM_Enabled : 1; The APM has this as vTOM and the PPR as VirtualTOM, so can probably=20 remove the _Enabled. > + > + /// > + /// [Bit 4] The guest was run with the ReflectVC feature enabled in = SEV_FEATURES[2] > + /// > + UINT32 ReflectVC : 1; > + > + /// > + /// [Bit 5] The guest was run with the Restricted Injection feature = enabled in SEV_FEATURES[3] > + /// > + UINT32 RestrictedInjection : 1; > + > + /// > + /// [Bit 6] The guest was run with the Alternate Injection feature e= nabled in SEV_FEATURES[4] > + /// > + UINT32 AlternateInjection : 1; > + > + /// > + /// [Bit 7] This guest was run with debug register swapping enabled = in SEV_FEATURES[5] > + /// > + UINT32 DebugSwap : 1; The APM has this as DebugVirtualization and the PPR as DebugSwapSupport. > + > + /// > + /// [Bit 8] This guest was run with the PreventHostIBS feature enab= led in SEV_FEATURES[6] > + /// > + UINT32 PreventHostIBS : 1; > + > + /// > + /// [Bit 9] The guest was run with the BTB isolation feature enabled= in SEV_FEATURES[7] > + /// > + UINT32 SNPBTBIsolation : 1; The APM has this as BTBIsolation, while the PPR has it as you do. > + > + /// > + /// [Bit 10] > + /// > + UINT32 Reserved0 : 1; > + > + /// > + /// [Bit 11] The guest was run with the Secure TSC feature enabled i= n SEV_FEATURES[9] > + /// > + UINT32 SecureTsc : 1; > + > + /// > + /// [Bits 12 13 14 15] > + /// > + UINT32 Reserved1 : 4; > + > + /// > + /// [Bit 16] The guest was run with the VMSA Register Protection fea= ture enabled in SEV_FEATURES[14] > + /// > + UINT32 VmsaRegProt_Enabled : 1; The APM has this VmsaRegProt, so can probably drop the _Enabled. > + > + UINT32 Reserved2 : 15; > } Bits; > /// > /// All bit fields as a 32-bit value -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119085): https://edk2.groups.io/g/devel/message/119085 Mute This Topic: https://groups.io/mt/105863816/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-