* [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file @ 2024-05-01 19:31 Hsueh, Hong-Chih (Neo) via groups.io 2024-05-16 0:49 ` [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Chang, Abner via groups.io 0 siblings, 1 reply; 6+ messages in thread From: Hsueh, Hong-Chih (Neo) via groups.io @ 2024-05-01 19:31 UTC (permalink / raw) To: devel Cc: michael.d.kinney, gaoliming, zhiguang.liu, jiangang.he, abner.chang, Neo Hsueh Cc: Jiangang He <jiangang.he@amd.com> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com> --- MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/MdePkg/Include/Register/Amd/Cpuid.h b/MdePkg/Include/Register/Amd/Cpuid.h index add43c40aa..51fa9f235c 100644 --- a/MdePkg/Include/Register/Amd/Cpuid.h +++ b/MdePkg/Include/Register/Amd/Cpuid.h @@ -46,9 +46,9 @@ CPUID Signature Information CPUID Extended Topology Enumeration @note - Reference: AMD64 Architecture Programmer’s Manual Volume 3: General-Purpose and System Instructions, + Reference: AMD64 Architecture Programmer's Manual Volume 3: General-Purpose and System Instructions, Revision 3.35 Appendix E, - E.4.24 Function 8000_0026—Extended CPU Topology: + E.4.24 Function 8000_0026-Extended CPU Topology: CPUID Fn8000_0026 reports extended topology information for logical processors, including asymmetric and heterogenous topology descriptions. Individual logical processors may report different values in systems with asynchronous and heterogeneous topologies. diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h index 756e7c86ec..4715c59dc4 100644 --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h @@ -5733,9 +5733,9 @@ typedef union { /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms enumerated in /// IA32_TME_CAPABILITY are allowed. /// For example: - /// 0000 – AES-XTS-128. - /// 0001 – AES-XTS-128 with integrity. - /// 0010 – AES-XTS-256. + /// 0000 - AES-XTS-128. + /// 0001 - AES-XTS-128 with integrity. + /// 0010 - AES-XTS-256. /// Other values are invalid. /// UINT32 TmePolicy : 4; @@ -5756,7 +5756,7 @@ typedef union { /// Similar to enumeration, this is an encoded value. /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in #GP. /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware - /// Encryption Enable) is not also set to ‘1, as encryption hardware must be + /// Encryption Enable) is not also set to 1, as encryption hardware must be /// enabled to use MKTME. /// Example: To support 255 keys, this field would be set to a value of 8. /// -- 2.40.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118481): https://edk2.groups.io/g/devel/message/118481 Mute This Topic: https://groups.io/mt/105849632/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) 2024-05-01 19:31 [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file Hsueh, Hong-Chih (Neo) via groups.io @ 2024-05-16 0:49 ` Chang, Abner via groups.io 2024-05-16 1:08 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 6+ messages in thread From: Chang, Abner via groups.io @ 2024-05-16 0:49 UTC (permalink / raw) To: Hsueh, Hong-Chih (Neo), devel@edk2.groups.io Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, He, Jiangang [AMD Official Use Only - AMD Internal Distribution Only] Hi Mike, Liming and Zhiguang, Could you please check this patch sent two weeks ago? The corresponding BZ ticket is 4775. We overlooked tracking this issue and missed the 202405 stable release. As this impacts the build, do you think we can have a quick review and approve it; having this change pulled in 202405 stable release? Otherwise we will have to wait until next stable release. Thanks Abner > -----Original Message----- > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> > Sent: Thursday, May 2, 2024 3:31 AM > To: devel@edk2.groups.io > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com>; Chang, > Abner <Abner.Chang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong- > Chih.Hsueh@amd.com> > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > Cc: Jiangang He <jiangang.he@amd.com> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com> > --- > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > b/MdePkg/Include/Register/Amd/Cpuid.h > index add43c40aa..51fa9f235c 100644 > --- a/MdePkg/Include/Register/Amd/Cpuid.h > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > @@ -46,9 +46,9 @@ CPUID Signature Information > CPUID Extended Topology Enumeration > > @note > - Reference: AMD64 Architecture Programmer’s Manual Volume 3: General- > Purpose and System Instructions, > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > Purpose and System Instructions, > Revision 3.35 Appendix E, > - E.4.24 Function 8000_0026—Extended CPU Topology: > + E.4.24 Function 8000_0026-Extended CPU Topology: > CPUID Fn8000_0026 reports extended topology information for logical > processors, including > asymmetric and heterogenous topology descriptions. Individual logical > processors may report > different values in systems with asynchronous and heterogeneous > topologies. > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > index 756e7c86ec..4715c59dc4 100644 > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > @@ -5733,9 +5733,9 @@ typedef union { > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms enumerated > in > /// IA32_TME_CAPABILITY are allowed. > /// For example: > - /// 0000 – AES-XTS-128. > - /// 0001 – AES-XTS-128 with integrity. > - /// 0010 – AES-XTS-256. > + /// 0000 - AES-XTS-128. > + /// 0001 - AES-XTS-128 with integrity. > + /// 0010 - AES-XTS-256. > /// Other values are invalid. > /// > UINT32 TmePolicy : 4; > @@ -5756,7 +5756,7 @@ typedef union { > /// Similar to enumeration, this is an encoded value. > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > #GP. > /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware > - /// Encryption Enable) is not also set to ‘1, as encryption hardware must be > + /// Encryption Enable) is not also set to 1, as encryption hardware must be > /// enabled to use MKTME. > /// Example: To support 255 keys, this field would be set to a value of 8. > /// > -- > 2.40.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118932): https://edk2.groups.io/g/devel/message/118932 Mute This Topic: https://groups.io/mt/106126342/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) 2024-05-16 0:49 ` [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Chang, Abner via groups.io @ 2024-05-16 1:08 ` gaoliming via groups.io 2024-05-16 1:12 ` Chang, Abner via groups.io 2024-06-04 15:45 ` Hsueh, Hong-Chih (Neo) via groups.io 0 siblings, 2 replies; 6+ messages in thread From: gaoliming via groups.io @ 2024-05-16 1:08 UTC (permalink / raw) To: devel, abner.chang, 'Hsueh, Hong-Chih (Neo)' Cc: michael.d.kinney, zhiguang.liu, 'He, Jiangang' Abner: This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> But, this is not critical issue. So, I suggest to merge it after the stable tag. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chang, Abner via > groups.io > 发送时间: 2024年5月16日 8:50 > 收件人: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; > devel@edk2.groups.io > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com> > 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from > header file (BZ# 4775) > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, Liming and Zhiguang, > Could you please check this patch sent two weeks ago? The corresponding BZ > ticket is 4775. We overlooked tracking this issue and missed the 202405 stable > release. As this impacts the build, do you think we can have a quick review and > approve it; having this change pulled in 202405 stable release? Otherwise we will > have to wait until next stable release. > > Thanks > Abner > > > -----Original Message----- > > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> > > Sent: Thursday, May 2, 2024 3:31 AM > > To: devel@edk2.groups.io > > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com>; Chang, > > Abner <Abner.Chang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong- > > Chih.Hsueh@amd.com> > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > Cc: Jiangang He <jiangang.he@amd.com> > > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com> > > --- > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > b/MdePkg/Include/Register/Amd/Cpuid.h > > index add43c40aa..51fa9f235c 100644 > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > @@ -46,9 +46,9 @@ CPUID Signature Information > > CPUID Extended Topology Enumeration > > > > @note > > - Reference: AMD64 Architecture Programmer’s Manual Volume 3: General- > > Purpose and System Instructions, > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > > Purpose and System Instructions, > > Revision 3.35 Appendix E, > > - E.4.24 Function 8000_0026—Extended CPU Topology: > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > CPUID Fn8000_0026 reports extended topology information for logical > > processors, including > > asymmetric and heterogenous topology descriptions. Individual logical > > processors may report > > different values in systems with asynchronous and heterogeneous > > topologies. > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > index 756e7c86ec..4715c59dc4 100644 > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > @@ -5733,9 +5733,9 @@ typedef union { > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > enumerated > > in > > /// IA32_TME_CAPABILITY are allowed. > > /// For example: > > - /// 0000 – AES-XTS-128. > > - /// 0001 – AES-XTS-128 with integrity. > > - /// 0010 – AES-XTS-256. > > + /// 0000 - AES-XTS-128. > > + /// 0001 - AES-XTS-128 with integrity. > > + /// 0010 - AES-XTS-256. > > /// Other values are invalid. > > /// > > UINT32 TmePolicy : 4; > > @@ -5756,7 +5756,7 @@ typedef union { > > /// Similar to enumeration, this is an encoded value. > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > #GP. > > /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware > > - /// Encryption Enable) is not also set to ‘1, as encryption hardware must > be > > + /// Encryption Enable) is not also set to 1, as encryption hardware must > be > > /// enabled to use MKTME. > > /// Example: To support 255 keys, this field would be set to a value of 8. > > /// > > -- > > 2.40.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118938): https://edk2.groups.io/g/devel/message/118938 Mute This Topic: https://groups.io/mt/106126636/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) 2024-05-16 1:08 ` 回复: " gaoliming via groups.io @ 2024-05-16 1:12 ` Chang, Abner via groups.io 2024-06-04 15:45 ` Hsueh, Hong-Chih (Neo) via groups.io 1 sibling, 0 replies; 6+ messages in thread From: Chang, Abner via groups.io @ 2024-05-16 1:12 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io, Hsueh, Hong-Chih (Neo) Cc: michael.d.kinney@intel.com, zhiguang.liu@intel.com, He, Jiangang [AMD Official Use Only - AMD Internal Distribution Only] Thanks Liming! We can merge it after the stable release. Abner > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Thursday, May 16, 2024 9:09 AM > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Hsueh, > Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> > Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; He, Jiangang > <Jiangang.He@amd.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters > from header file (BZ# 4775) > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Abner: > This change is good to me. Reviewed-by: Liming Gao > <gaoliming@byosoft.com.cn> > > But, this is not critical issue. So, I suggest to merge it after the stable tag. > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chang, Abner > via > > groups.io > > 发送时间: 2024年5月16日 8:50 > > 收件人: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; > > devel@edk2.groups.io > > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com> > > 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from > > header file (BZ# 4775) > > > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > Hi Mike, Liming and Zhiguang, > > Could you please check this patch sent two weeks ago? The corresponding > BZ > > ticket is 4775. We overlooked tracking this issue and missed the 202405 > stable > > release. As this impacts the build, do you think we can have a quick review > and > > approve it; having this change pulled in 202405 stable release? Otherwise > we will > > have to wait until next stable release. > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> > > > Sent: Thursday, May 2, 2024 3:31 AM > > > To: devel@edk2.groups.io > > > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > > > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com>; Chang, > > > Abner <Abner.Chang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong- > > > Chih.Hsueh@amd.com> > > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > > > Cc: Jiangang He <jiangang.he@amd.com> > > > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com> > > > --- > > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > > b/MdePkg/Include/Register/Amd/Cpuid.h > > > index add43c40aa..51fa9f235c 100644 > > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > > @@ -46,9 +46,9 @@ CPUID Signature Information > > > CPUID Extended Topology Enumeration > > > > > > @note > > > - Reference: AMD64 Architecture Programmer’s Manual Volume 3: > General- > > > Purpose and System Instructions, > > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: > General- > > > Purpose and System Instructions, > > > Revision 3.35 Appendix E, > > > - E.4.24 Function 8000_0026—Extended CPU Topology: > > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > > CPUID Fn8000_0026 reports extended topology information for logical > > > processors, including > > > asymmetric and heterogenous topology descriptions. Individual logical > > > processors may report > > > different values in systems with asynchronous and heterogeneous > > > topologies. > > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > > index 756e7c86ec..4715c59dc4 100644 > > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > > @@ -5733,9 +5733,9 @@ typedef union { > > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > > enumerated > > > in > > > /// IA32_TME_CAPABILITY are allowed. > > > /// For example: > > > - /// 0000 – AES-XTS-128. > > > - /// 0001 – AES-XTS-128 with integrity. > > > - /// 0010 – AES-XTS-256. > > > + /// 0000 - AES-XTS-128. > > > + /// 0001 - AES-XTS-128 with integrity. > > > + /// 0010 - AES-XTS-256. > > > /// Other values are invalid. > > > /// > > > UINT32 TmePolicy : 4; > > > @@ -5756,7 +5756,7 @@ typedef union { > > > /// Similar to enumeration, this is an encoded value. > > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > > #GP. > > > /// Writing a non-zero value to this field will #GP if bit 1 of EAX > (Hardware > > > - /// Encryption Enable) is not also set to ‘1, as encryption hardware must > > be > > > + /// Encryption Enable) is not also set to 1, as encryption hardware must > > be > > > /// enabled to use MKTME. > > > /// Example: To support 255 keys, this field would be set to a value of 8. > > > /// > > > -- > > > 2.40.0.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118939): https://edk2.groups.io/g/devel/message/118939 Mute This Topic: https://groups.io/mt/106126690/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) 2024-05-16 1:08 ` 回复: " gaoliming via groups.io 2024-05-16 1:12 ` Chang, Abner via groups.io @ 2024-06-04 15:45 ` Hsueh, Hong-Chih (Neo) via groups.io 2024-06-05 9:38 ` 回复: " gaoliming via groups.io 1 sibling, 1 reply; 6+ messages in thread From: Hsueh, Hong-Chih (Neo) via groups.io @ 2024-06-04 15:45 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io, Chang, Abner Cc: michael.d.kinney@intel.com, zhiguang.liu@intel.com, He, Jiangang [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb2312", Size: 5642 bytes --] [AMD Official Use Only - AMD Internal Distribution Only] Hi Liming, Sorry for the late response. I already created a pull request for it. https://github.com/tianocore/edk2/pull/5737 Regards, Neo ________________________________ From: gaoliming <gaoliming@byosoft.com.cn> Sent: Wednesday, May 15, 2024 8:08 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner <Abner.Chang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> Cc: michael.d.kinney@intel.com <michael.d.kinney@intel.com>; zhiguang.liu@intel.com <zhiguang.liu@intel.com>; He, Jiangang <Jiangang.He@amd.com> Subject: »Ø¸´: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abner: This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> But, this is not critical issue. So, I suggest to merge it after the stable tag. Thanks Liming > -----ÓʼþÔ¼þ----- > ·¢¼þÈË: devel@edk2.groups.io <devel@edk2.groups.io> ´ú±í Chang, Abner via > groups.io > ·¢ËÍʱ¼ä: 2024Äê5ÔÂ16ÈÕ 8:50 > ÊÕ¼þÈË: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; > devel@edk2.groups.io > ³ËÍ: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com> > Ö÷Ìâ: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from > header file (BZ# 4775) > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, Liming and Zhiguang, > Could you please check this patch sent two weeks ago? The corresponding BZ > ticket is 4775. We overlooked tracking this issue and missed the 202405 stable > release. As this impacts the build, do you think we can have a quick review and > approve it; having this change pulled in 202405 stable release? Otherwise we will > have to wait until next stable release. > > Thanks > Abner > > > -----Original Message----- > > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> > > Sent: Thursday, May 2, 2024 3:31 AM > > To: devel@edk2.groups.io > > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > > zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com>; Chang, > > Abner <Abner.Chang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong- > > Chih.Hsueh@amd.com> > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > Cc: Jiangang He <jiangang.he@amd.com> > > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com> > > --- > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > b/MdePkg/Include/Register/Amd/Cpuid.h > > index add43c40aa..51fa9f235c 100644 > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > @@ -46,9 +46,9 @@ CPUID Signature Information > > CPUID Extended Topology Enumeration > > > > @note > > - Reference: AMD64 Architecture Programmer¡¯s Manual Volume 3: General- > > Purpose and System Instructions, > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > > Purpose and System Instructions, > > Revision 3.35 Appendix E, > > - E.4.24 Function 8000_0026¡ªExtended CPU Topology: > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > CPUID Fn8000_0026 reports extended topology information for logical > > processors, including > > asymmetric and heterogenous topology descriptions. Individual logical > > processors may report > > different values in systems with asynchronous and heterogeneous > > topologies. > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > index 756e7c86ec..4715c59dc4 100644 > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > @@ -5733,9 +5733,9 @@ typedef union { > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > enumerated > > in > > /// IA32_TME_CAPABILITY are allowed. > > /// For example: > > - /// 0000 ¨C AES-XTS-128. > > - /// 0001 ¨C AES-XTS-128 with integrity. > > - /// 0010 ¨C AES-XTS-256. > > + /// 0000 - AES-XTS-128. > > + /// 0001 - AES-XTS-128 with integrity. > > + /// 0010 - AES-XTS-256. > > /// Other values are invalid. > > /// > > UINT32 TmePolicy : 4; > > @@ -5756,7 +5756,7 @@ typedef union { > > /// Similar to enumeration, this is an encoded value. > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > #GP. > > /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware > > - /// Encryption Enable) is not also set to ¡®1, as encryption hardware must > be > > + /// Encryption Enable) is not also set to 1, as encryption hardware must > be > > /// enabled to use MKTME. > > /// Example: To support 255 keys, this field would be set to a value of 8. > > /// > > -- > > 2.40.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119449): https://edk2.groups.io/g/devel/message/119449 Mute This Topic: https://groups.io/mt/106484939/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 9996 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) 2024-06-04 15:45 ` Hsueh, Hong-Chih (Neo) via groups.io @ 2024-06-05 9:38 ` gaoliming via groups.io 0 siblings, 0 replies; 6+ messages in thread From: gaoliming via groups.io @ 2024-06-05 9:38 UTC (permalink / raw) To: 'Hsueh, Hong-Chih (Neo)', devel, 'Chang, Abner' Cc: michael.d.kinney, zhiguang.liu, 'He, Jiangang' [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb2312", Size: 7073 bytes --] I just add push label for it. ·¢¼þÈË: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> ·¢ËÍʱ¼ä: 2024Äê6ÔÂ4ÈÕ 23:46 ÊÕ¼þÈË: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com> ³ËÍ: michael.d.kinney@intel.com; zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com> Ö÷Ìâ: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) [AMD Official Use Only - AMD Internal Distribution Only] Hi Liming, Sorry for the late response. I already created a pull request for it. https://github.com/tianocore/edk2/pull/5737 Regards, Neo _____ From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Sent: Wednesday, May 15, 2024 8:08 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Chang, Abner <Abner.Chang@amd.com <mailto:Abner.Chang@amd.com> >; Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com <mailto:Hong-Chih.Hsueh@amd.com> > Cc: michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >; zhiguang. liu@intel.com <mailto:zhiguang.liu@intel.com> <zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> >; He, Jiangang <Jiangang.He@amd.com <mailto:Jiangang.He@amd.com> > Subject: »Ø¸´: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abner: This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com. cn <mailto:gaoliming@byosoft.com.cn> > But, this is not critical issue. So, I suggest to merge it after the stable tag. Thanks Liming > -----ÓʼþÔ¼þ----- > ·¢¼þÈË: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > ´ú±í Chang, Abner via > groups.io > ·¢ËÍʱ¼ä: 2024Äê5ÔÂ16ÈÕ 8:50 > ÊÕ¼þÈË: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com <mailto:Hong-Chih. Hsueh@amd.com> >; > devel@edk2.groups.io <mailto:devel@edk2.groups.io> > ³ËÍ: michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ; > zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> ; He, Jiangang <Jiangang.He@amd.com <mailto:Jiangang.He@amd.com> > > Ö÷Ìâ: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from > header file (BZ# 4775) > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, Liming and Zhiguang, > Could you please check this patch sent two weeks ago? The corresponding BZ > ticket is 4775. We overlooked tracking this issue and missed the 202405 stable > release. As this impacts the build, do you think we can have a quick review and > approve it; having this change pulled in 202405 stable release? Otherwise we will > have to wait until next stable release. > > Thanks > Abner > > > -----Original Message----- > > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com <mailto:Hong-Chih. Hsueh@amd.com> > > > Sent: Thursday, May 2, 2024 3:31 AM > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > > Cc: michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ; > > zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> ; He, Jiangang <Jiangang.He@amd.com <mailto:Jiangang.He@amd.com> >; Chang, > > Abner <Abner.Chang@amd.com <mailto:Abner.Chang@amd.com> >; Hsueh, Hong-Chih (Neo) <Hong- > > Chih.Hsueh@amd.com <mailto:Chih.Hsueh@amd.com> > > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > Cc: Jiangang He <jiangang.he@amd.com <mailto:jiangang.he@amd.com> > > > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com <mailto:Hong-Chih.Hsueh@amd.com> > > > --- > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > b/MdePkg/Include/Register/Amd/Cpuid.h > > index add43c40aa..51fa9f235c 100644 > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > @@ -46,9 +46,9 @@ CPUID Signature Information > > CPUID Extended Topology Enumeration > > > > @note > > - Reference: AMD64 Architecture Programmer¡¯s Manual Volume 3: General- > > Purpose and System Instructions, > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > > Purpose and System Instructions, > > Revision 3.35 Appendix E, > > - E.4.24 Function 8000_0026¡ªExtended CPU Topology: > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > CPUID Fn8000_0026 reports extended topology information for logical > > processors, including > > asymmetric and heterogenous topology descriptions. Individual logical > > processors may report > > different values in systems with asynchronous and heterogeneous > > topologies. > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > index 756e7c86ec..4715c59dc4 100644 > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > @@ -5733,9 +5733,9 @@ typedef union { > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > enumerated > > in > > /// IA32_TME_CAPABILITY are allowed. > > /// For example: > > - /// 0000 ¨C AES-XTS-128. > > - /// 0001 ¨C AES-XTS-128 with integrity. > > - /// 0010 ¨C AES-XTS-256. > > + /// 0000 - AES-XTS-128. > > + /// 0001 - AES-XTS-128 with integrity. > > + /// 0010 - AES-XTS-256. > > /// Other values are invalid. > > /// > > UINT32 TmePolicy : 4; > > @@ -5756,7 +5756,7 @@ typedef union { > > /// Similar to enumeration, this is an encoded value. > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > #GP. > > /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware > > - /// Encryption Enable) is not also set to ¡®1, as encryption hardware must > be > > + /// Encryption Enable) is not also set to 1, as encryption hardware must > be > > /// enabled to use MKTME. > > /// Example: To support 255 keys, this field would be set to a value of 8. > > /// > > -- > > 2.40.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119469): https://edk2.groups.io/g/devel/message/119469 Mute This Topic: https://groups.io/mt/106500097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 14565 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-05 9:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-01 19:31 [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file Hsueh, Hong-Chih (Neo) via groups.io 2024-05-16 0:49 ` [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Chang, Abner via groups.io 2024-05-16 1:08 ` 回复: " gaoliming via groups.io 2024-05-16 1:12 ` Chang, Abner via groups.io 2024-06-04 15:45 ` Hsueh, Hong-Chih (Neo) via groups.io 2024-06-05 9:38 ` 回复: " gaoliming via groups.io
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox