From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7405.1684931283272227245 for ; Wed, 24 May 2023 05:28:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cB51RKvT; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684931279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+pIpG0gb4pkQLASXBkDcRnnfNHTsqoJ6CRGpUsz8tM=; b=cB51RKvTAtJgUvyBDG+0U54K7eRiL6MVexHyBfNTk2dMmp8s3B0CSD8Wtvt+TYVZyFdfQF 6PsjMa0KSLt+PNuqV7ePch24SSYLdKqJGyhrTSniTgSOcKRmcl0PMiSlLEY00aQd1lvtAw 3xQhShkg9+cjHzQEPgak7Fut+SbTH1A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-8mDLf6gBOhG0ezKMJLXBgw-1; Wed, 24 May 2023 08:27:58 -0400 X-MC-Unique: 8mDLf6gBOhG0ezKMJLXBgw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C0C88037AB; Wed, 24 May 2023 12:27:58 +0000 (UTC) Received: from [10.39.192.76] (unknown [10.39.192.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA056482060; Wed, 24 May 2023 12:27:56 +0000 (UTC) Message-ID: <044df447-aacd-b4c7-7a58-301d2676e217@redhat.com> Date: Wed, 24 May 2023 14:27:55 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification() To: Gerd Hoffmann , devel@edk2.groups.io Cc: Rebecca Cran , Pawel Polawski , Oliver Steffen , Jordan Justen , Ard Biesheuvel , Ray Ni , Jiewen Yao , Ard Biesheuvel References: <20230524091117.302120-1-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20230524091117.302120-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/24/23 11:11, Gerd Hoffmann wrote: > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > being at it also remove it from Bhyve (where it is dead code). > > Fixed by commits: > - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") > - 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") > See also https://bugzilla.tianocore.org/show_bug.cgi?id=4195 > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > Reviewed-by: Ray Ni > --- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 29 -------------------------- > OvmfPkg/PlatformPei/Platform.c | 31 ---------------------------- > 2 files changed, 60 deletions(-) I disagree with this (v2) update. Bhyve platform code and QEMU platform code should not be fused into a common patch, if there's a way to avoid that. The reviewers for these C files are also different. If we want to modify Bhyve as a courtesy, we can certainly propose a *separate* patch for that. If others approve this patch, I can't block it from going in; since I've been CC'd (and I thought I'd comment this time), this is my view on it. Laszlo