From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4BCCE2272960C for ; Thu, 12 Apr 2018 09:49:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F2568DC32; Thu, 12 Apr 2018 16:49:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB11B20BC8C7; Thu, 12 Apr 2018 16:49:55 +0000 (UTC) To: Steve Capper , Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Supreeth Venkatesh References: <20180412005540.26651-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <047842b0-7b85-5669-a227-3b408090223f@redhat.com> Date: Thu, 12 Apr 2018 18:49:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 12 Apr 2018 16:49:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 12 Apr 2018 16:49:56 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 16:49:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/12/18 15:39, Steve Capper wrote: > On 12 April 2018 at 11:09, Ard Biesheuvel wrote: >> On 12 April 2018 at 02:55, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: depex_fixes >>> >>> ArmVirtQemu boots again, it just took a few more patches than I expected >>> :) >>> >>> Some of these patches will have to be ported to edk2-platforms, I think. >>> >>> Cc: Ard Biesheuvel >>> Cc: Leif Lindholm >>> Cc: Steve Capper >>> Cc: Supreeth Venkatesh >>> >>> Thanks, >>> Laszlo >>> >>> Laszlo Ersek (10): >>> Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify >>> ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf" >>> ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex >>> EmbeddedPkg: introduce NvVarStoreFormattedLib >>> ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly >>> ArmPlatformPkg/NorFlashDxe: cue the variable driver with >>> NvVarStoreFormatted >>> ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid >>> ArmPlatformPkg/PL031RealTimeClockLib: depend on >>> gEfiCpuArchProtocolGuid >>> ArmVirtPkg/PlatformHasAcpiDtDxe: depend on >>> gEfiVariableArchProtocolGuid >>> ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into >>> VariableRuntimeDxe >>> >> >> Laszlo, >> >> Thanks a lot for taking care of this. I am glad we finally got rid of >> the BEFORE depex in the NOR flash driver, which has been problematic >> for years. >> >> For the series, >> >> Reviewed-by: Ard Biesheuvel >> >> but please allow some time for Leif to chime in as well. >> >> Thanks, >> Ard. >> >> >> > > Hi Laszlo, > Thanks for this! > > I've booted with both DEBUG and RELEASE configurations on an FVP model > using this series. > I built this on Debian Stretch (using the AArch64 cross compiler). > > In order to test on FVP (which is defined in edk2-platforms), I made a > simple modification to: > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > (Basically mirroring what you did in patch #10) That's great; I'm relieved it wasn't more complex than that. :) > FWIW, feel free to add: > Tested-by: Steve Capper Thank you -- I'll add your T-b to the following patches: #2, #3, #4, #5, #6, #7, #8. As those patches affect modules that seem to be used by "edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc". Cheers! Laszlo