From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.54640.1594030315058362305 for ; Mon, 06 Jul 2020 03:11:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OEpmji2s; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594030314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mXxvP/czT9MZaxMqTT5RoKlPEw8Elb7P8SU+ARVgOGA=; b=OEpmji2sfsdy8kL0OKOf6av2dsS2cYcQ3ntXrykZbyIaqxPMgY1pAjwUehA5HcEC7n+Edp EPyTjru5KJa1I8zlTQqy/EbZEgjzw/9DfufRdRuxliSEQxidwOAzatNBwRwxxK0l9X0ylj 6d3mbdgxjvlfDC5kj1EFs4kwAffRXHQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-NDIrUop5PfGrtxb6PYJmFA-1; Mon, 06 Jul 2020 06:11:52 -0400 X-MC-Unique: NDIrUop5PfGrtxb6PYJmFA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 559B78015FA; Mon, 6 Jul 2020 10:11:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-194.ams2.redhat.com [10.36.114.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B8405D9D3; Mon, 6 Jul 2020 10:11:49 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE To: Eric Dong , Ray Ni , Hao A Wu Cc: devel@edk2.groups.io, garrett.kirkendall@amd.com References: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> From: "Laszlo Ersek" Message-ID: <049fb7c2-bfdd-4893-b511-28f940ba3b91@redhat.com> Date: Mon, 6 Jul 2020 12:11:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Ray, Hao, Eric, On 06/22/20 15:18, Kirkendall, Garrett wrote: > AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing > this register on AMD causes an unhandled exception in SmmEntry.nasm and > a subsequent failure to boot since this is too early in SMM path for the > exception handler to be loaded. > > 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to move > StandardSignatureIsAuthenticAMD into UefiCpuLib LibraryClass > BaseUefiCpuLib in UefiCpuPkg. > > 2. To distinguish between AMD and other processors, refactor > StandardSignatureIsAuthenticAMD into BaseUefiCpuLib. So there is only > one copy in the source. > > 3. Skip manipulation of MSR_IA32_MISC_ENABLE register if running > on an AMD processor. > > Tested on AMD X64 hardware. > OvmfIa32 and OvmfIa32X64 on Intel hardware. > > v1: Move StandardSignatureIsAuthenticAMD. Handle MSR_IA32_MISC_ENABLE > v2: Incorporate Laszlo's feedback > v3: Typo, not sent > v4: Patch in to add UefiCpuLib to PcAtChipsetPkg.dsc > v5: Patch in to add UefiCpuLib to SourceLevelDebugPkg.dsc > v6: Hopefully reformat patch when sending???? With fixed (commit 0060e0a694f3), this patch set should be merged now. I was about to do just that, but the review status of the series is still incomplete. Even though this patch series has been on the list for two weeks now. - Ray, can you please review patch#1 immediately? - Hao, can you please review patch#2 immediately? - Ray and Eric, can one of you please review patch #4 at once? Thanks Laszlo