From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=prXnLDq4; spf=permerror, err=too many SPF records (domain: system76.com, ip: 66.111.4.26, mailfrom: jeremy@system76.com) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by groups.io with SMTP; Mon, 23 Sep 2019 15:36:27 -0700 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 01BC021B34; Mon, 23 Sep 2019 18:36:27 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Mon, 23 Sep 2019 18:36:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wSjZ5e NATkC0wBzau1nJs5CX+ByudiKjiZmoVzlz2B4=; b=prXnLDq4qMcYMSwXG4eAg/ LXhQ4gGfVPdJWy1lXW64919w7uoo7N2UKMUmJo+LYotMqlHcug/lezQ2vMbL3dDT Xru8/B5lXNT5gim/eGBBY/A7vTsHuy4jTvlC1euijT+xQjaZUBGxT2rBwmiQF3MK 1kHbyDilldHVTqMZAW0bu0e6lZxu/1Pkdxvlqt/REoCIOl3LZlNi+ser7wCUrKHt kITwEqOTcAH/uXT3UbVEK9S846eBLnHOr+TTdhU82CM0tuYhAr0LG2ViJoevxMly cq5lk3PboBmByJ1OW5Anuyz2ijfCMdLHnxr2l/7qqNN1VV9k/z6P+L0ffc4RFF6g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdelgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedflfgvrhgv mhihucfuohhllhgvrhdfuceojhgvrhgvmhihsehshihsthgvmhejiedrtghomheqnecuff homhgrihhnpehtihgrnhhotghorhgvrdhorhhgnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjvghrvghmhiesshihshhtvghmjeeirdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id BB12FE00A5; Mon, 23 Sep 2019 18:36:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-238-g170a812-fmstable-20190913v1 Mime-Version: 1.0 Message-Id: <04a0777a-daa2-4d05-b403-73919da5c422@www.fastmail.com> In-Reply-To: <20190920184030.6148-7-michael.a.kubacki@intel.com> References: <20190920184030.6148-1-michael.a.kubacki@intel.com> <20190920184030.6148-7-michael.a.kubacki@intel.com> Date: Mon, 23 Sep 2019 16:36:06 -0600 From: "Jeremy Soller" To: "Michael A Kubacki" , devel@edk2.groups.io Cc: "Chasel Chiu" , "Nathaniel L Desimone" , "Ankit Sinha" Subject: Re: [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board Content-Type: text/plain Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > The flash map currently in KabylakeOpenBoardPkg is only > applicable to the KabylakeRvp3 board. This change moves > the flash map to that board directory to prepare for other > boards to reside in the package. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/{ => > KabylakeRvp3}/Include/Fdf/FlashMapInclude.fdf | 0 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf > similarity index 100% > rename from > Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > rename to > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index 7267d478ad..2b8eab36a1 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -8,7 +8,7 @@ > ## > > [Defines] > - !include $(PLATFORM_BOARD_PACKAGE)/Include/Fdf/FlashMapInclude.fdf > + !include $(PROJECT)/Include/Fdf/FlashMapInclude.fdf > > > ################################################################################ > # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > index ab1a9a61c2..78f808bfaf 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > @@ -13,7 +13,7 @@ openssl_path = > PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg > PROJECT = KabylakeOpenBoardPkg/KabylakeRvp3 > BOARD = KabylakeRvp3 > -FLASH_MAP_FDF = KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > +FLASH_MAP_FDF = > KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf > PROJECT_DSC = KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > BOARD_PKG_PCD_DSC = > KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc > ADDITIONAL_SCRIPTS = KabylakeOpenBoardPkg/KabylakeRvp3/build_board.py > -- > 2.16.2.windows.1 > >