From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web08.41.1665192396985600951 for ; Fri, 07 Oct 2022 18:26:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=cwO4xsJ8; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id D23A0CD1F7C5 for ; Sat, 8 Oct 2022 09:26:32 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1665192392; bh=JlNwkKjyq2Dc0sYO5cn8xsl5jf4nVYln+k7g70yLCBg=; h=From:To:References:In-Reply-To:Subject:Date; b=cwO4xsJ8d83aQkpzGj2OI2/qZ7ljD3vGR87oxIU2rykFXUENonuG8ymqqWKvQa09b 3LKHNEzciiHC8f7a+qk+KGmFw1Zk2YG8AIool2HYA8anO/tgP3mYVuftMPovBwZG6g ippTdnEXYYqV6rndxdrZK5Fr2CKtsiSuqPgcYmAc= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id CE105CD1F7CB for ; Sat, 8 Oct 2022 09:26:32 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id A0C50CD1F790 for ; Sat, 8 Oct 2022 09:26:32 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 453B7CD1F7CD for ; Sat, 8 Oct 2022 09:26:29 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 08 Oct 2022 09:26:28 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , References: <0da4bc04-851e-7028-9c34-e0b37bdf105c@linux.microsoft.com> <8117.1664496315698093072@groups.io> <029801d8d496$9a23a5c0$ce6af140$@byosoft.com.cn> <81bace66-07f4-2cc7-e2f1-da579f90b1c3@linux.microsoft.com> In-Reply-To: <81bace66-07f4-2cc7-e2f1-da579f90b1c3@linux.microsoft.com> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUkZDXSBBZG9wdGlvbiBvZiBDb2RlUUwgaW4gZWRrMg==?= Date: Sat, 8 Oct 2022 09:26:28 +0800 Message-ID: <04b001d8dab4$fdabc1d0$f9034570$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ/0571oNJryoCgm2E8LuXST4S6cAIohy8jAdDx41kA4E9YlgFTy/90rIRUrKA= Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Michael: I get your point to enable CodeQL rule step by step. This way doesn't imp= act normal PR process.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Michael > Kubacki > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B410=E6=9C=883=E6=97=A5 = 22:29 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io; > michael.d.kinney@intel.com > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] [RFC] Adoption o= f CodeQL in edk2 >=20 > I believe you are asking, when CodeQL CI is enabled in the edk2 project, > how soon after will all of the issues be fixed so CI passes? >=20 > The process that will be used to enable CodeQL in CI will follow what is > described in the "Enable One Query at a Time" section in the RFC > (https://github.com/tianocore/edk2/discussions/3258). >=20 > As proposed in that section, there should not be a time when a new > CodeQL CLI query is enabled that does not pass. Queries will be enabled > one at a time. Each time a new query is enabled, the query enable and > the corresponding changes will be staged on a branch that get merged to > edk2 master in a single PR. >=20 > CodeQL CI will run in that PR and it must pass for the PR to be completed= . >=20 > On 9/30/2022 2:33 AM, gaoliming wrote: > > Michael: > > > > Could you estimate when CodeQL CI check can pass after CodeQL > check > > is enabled? > > > > Thanks > > > > Liming > > > > *=E5=8F=91=E4=BB=B6=E4=BA=BA:*devel@edk2.groups.io *=E4=BB=A3=E8=A1=A8 *Michael > D Kinney > > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:*2022=E5=B9=B49=E6=9C=8830=E6=97= =A59:03 > > *=E6=94=B6=E4=BB=B6=E4=BA=BA:*devel@edk2.groups.io; mikuback@linux.micr= osoft.com; Kinney, > > Michael D > > *=E4=B8=BB=E9=A2=98:*Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 > > > > I just want to reiterate. If there are no concerns or objections raise= d > > by Oct 4, then the > > > > CodeQL static analysis will be phased into use in the edk2 repo and > > there will be code > > > > changes made to address the issues identified by COdeQL and all future > > code changes > > > > after a CodeQL check is enabled will be blocked until the CodeQL CI > > checks pass. > > > > This will impact all future code changes and all developers will have t= o > > learn how to > > > > interpret CodeQL reports and fix issues. > > > > Thanks, > > > > Mike > > > > *From:*devel@edk2.groups.io > > > *On Behalf Of > > *Michael Kubacki > > *Sent:* Thursday, September 29, 2022 5:05 PM > > *To:* Michael Kubacki > >; devel@edk2.groups.io > > > > *Subject:* Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 > > > > If there's any further feedback on this RFC, please respond by Tuesday, > > October 4th. We plan to start implementing the changes later in the wee= k. > > > > Thanks, > > Michael > > > > > > >=20 >=20 >=20 >=20