Re: [PATCH v3 09/15] ArmVirtPkg: GUID Hob for 16550 UART base address

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 6/24/20 3:34 PM, Sami Mujawar wrote:
> Introduce a new GUID Hob gEarly16550UartBaseAddressGuid
> to cache the base address of the 16550 UART, for when
> PCD access is not available.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>   ArmVirtPkg/ArmVirtPkg.dec                           |  2 ++
>   ArmVirtPkg/Include/Guid/Early16550UartBaseAddress.h | 22 ++++++++++++++++++++
>   2 files changed, 24 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec
> index 08ddd68a863eb82778fa7a92b20ac1bff271f5e5..bf82f7f1f3f2a0ce545d87fa93350f56de78328b 100644
> --- a/ArmVirtPkg/ArmVirtPkg.dec
> +++ b/ArmVirtPkg/ArmVirtPkg.dec
> @@ -1,6 +1,7 @@
>   #/** @file
>   #
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> +#  Copyright (c) 2020, ARM Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -30,6 +31,7 @@ [LibraryClasses]
>   [Guids.common]
>     gArmVirtTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } }
>     gEarlyPL011BaseAddressGuid       = { 0xB199DEA9, 0xFD5C, 0x4A84, { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } }
> +  gEarly16550UartBaseAddressGuid   = { 0xea67ca3e, 0x1f54, 0x436b, { 0x97, 0x88, 0xd4, 0xeb, 0x29, 0xc3, 0x42, 0x67 } }
>   
>     gArmVirtVariableGuid   = { 0x50bea1e5, 0xa2c5, 0x46e9, { 0x9b, 0x3a, 0x59, 0x59, 0x65, 0x16, 0xb0, 0x0a } }
>   
> diff --git a/ArmVirtPkg/Include/Guid/Early16550UartBaseAddress.h b/ArmVirtPkg/Include/Guid/Early16550UartBaseAddress.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..6b76f37a27dac03d6749f31a03e8026023231056
> --- /dev/null
> +++ b/ArmVirtPkg/Include/Guid/Early16550UartBaseAddress.h
> @@ -0,0 +1,22 @@
> +/** @file
> +  GUID for the HOB that caches the base address of the 16550 serial port, for
> +  when PCD access is not available.
> +
> +  Copyright (c) 2020, ARM Limited. All rights reserved.
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef EARLY_16550_UART_BASE_ADDRESS_H__
> +#define EARLY_16550_UART_BASE_ADDRESS_H__
> +
> +#define EARLY_16550_UART_BASE_ADDRESS_GUID {       \
> +  0xea67ca3e, 0x1f54, 0x436b, {                    \
> +    0x97, 0x88, 0xd4, 0xeb, 0x29, 0xc3, 0x42, 0x67 \
> +    }                                              \
> +  }
> +
> +extern EFI_GUID gEarly16550UartBaseAddressGuid;
> +
> +#endif // EARLY_16550_UART_BASE_ADDRESS_H__
>