Re: CorebootPayloadPkg: redirect UEFI Shell to serial

["Piotr Król" <piotr.krol@3mdeb.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 07/25/2017 11:16 AM, Laszlo Ersek wrote:
> On 07/15/17 15:00, Piotr Król wrote:

Hi Laszlo,

> 
>> 2. There are 2 minor typos like gUEfi instead of gUefi and
>> entrhy instead of entry, does it make sense to send patches for
>> that ? In various places I saw more typos like that.
> 
> Typo corrections are welcome.

Patch sent.

> 
>> 4. I had to move some PCDs to PcdsFixedAtBuild section.
> 
> Why?

After reading your post I know I made mistake by taking your reference
to PlatformBootManagerLib in ArmVirtPkg without rewriting it
correctly. They use FixedAtBuild, but CorebootPayloadPkg provide the
same parameters as dynamic PCDs - this is some inconsistency that I
wanted to address.

I resolve my issue by using const value when mSerialConsole is
created, the  druing runtime I use PcdGet calls family to get correct
values.

> 
>> This seems to makes difference for PcdSet64S. After that I'm
>> getting error from that function. Where I can read about
>> difference between normal PCD and FixedAtBuild
> 
> As their name says, fixed-at-build PCDs can't be set at runtime. -
> The .dec file declares the possible storage types for a given PCD
> that any platform can assign to the PCD. The .dec file also sets a
> default value. - in the platform .dsc file, the platform can omit
> the PCD completely. In this case modules built into the platform
> will get the default value from the .dec, and they won't be able to
> set the PCD. - the platform .dsc can also spell out the PCD. This
> determines the actual storage the platform assigns to the PCD (such
> as dynamic, dynamic-ex, dynamic-hii, fixed-at-build) and also lets
> the platform set its own default for the PCD. Modules built into
> the platform will see the following values for the PCD: - if the
> PCD is fixed-at-build, then they'll get the value set in the DSC.
> The PCD cannot be set by modules. - if the PCD is dynamic or
> dynamic-ex, then the initial value is the one set in the DSC.
> Modules can overwrite the PCD, and later "get"s will return that
> value. - if the PCD is dynamic-hii, then it is backed by a
> non-volatile UEFI variable.
> 
> ... This is quite a bit of hand-waving, but should be good enough
> for now. The way fixed-at-build PCDs seem to work for you is by
> design; I'd rather try to understand why you had to change a
> dynamic PCD into a fixed one.

Thanks for this explanation.

> 
> The rest of your questions should be directly addressed to the 
> maintainers of those packages / modules (see Maintainers.txt).

I will send that in coming days.

Best Regards,
- -- 
Piotr Król
Embedded Systems Consultant
https://3mdeb.com | @3mdeb_com
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE4DCbLYWmfoRjKeNLsu5x6WeqnkwFAlmFDb8ACgkQsu5x6Weq
nkxJ6w/7BWXNDvE/svknuasRds4m8mtask1dkEeq/2VFlivHMffb+s9Cz6um5fOj
xjtOdZxtQBfjUHG6dW34v1wThq9qnpr1550WJaXv4gum2zMc2G40ffkq5Hluko8s
0qEGyVknZMu5+Z5rEbxirV38UudjO8+onZb4FQE26RiaLPr0TjmrgZUhWtTdXlq9
TbuGFSVe0u3RcASehreRB11dpCuDEknlBIyLqISlw065uchGMnBBVtkrxv4yf/fk
vh+INY7ja/Ap2sKHp4/+7lQ5e+bk0WcdfjCGwbnszqB307sncHIm2Xx33aBktolS
NcHuIh3SVbfsHZ2SiwOEDClLd4UFuW5qvwnkXXVytBFHOIHpdAhLwpNM8+rvFw3t
6T/cajO0MyWaBzOcT5wK4N1PxKtgRWHc2iTbjENTdSUFK0CiX0wjVRoPtJdBjxGS
WdP7NnXoDP0GLkdvMf+1FvamJHLwgP/3p5rwZ/WXGR8ySWrkOfE8h7O00VlRHdf4
OcXcf3ZmLCSZFpxstv3b/V5pK4EDISAu5VeoUbamwsnZQhaaDALvqNcf80Kp/7Yi
eyVYLP+mQWnptzvPc1tqbF/Pb4tDPTGPHZXSDKYbfd0LXwyUaHkwwGr/0VKTD1r/
B2O1H1tVSIWSMW3atEUUCitidGSscxOGDmRJP6g2H6wuuoP9C2k=
=kE52
-----END PGP SIGNATURE-----